-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PressableWithFeedback wrap button choose file and give permission #28245
remove PressableWithFeedback wrap button choose file and give permission #28245
Conversation
@shawnborton @hoangzinh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hi @namhihi237. In the 3rd test step, I think it's clearer if we say:
What do you think? |
@hoangzinh yeah, I think it's clearer. I updated. Thanks for sugesstion |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-26.at.21.05.08.-.web.movMobile Web - ChromeScreen.Recording.2023-09-26.at.21.38.31.-.android.chrome.movMobile Web - SafariScreen.Recording.2023-09-26.at.21.41.24.-.ios.safari.movDesktopScreen.Recording.2023-09-26.at.21.09.08.-.desktop.moviOSScreen.Recording.2023-09-26.at.21.39.30.-.ios.mp4AndroidScreen.Recording.2023-09-26.at.21.10.20.-.android.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.75-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀
|
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
Details
Fixed Issues
$ #26993
PROPOSAL: #26993 (comment)
Tests
Offline tests
The same test
QA Steps
The same test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mweb.mov
Mobile Web - Safari
safari.mov
Desktop
Screen.Recording.2023-09-26.at.17.27.43.mov
iOS
ios.mov
Android
android.mov