[HOLD for payment 2023-10-09] [$500] [Distance] - The toggle attribution options disappear when they are hovered

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open request money
2. Change the tab to distance
3. Click on toggle attribution on bottom right side of map
4. Hover over the toggle attribution options

Expected Result:

The toggle attribution options should not hide when they are hovered

Actual Result:

The toggle attribution options gets hidden when hovered on web and also hidden when clicked on mweb

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

hover.mp4

20230905_160217.mp4

Recording.4624.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693917802357489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ead96ebe1b100d51
• Upwork Job ID: 1704487524512796672
• Last Price Increase: 2023-09-20
• Automatic offers:
• bernhardoj | Contributor | 26797717
• jo-ui | Reporter | 26797720

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ead96ebe1b100d51

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[bojangabric]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you hover attribution links in mapbox, text disappears.

What is the root cause of that problem?

The main cause is the color-scheme: dark !important; on the html element. Attribution links become white on hover because of this.

What changes do you think we should make in order to solve the problem?

We should create a .css file with the hover styles because there is no easy way to target elements through Mapbox. We did a similar thing on src/components/DatePicker/index.js.
Something like this is all we need:

.mapboxgl-ctrl-attrib-inner a:hover {
    color: rgba(0, 0, 0, .75);
}

What alternative solutions did you explore? (Optional)

The alternative solution is to remove color-scheme: dark !important; from html element. Not sure if that has any downsides.

[melvin-bot]

📣 @bojangabric! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bojangabric]

Contributor details
Your Expensify account email: bojangabric1997@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014c9f9349470cd9cb

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Toggle attribution link disappears when we hover it.

What is the root cause of that problem?

On the web, we use react-map-gl to render the map. By default, the attribution link has a hover style that sets the color of the text to inherit which means it will inherit the color from the parents.

However, none of the parents set any color property and because we set color-scheme to dark, it takes the white color. (if color-scheme is light, the color will be black).

What changes do you think we should make in order to solve the problem?

Set color style black to the map component.

App/src/components/MapView/MapView.web.tsx

Lines 82 to 91 in d00a4d6

	<Map
	ref={setRef}
	mapboxAccessToken={accessToken}
	initialViewState={{
	longitude: initialState.location[0],
	latitude: initialState.location[1],
	zoom: initialState.zoom,
	}}
	mapStyle={styleURL}
	>

style={StyleUtils.getTextColorStyle(themeColors.shadow) as React.CSSProperties}

We need to cast it to CSSProperties because style only accepts CSSProperties

Screen.Recording.2023-09-20.at.22.54.51.mov

[robertKozik]

Hi @bojangabric @bernhardoj! Thank you both for your proposals and insights on this issue. In my opinion, the solution presented by @bernhardoj is the better one. I believe it's better to utilize existing styles rather than directly referencing the component classes if possible.

Selected Proposal: #27863 (comment)
contributor: @bernhardoj

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @jo-ui 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @robertKozik

[melvin-bot]

🎯 ⚡️ Woah @robertKozik / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-21 13:20:50 Z
• when the PR got merged: 2023-09-26 12:10:27 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix map view attribution text is not visible on hover #27954

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @robertKozik does not require payment (Contractor)
• @jo-ui requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: It's not covered on original PR with implementation, so no particular PR introduce this behaviour
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don't think we need regression test for this as it's purely visual, one time, bug
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

tldr; I don't think we need the regression tests for this issue - it's rather one-time change, and bug won't come back anymore

[zanyrenney]

PAYMENT SUMMARY

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

@bernhardoj requires payment offer (Contributor) - PAID $500 + $250 URGENCY BONUS
@robertKozik does not require payment (Contractor) - OWED $500 + $250 URGENCY BONUS
@jo-ui requires payment offer (Reporter) PAID $50

[zanyrenney]

@robertKozik please seek your payment from ND. This is now all complete from Upwork/GH.

[robertKozik]

@zanyrenney as a contractor (Software Mansion) I'm not eligible for payment