-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix map view attribution text is not visible on hover #27954
Fix map view attribution text is not visible on hover #27954
Conversation
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -87,6 +89,7 @@ const MapView = forwardRef<MapViewHandle, MapViewProps>( | |||
latitude: initialState.location[1], | |||
zoom: initialState.zoom, | |||
}} | |||
style={StyleUtils.getTextColorStyle(themeColors.shadow) as React.CSSProperties} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure whether it makes sense to use themeColors.shadow
here. I'm thinking of creating a new theme color called mapAttributionText
that has a black color for both dark and light themes.
Let me know if we want to proceed with the plan above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay 🙇🏼 I believe it would be better to create a new constant inside themeColors
for this color. This way, it will always be black and independent of any color change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertKozik updated 👍
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid.-.web.movMobile Web - SafariiOS.-.web.movDesktopdesktop.moviOSiOS.-.native.movAndroidAndroid.-.native.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.75-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
Details
Hovering map view attribution text will change the color to white and makes it impossible to see because the bg color is white.
Fixed Issues
$ #27863
PROPOSAL: #27863 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Web/Desktop/mWeb
Android/iOS
Pressing the attribution icon will show a modal instead. Just verify that the modal shows and you can press any of the menu.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-09-21.at.23.08.15.mov
Mobile Web - Chrome
Screen.Recording.2023-09-21.at.23.09.23.mov
Mobile Web - Safari
Screen.Recording.2023-09-21.at.23.10.51.mov
Desktop
Screen.Recording.2023-09-21.at.23.11.45.mov
iOS
Screen.Recording.2023-09-21.at.23.10.02.mov
Android
Screen.Recording.2023-09-21.at.23.11.17.mov