[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

kbecciv · 2023-09-22T13:51:13Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on FAB and select "Assign Tasks"
Add a title and share it somewhere
Complete the tasks and reopen them, then delete them
Observe that the LHN subtitle is changed to "Deleted", which is correct
Add an attachment and observe that the subtitle changes to "Attachment", which is correct
Delete the attachment and observe that the LHN subtitle should change back to "Deleted", but instead it changes to "Not Active"

Expected Result:

After deleting assigned tasks, adding an attachment, and then deleting the attachment, the LHN subtitle should change back to "Deleted"

Actual Result:

After following the above steps, the LHN subtitle changes to "Not Active" instead of "Deleted"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-09-20T045952.964.webm

Recording.4685.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210969594049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dcaedc710fed40e3
Upwork Job ID: 1705218203708387328
Last Price Increase: 2023-09-29

melvin-bot · 2023-09-22T13:51:18Z

Job added to Upwork: https://www.upwork.com/jobs/~01dcaedc710fed40e3

melvin-bot · 2023-09-22T13:51:19Z

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-22T13:51:21Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-22T13:51:22Z

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-22T13:51:30Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

ZhenjaHorbach · 2023-09-22T14:30:57Z

Proposal

Please re-state the problem that we are trying to solve in this issue

After deleting a task, adding an attachment, and then deleting the attachment, the subtitle should change back to "Deleted"

What is the root cause of that problem?

After removing of the attachment
The number of reports becomes zero

App/src/libs/SidebarUtils.js

Lines 346 to 348 in 7bebfd3

    
           } else { 
        
               result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet'); 
        
           }

What changes do you think we should make in order to solve the problem?

We can add new condition for alternateText

 else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED) {
            result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.canceled')}: ${report.reportName}`;
        }

App/src/libs/SidebarUtils.js

Lines 338 to 348 in 7bebfd3

    
           const lastAction = visibleReportActionItems[report.reportID]; 
        
           if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.RENAMED) { 
        
               const newName = lodashGet(lastAction, 'originalMessage.newName', ''); 
        
               result.alternateText = Localize.translate(preferredLocale, 'newRoomPage.roomRenamedTo', {newName}); 
        
           } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKREOPENED) { 
        
               result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.reopened')}: ${report.reportName}`; 
        
           } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED) { 
        
               result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.completed')}: ${report.reportName}`; 
        
           } else { 
        
               result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet'); 
        
           }

What alternative solutions did you explore? (Optional)

NA

rojiphil · 2023-09-22T16:29:40Z

Dupe of #26679. Different problem but same RCA. That will solve this problem too.

mananjadhav · 2023-09-24T15:24:51Z

@isabelastisser @maddylewis We should put this on hold for 26679.

Thanks @rojiphil.

isabelastisser · 2023-09-25T13:52:04Z

Thanks @rojiphil!

Hey @mananjadhav, will this issue be solved once 26679 is fixed? If yes, should we close this one instead of putting it on Hold?

isabelastisser · 2023-09-27T19:08:08Z

@mananjadhav please follow up on my comment above, thanks!

melvin-bot · 2023-09-29T16:00:20Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mananjadhav · 2023-10-02T16:04:52Z

@isabelastisser Apologies I was OOO. Are you , @kbecciv, @rojiphil able to reproduce? If not we can close this one out. I don't have the bandwidth to get to this soon. If still needs a C+ (which I don't think it needs), can you please reassign?

isabelastisser · 2023-10-02T19:00:35Z

hey @rojiphil, can you please follow up on my comment here #28015 (comment)? thanks!

@rojiphil @kbecciv can you still reproduce this?

kbecciv · 2023-10-03T14:12:10Z

@isabelastisser Checking, will update you shortly.

kbecciv · 2023-10-03T14:18:59Z

Unable to reproduce it on build 1.3.76.4

Recording.4832.mp4

rojiphil · 2023-10-03T16:27:03Z

hey @rojiphil, can you please follow up on my comment here #28015 (comment)? thanks!

@isabelastisser @mananjadhav
Sorry for the delayed response.
The PR we were holding on to was merged in 1.3.76-0 here.
And, that solves the problem in this issue.
@kbecciv confirmed this in 1.3.76.4

isabelastisser · 2023-10-03T16:49:51Z

Thanks @rojiphil and @kbecciv! Closing!

tewodrosGirmaA · 2023-10-03T21:32:23Z

@isabelastisser am I eligible for payment?

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 22, 2023

melvin-bot bot changed the title ~~Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment~~ [$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment Sep 22, 2023

melvin-bot bot assigned isabelastisser Sep 22, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 22, 2023

melvin-bot bot assigned maddylewis Sep 22, 2023

melvin-bot bot assigned mananjadhav Sep 22, 2023

isabelastisser unassigned maddylewis Sep 25, 2023

melvin-bot bot added the Overdue label Oct 2, 2023

melvin-bot bot removed the Overdue label Oct 2, 2023

isabelastisser closed this as completed Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

kbecciv commented Sep 22, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

ZhenjaHorbach commented Sep 22, 2023 •

edited

Loading

rojiphil commented Sep 22, 2023

mananjadhav commented Sep 24, 2023

isabelastisser commented Sep 25, 2023

isabelastisser commented Sep 27, 2023

melvin-bot bot commented Sep 29, 2023

mananjadhav commented Oct 2, 2023 •

edited

Loading

isabelastisser commented Oct 2, 2023

kbecciv commented Oct 3, 2023

kbecciv commented Oct 3, 2023 •

edited

Loading

rojiphil commented Oct 3, 2023

isabelastisser commented Oct 3, 2023

tewodrosGirmaA commented Oct 3, 2023

[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

Comments

kbecciv commented Sep 22, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 22, 2023

melvin-bot bot commented Sep 22, 2023

ZhenjaHorbach commented Sep 22, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rojiphil commented Sep 22, 2023

mananjadhav commented Sep 24, 2023

isabelastisser commented Sep 25, 2023

isabelastisser commented Sep 27, 2023

melvin-bot bot commented Sep 29, 2023

mananjadhav commented Oct 2, 2023 • edited Loading

isabelastisser commented Oct 2, 2023

kbecciv commented Oct 3, 2023

kbecciv commented Oct 3, 2023 • edited Loading

rojiphil commented Oct 3, 2023

isabelastisser commented Oct 3, 2023

tewodrosGirmaA commented Oct 3, 2023

kbecciv commented Sep 22, 2023 •

edited by melvin-bot bot

Loading

ZhenjaHorbach commented Sep 22, 2023 •

edited

Loading

mananjadhav commented Oct 2, 2023 •

edited

Loading

kbecciv commented Oct 3, 2023 •

edited

Loading