[HOLD for payment 2023-10-12] [$500] Web - Task - @__fake__ shows up in the task when navigating back from threaded chat

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com.
2. Create a new workspace.
3. Go to the workspace chat.
4. Send a message and also send a reply to the message.
5. Return to workspace chat.
6. Create a task from + in the composer.
7. Return to the workspace chat.
8. Go to the thread message.
9. Return to workspace chat.
10. If fake does not show up in the task, go to the thread message and return to workspace chat again.

Expected Result:

@fake will not show up in the task.

Actual Result:

@fake shows up in the task.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.73-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

20230926_031930.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e09249224a2eba3e
• Upwork Job ID: 1706218574200713216
• Last Price Increase: 2023-09-25
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26976069
• tienifr | Contributor | 26976071

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e09249224a2eba3e

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[abekkala]

not overdue. looking for proposals

[zukilover]

The attached screen record doesn't seem to relate to the reproduction steps.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue

Web - Task - @fake shows up in the task when navigating back from threaded chat

What is the root cause of that problem?

When create a task without assignee, the taskAssigneeAccountID will be 0. The personalDetail with accountID = 0 will have the login and displayName as __fake__

What changes do you think we should make in order to solve the problem?

Solution 1:
If taskAssigneeAccountID is 0, we should not show the displayName, so we just need to add this condition in here

App/src/components/ReportActionItem/TaskPreview.js

Line 74 in f068ef1

const htmlForTaskPreview = taskAssignee ? `<comment><mention-user>@${taskAssignee}</mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;

Solution 2:

Filter out the personalDetails that have accountID is 0 when we get the personalDetailsList

Result

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@tienifr I am able to repro the issue in staging but not in main. Is this fixed in main somehow?

[abekkala]

The attached screen record doesn't seem to relate to the reproduction steps.

I agree and meant to note that as well. @izarutskaya

[tienifr]

@abdulrahuman5196 you can follow the step 10 If fake does not show up in the task, go to the thread message and return to workspace chat again.

I still can reproduce

[abdulrahuman5196]

@tienifr 's proposal (solution 1) here #28055 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abdulrahuman5196]

Not overdue melvin. We just approved a proposal

[Julesssss]

I think Melvin ignores messages from himself. Not sure if it's worth fixing though as this is desired for most messages.

[abdulrahuman5196]

I think Melvin ignores messages from himself. Not sure if it's worth fixing though as this is desired for most messages.

Yeah. I also think its fine. Because it mentions that week over messages as well which shouldn't affect overdue label.

[Julesssss]

A similar issue was raised here, I wonder if our proposal will also fix that issue.

[tienifr]

PR ready for review #28684.

[abdulrahuman5196]

A similar issue was raised here, I wonder if our proposal will also fix that issue.

I dont think so. This PR is specifically to avoid the @fake showing up, so wouldn't fix the other.

[melvin-bot]

🎯 ⚡️ Woah @abdulrahuman5196 / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-10-02 09:02:55 Z
• when the PR got merged: 2023-10-03 10:34:28 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: @__fake__ shows in task preview with no assignee #28684

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/325619

[abekkala]

PAYMENTS FOR OCT 12

• Applause (Reporter) - [no payment]
• @tienifr (Contributor) - [$500 + $250 bonus, if no regression]
• @abdulrahuman5196 (Reviewer) - [$500 + $250 bonus, if no regression - please complete the checklist prior to payments

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. But seems to be present from task implementation.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to a workspace with thread messages (or create one)
2. In workspace chat, create a task without assignee
3. Return to the workspace chat
4. Go to any thread in the chat
5. Return to workspace chat
6. Verify that @__fake__ doesn't show on task preview as an assignee.

[abekkala]

@tienifr and @abdulrahuman5196 payments made and contracts ended - thank you! 🎉