[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar #28626

lanitochka17 · 2023-10-02T15:48:33Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Click on plus and click on assign task
Enter any title and go to next step
Assign the task to user with avatar and display name set and complete the assign task process
Hover on @ user in task message and observe that tooltip is not displaying proper email and avatar

Expected Result:

App should display proper user details on task @user hover

Actual Result:

App does not display proper email and avatar on task @user hover

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.75-11

Reproducible in staging?: Yes

Reproducible in production?: NO

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

windows.chrome.user.tooltip.issue.mp4

mac.chrome.desktop.task.tooltip.issue.mov

Recording.122.mp4

Production

Recording.123.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696260115370229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014f1f51e85dd750ed
Upwork Job ID: 1709625207880982528
Last Price Increase: 2023-10-04
Automatic offers:

dukenv0307 | Contributor | 27104821
dhanashree-sawant | Reporter | 27104822

melvin-bot · 2023-10-02T15:48:39Z

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-02T15:48:41Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-10-02T15:50:11Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-02T15:50:17Z

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Julesssss · 2023-10-02T15:54:06Z

I'm not sure about this, but it might be fixed here

mountiny · 2023-10-02T15:54:46Z

I dont think this is a blocker at this point, its a minor issue but also I think it might be expected as it seems like its showing display name and I remember we wanted to update the mentions to show display name. Maybe @puneetlath could confirm

Julesssss · 2023-10-02T15:55:16Z

Agree not a blocker

trjExpensify · 2023-10-02T20:15:12Z

The mention display name PR is here and deployed: #26877 (comment)

So the question for @puneetlath is whether the profile in the tooltip should contain primaryLogin as well as displayName? I think it probably should, providing it's a "known" user and that login is revealed to the viewer.

abdulrahuman5196 · 2023-10-03T08:41:55Z

I'm not sure about this, but it might be fixed here

Just to note. This PR would not be fixing this issue.

tgolen · 2023-10-03T14:27:16Z

I'm going to unassign myself since this is not a blocker. I would suggest moving this to be an external issue once @puneetlath weighs in on the behavior.

trjExpensify · 2023-10-03T14:34:43Z

yuuuup! 👍

puneetlath · 2023-10-03T17:03:45Z

Hm, yes I think this is a bug. A direct mention does seem to render the tooltip properly:

But the task assignee doesn't:

Actually, I have a feeling this might have the same cause as: #22293 (comment)

trjExpensify · 2023-10-03T18:18:36Z

Inteeeresting. So is your preference to send it external for investigation or hold on #22293?

puneetlath · 2023-10-03T18:22:26Z

I think you can set it External. That's just a theory, but could be totally off.

abdel-h66 · 2023-10-03T18:23:33Z

To me it looks like we are not using the same logic for the Task assginee mention vs the chat mention. there was some updates to the metion renderer here #26306

Also in your screenshot @puneetlath See that in the task assignee we are using the Display name, while in the mention in the text message it's the login.

abdel-h66 · 2023-10-03T18:25:13Z

By using the Task assignee login, the display becomes consistent

const htmlForTaskPreview =
        taskAssignee && taskAssigneeAccountID !== 0 ? `<comment><mention-user>@${assigneeLogin}</mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;

melvin-bot · 2023-10-13T22:50:25Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: show proper avatar and display name when hovering #29146

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ArekChr does not require payment (Contractor)
@dukenv0307 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:50:27Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
[@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ArekChr] Determine if we should create a regression test for this bug.
[@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

ArekChr · 2023-10-16T11:59:02Z

Link to the PR: I'm unsure if should include this PR, but the feature displaying email/avatar was not designed at all in the MentionUserRenderer component. Here is the PR
Link to comment: n/a
Link to discussion: n/a
Determine if we should create a regression test for this bug: I don’t think we need to add a regression test here.

trjExpensify · 2023-10-16T17:58:24Z

Determine if we should create a regression test for this bug: I don’t think we need to add a regression test here.

Mind just elaborating on the "why?" here a touch?

melvin-bot · 2023-10-16T21:13:05Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: show proper avatar and display name when hovering #29146

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ArekChr does not require payment (Contractor)
@dukenv0307 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:13:07Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
[@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ArekChr] Determine if we should create a regression test for this bug.
[@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:38:26Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: show proper avatar and display name when hovering #29146

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@ArekChr does not require payment (Contractor)
@dukenv0307 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:38:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
[@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ArekChr] Determine if we should create a regression test for this bug.
[@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

ArekChr · 2023-10-17T11:02:42Z

@trjExpensify If we don't have tests for any tooltip with username and avatar, then I suggest adding this test.

Regression test proposal.

Assign the task to any user.
Enter any title and go to the next step.
Assign the task to the user with an avatar and display the name set.
Hover on the @ user in the task message and ensure the tooltip displays the proper email and avatar.

Do we agree 👍 or 👎

trjExpensify · 2023-10-17T21:10:28Z

Woah, why are there so many payment holds in the title of this issue? 😅

@ArekChr here's one of the regression tests for assigning a task. Perhaps we add it where I put it in bold below?

Navigate to a Group Chat
Click on the + in the compose box and select "Assign task"
Enter a a Title and a Description
Assign a user from the group that you have access to
Create the task
Verify you're navigated to the task "conversation"/report
Verify the assignee is displayed in the assignee field
Verify the tooltip displays the email and avatar of the assignee
Navigate back to the group conversation
Verify the task is displayed in the conversation history

melvin-bot · 2023-10-23T12:28:15Z

@puneetlath, @trjExpensify, @ArekChr, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify · 2023-10-23T15:32:53Z

okay, suggested that for Applause to add to the test case. Moving on to payments:

$50 to @dhanashree-sawant for the bug report
$750 to @dukenv0307 for the bug fix & #urgency bonus as per here.

trjExpensify · 2023-10-23T15:34:15Z

Settled up with you both, closing!

ArekChr · 2023-10-24T10:36:18Z

@ArekChr here's one of the regression tests for assigning a task. Perhaps we add it where I put it in bold below?

Agree!

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 2, 2023

melvin-bot bot assigned trjExpensify Oct 2, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 2, 2023

OSBotify mentioned this issue Oct 2, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

melvin-bot bot assigned tgolen Oct 2, 2023

mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 2, 2023

Julesssss mentioned this issue Oct 2, 2023

[HOLD for payment 2023-10-12] [$500] Web - Task - @__fake__ shows up in the task when navigating back from threaded chat #28055

Closed

6 tasks

tgolen removed their assignment Oct 3, 2023

melvin-bot bot added the Weekly KSv2 label Oct 13, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar~~ [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 20, 2023

melvin-bot bot removed the Overdue label Oct 23, 2023

trjExpensify closed this as completed Oct 23, 2023

MelvinBot mentioned this issue May 7, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.0 #41804

Open

50 tasks

melvin-bot bot mentioned this issue May 7, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.0 #41805

Closed

pavelbe4solutions mentioned this issue May 8, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.0 be4solutions/App#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar #28626

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar #28626

lanitochka17 commented Oct 2, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

OSBotify commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

Julesssss commented Oct 2, 2023 •

edited

Loading

mountiny commented Oct 2, 2023

Julesssss commented Oct 2, 2023

trjExpensify commented Oct 2, 2023

abdulrahuman5196 commented Oct 3, 2023 •

edited

Loading

tgolen commented Oct 3, 2023

trjExpensify commented Oct 3, 2023

puneetlath commented Oct 3, 2023

trjExpensify commented Oct 3, 2023

puneetlath commented Oct 3, 2023

abdel-h66 commented Oct 3, 2023

abdel-h66 commented Oct 3, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

ArekChr commented Oct 16, 2023

trjExpensify commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by trjExpensify

Loading

ArekChr commented Oct 17, 2023

trjExpensify commented Oct 17, 2023

melvin-bot bot commented Oct 23, 2023

trjExpensify commented Oct 23, 2023

trjExpensify commented Oct 23, 2023

ArekChr commented Oct 24, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar #28626

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar #28626

Comments

lanitochka17 commented Oct 2, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

Julesssss commented Oct 2, 2023 • edited Loading

mountiny commented Oct 2, 2023

Julesssss commented Oct 2, 2023

trjExpensify commented Oct 2, 2023

abdulrahuman5196 commented Oct 3, 2023 • edited Loading

tgolen commented Oct 3, 2023

trjExpensify commented Oct 3, 2023

puneetlath commented Oct 3, 2023

trjExpensify commented Oct 3, 2023

puneetlath commented Oct 3, 2023

abdel-h66 commented Oct 3, 2023

abdel-h66 commented Oct 3, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

ArekChr commented Oct 16, 2023

trjExpensify commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 • edited by trjExpensify Loading

ArekChr commented Oct 17, 2023

trjExpensify commented Oct 17, 2023

melvin-bot bot commented Oct 23, 2023

trjExpensify commented Oct 23, 2023

trjExpensify commented Oct 23, 2023

ArekChr commented Oct 24, 2023

lanitochka17 commented Oct 2, 2023 •

edited by melvin-bot bot

Loading

Julesssss commented Oct 2, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 3, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by trjExpensify

Loading