[$500] Profile - The timezone does not exist after toggle off Automatically determine your location

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition:

• Your browser should set timezone to America/Godthab or Asia/Saigon or America/Cordoba or Pacific/Samoa
• Follow method 1 on this guide to change (https://www.browserstack.com/guide/change-time-zone-in-chrome-for-testing)

1. Go to settings => profile => timezone
2. Change "Automatically determine your location" from on to off.
3. Select Timezone manual from dropdown list

Expected Result:

The timezone will show and auto select from "Automatically determine your location"

Actual Result:

No timezone selection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v 1.3.74-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

002.mp4

RPReplay_Final1695832227.MP4

RPReplay_Final1695690200.MP4

RPReplay_Final1695747320.MP4

Expensify/Expensify Issue URL:

Issue reported by: @suneox

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695577882053919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ad1c1482cffdc01
• Upwork Job ID: 1707072714927910912
• Last Price Increase: 2023-09-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015ad1c1482cffdc01

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - The timezone does not exist after toggle off Automatically determine your location

What is the root cause of that problem?

We are missing some timezones in TIMEZONES.js that make initiallyFocusedOptionKey is undefined and no option is focused

App/src/pages/settings/Profile/TimezoneSelectPage.js

Line 96 in 13b2291

initiallyFocusedOptionKey={_.get(_.filter(timezoneOptions, (tz) => tz.text === timezone.selected)[0], 'keyForList')}

What changes do you think we should make in order to solve the problem?

We should add those timezones that are missed in TIMEZONES.js

What alternative solutions did you explore? (Optional)

I think to BE should return the correct name of the timezone, example Asia/Saigon now is Asia/Ho_Chi_Minh, America/Cordoba now is America/Argentina/Cordoba.

[suneox]

@izarutskaya You have missed my proposal ^^

[aimane-chnaif]

@suneox's Proposal

Please re-state the problem that we are trying to solve in this issue.

The timezone does not exist after toggle off Automatically determine your location

What is the root cause of that problem?

The list of timezone is missing from

App/src/TIMEZONES.js

Line 1 in bb32cc5

// All timezones were taken from: https://raw.githubusercontent.com/leon-do/Timezones/main/timezone.json

What changes do you think we should make in order to solve the problem?

We should get data from a timezone database and I have parse List of tz database time zones upload file bellow we can replace for TIMEZONES.js

What alternative solutions did you explore? (Optional)

Create an automation script to update timezone list from Tz_database

  fetch(“https://en.wikipedia.org/wiki/List_of_tz_database_time_zones”).then(r => r.text()).then(html => {
    const $=cheerio.load(html);
    const timezones = $(“.wikitable.sortable:first tbody tr td:nth-child(2)“).map((k,v) => $(v).text()).toArray();
    // save to TIMEZONES.js
  })

[suneox]

The proposal from my comment in slack is missed attachment file so I would like to correct and update my alternative proposal bellow

Proposal

Please re-state the problem that we are trying to solve in this issue.

The timezone does not exist after toggle off Automatically determine your location

What is the root cause of that problem?

The list of timezone is missing from

App/src/TIMEZONES.js

Line 1 in bb32cc5

// All timezones were taken from: https://raw.githubusercontent.com/leon-do/Timezones/main/timezone.json

What changes do you think we should make in order to solve the problem?

We should get data from a timezone database and I have parse List of tz database time zones upload file bellow we can replace for TIMEZONES.js

What alternative solutions did you explore? (Optional)

The timezone will call API ?command=UpdateAutomaticTimezone at

App/src/libs/actions/PersonalDetails.js

Line 276 in 13b2291

function updateAutomaticTimezone(timezone) {

We can create a mapping config for timezone before submit to BE follow the tz_database backward link

const timezoneBackwardMap = {
    'Africa/Accra': 'Africa/Abidjan',
    'Africa/Addis_Ababa': 'Africa/Nairobi',
    .....
};

and update

App/src/libs/actions/PersonalDetails.js

Line 280 in 13b2291

timezone: JSON.stringify(timezone),

to

    {
        timezone: JSON.stringify({automatic: timezone.automatic, selected: timezoneBackwardMap[timezone.selected] || timezone.selected}),
    }

[suneox]

I recommended using the primary solution from my proposal we only updated the missing timezone and BE still store a user tz correctly

[joekaufmanexpensify]

I don't understand what the bug is here. This is working for me, and my sense is it is in the video as well. Discussing here.

[suneox]

@joekaufmanexpensify I have explained in this comment, and you have to change your device time to another country I provide in precondition step

[joekaufmanexpensify]

Closing this based on this discussion. I can't reproduce the bug, and we don't want to proceed if it is not consistently reproducible.