[HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] Task - No-entry mouse sign is displayed when hovering over 'Chevron' icon options displayed on 'Confirm task' page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on 'FAB' menu
2. Click on 'Assign task'
3. Enter title & click 'Next'
4. Hover over the chevron icon of 'Title', 'Assignee', 'Description', and 'Share somewhere' fields

Expected Result:

Hand icon should be displayed and the chevron icon should be clickable

Actual Result:

No-entry mouse sign is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native - mouse hover effect can't be tested
• Android / Chrome - mouse hover effect can't be tested
• iOS / native - mouse hover effect can't be tested
• iOS / Safari - mouse hover effect can't be tested
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-05.at.11.54.52.AM.mov

Screen.Recording.2023-10-05.at.11.43.46.AM.mov

Recording.4861.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696495753528999

View all open jobs on GitHub

[ishpaul777]

Proposal

Problem

not allowed cursor is displayed when hovering over 'Chevron' icon options displayed on 'Confirm task' page

Root cause

The PressableWithFeedBack component for right chevron icon has a disabled prop set to !props.onIconRightPress, we are not passing onIconRightPress prop to the component, so it is undefined and disabled prop is set to true. In fact we are not using onIconRightPress prop any of the MenuItem across the app.

App/src/components/MenuItem.js

Line 353 in 25f7ac1

disabled={!props.onIconRightPress}

offending PR : #26789

Solution

We need to modify the disabled prop to props.disabled instead of !props.onIconRightPress in PressableWithFeedBack component for right chevron icon in MenuItem component or we can remove the disabled prop also

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

I think this is regression from this PR #26778

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor is disabled on Right Icon on Confirm Task Page

What is the root cause of that problem?

We are handling different onPress event for iconRight, We have passed shouldShowRightIcon but have not passed onIconRightPress here.

App/src/pages/tasks/NewTaskPage.js

Lines 181 to 188 in 0cbee22

	<MenuItem
	label={assignee.displayName ? props.translate('task.assignee') : ''}
	title={assignee.displayName || ''}
	description={assignee.displayName ? LocalePhoneNumber.formatPhoneNumber(assignee.subtitle) : props.translate('task.assignee')}
	icon={assignee.icons}
	onPress={() => Navigation.navigate(ROUTES.NEW_TASK_ASSIGNEE)}
	shouldShowRightIcon
	/>

There is however one condition on onIconRightPress which is, if no present make the iconRight disabled, the below code will explain this line

App/src/components/MenuItem.js

Lines 352 to 354 in 180fd60

	accessible={!props.onIconRightPress}
	disabled={!props.onIconRightPress}
	onPress={props.onIconRightPress}

What changes do you think we should make in order to solve the problem?

We have to pass another prop which is onIconRightPress same as onPress like this

             <MenuItem
                        key={item.translationKey}
                        onPress={() => item.action()}
                        onIconRightPress={() => item.action() }

After passing this prop it will show the same cursor on iconRight and onPress will work as well as on hover it will show the expected behaviour

What alternative solutions did you explore? (Optional)

Or what we can do is by default onIconRightPress should be same as onPress prop in the MenuItem.js. This would keep the rightIcon work similar to the old behaviour till onIconRightPress prop is passed explicitly.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue.

[mountiny]

fixed https://github.com/Expensify/App/assets/36083550/e9372b0f-b47f-44f3-88f1-58303e39ff29

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@stephanieelliott Only payment is $50 to @Natnael-Guchima for reporting

[stephanieelliott]

@Natnael-Guchima I've extended the offer to you on Upwork, please accept when you get a chance!

https://www.upwork.com/jobs/~01b22c4c1e40175755

[Natnael-Guchima]

Accepted the offer. Thanks @stephanieelliott

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix disabled chevron of "MenuItem" #28931

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rezkiy37] Determine if we should create a regression test for this bug.
• [@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix disabled chevron of "MenuItem" #28931

If no regressions arise, payment will be issued on 2023-10-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rezkiy37] Determine if we should create a regression test for this bug.
• [@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

No need for regression PR, this was a small design bug and we handled it with the engineer related to the PR.

We should be good to pay this out which is only for reporting to @Natnael-Guchima $50

[mountiny]

cc @stephanieelliott

[stephanieelliott]

Summarizing payment on this issue:

• Issue reporter: @Natnael-Guchima $50, paid via Upwork
• Contributor: N/A
• Contributor+: N/A

Upwork job is here, no bonus on final payout