[HOLD for payment 2023-11-02] Category IOU - Incorrect ordering of subcategories in the category menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Prerequisites:
Account Setup https://sites.google.com/applausemail.com/applause-expensifyproject/guides/newdot-categories
Setting up categories 1) https://expensify.testrail.io/index.php?/tests/view/3767005
2) https://expensify.testrail.io/index.php?/tests/view/3767010

Steps:

1. Open https://staging.new.expensify.com/
   or app
2. Log in to your Employee account
3. Click on the FAB button
4. Click on 'Request Money'
5. Choose 'Manual' and add an amount
6. Click on the "Next" button
7. Select the configured WS
8. Click 'show more' and click on 'Category'

Expected Result:

Subcategories should be displayed laddered under each other with a space to the left

Actual Result:

The subcategory for the parent subcategory is not displayed in a ladder, but is displayed at the very end of the category list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6226514_1696541611456.Recording__434.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@rezkiy37 would you want to look into this one? It does seem like there is an issue with multiple levels of nesting. For example, this is what I'm seeing on this policy titled Collect Policy (which I just added you to).

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[rezkiy37]

@rezkiy37 would you want to look into this one? It does seem like there is an issue with multiple levels of nesting. For example, this is what I'm seeing on this policy titled Collect Policy (which I just added you to).

So, I've investigated this case. We have a problem when there are 2 "same" named categories. Actually, the app checks for a duplicate and ignores duplicated names. This case I am trying to handle and fix.

What about the attached video on a PR's description. Basically, the app does not order or re-order categories. I takes a list from the backend and iterates item by item. I want to make sure that we have a proper ordered list from the backend before.
@lanitochka17, could you please record network responses where there are updated category lists? Can we confirm that the backend sends the correct order?

[puneetlath]

@rezkiy37 and I worked together today and were able to reproduce the issue. He's working on the fix.

[rezkiy37]

@puneetlath, I have 4 updates and a question:

1. Already working on a draft PR - Fix incorrect ordering of subcategories #29281.
2. I've fixed the bug, when the app hides a category with the same name, but one of them is nested - [HOLD for payment 2023-11-02] Category IOU - Incorrect ordering of subcategories in the category menu #28964 (comment).
3. I've found and fixed a bug, when the app crashes, because of 2 nested categories with the same name, but different parent.
4. I extended tests to cover more cases.

Question:
Actually, the app receives categories with incorrect ordering. So, is it OldDot, NewDot or backend work to order categories in proper way? If it is NewDot's work, I cannot guarantee the same order, as user has in OldDot.

[puneetlath]

I think we should have NewDot do the ordering, because it isn't always going to receive a full list. For example, if we add a Category, the client will only receive the new category, not the updated entire list. So the client will need to do the ordering itself.

I cannot guarantee the same order, as user has in OldDot.

I think this is fine. Thanks for checking though!

[melvin-bot]

@puneetlath, @cubuspl42, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix incorrect ordering of subcategories #29281

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment
• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/331796

[rezkiy37]

I have to inform that starting tomorrow I have a short vocation until next Monday (6.11.2023). Feel free to left any comments, I will address them. See you soon 😉

[puneetlath]

Thanks @rezkiy37. I think you're all done here anyways. Last think is just the checklist from @cubuspl42

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • Category list helpers #25777
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • https://github.com/Expensify/App/pull/25777/files#r1377754553
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • Up to the QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • Initiate the Money Request Flow with a workspace.
  • Navigate to the "Categories" page.
  • Confirm that the categories are accurately nested following a parent-child relationship.
  • Ensure all subcategories are listed in alphabetical order.

[Christinadobrzyn]

whoops! sorry I thought I was on this GH. Well I created the regression test. Hopefully that's ok - https://github.com/Expensify/Expensify/issues/331796

[puneetlath]

All good, thanks for the help @Christinadobrzyn 😄

[melvin-bot]

@puneetlath, @cubuspl42, @rezkiy37 Eep! 4 days overdue now. Issues have feelings too...

[puneetlath]

@Christinadobrzyn did you also issue payment or is that still needed?

[Christinadobrzyn]

Hi, no sorry I didn't issue payment, just created the regression GH. Let me know if you want me to do that and I'll be happy to!

[puneetlath]

All good, I got it! Thanks for the quick response.

@cubuspl42 offer here: https://www.upwork.com/nx/wm/offer/27560910

Please ping me on this issue once you've accepted it.

[cubuspl42]

@puneetlath Accepted

[puneetlath]

Paid. Thanks everyone!