[HOLD for payment 2023-10-23][$500] Distance IOU - Save button inifinetly loading when opened from distance

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Navigate to a workspace chat
3. Tap "+" > Request money
4. Select "Distance" and create a money request
5. Navigate to the money request detail screen
6. Tap "Distance"
7. Without making any changes, tap the "Save" button

Expected Result:

User is navigated back to the money request detail screen

Actual Result:

The "Save" button is infinitely loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72-3

Reproducible in staging?: Yes

Reproducible in production?: No, when Distance is opened in production, it navigates to the merchant screen

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6226602_1696548671600.video_2023-10-05_19-28-40.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011d07e671b703f4b0
• Upwork Job ID: 1710417168605065216
• Last Price Increase: 2023-10-06
• Automatic offers:
• s-alves10 | Contributor | 27066246

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

console error when following the steps in staging:

[Onyx] An error occurred while applying merge for key: transactions_1383468151344720381, Error: TypeError: Cannot read properties of null (reading 'pendingFields')

[Beamanator]

It seems like the backend is sending undefined updates or something

[Beamanator]

Fix is up, asking for volunteers to review

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In edit distance money request, save button shows infinite loading when saving without change

What is the root cause of that problem?

We don't check change status of waypoint inputs when saving. And the backend returns onyx merge data null for the transaction for the UpdateDistanceRequest API if there is no change.

We set the isLoading to true optimistically and set to true when API call is finished

App/src/libs/actions/IOU.js

Line 754 in 779a1e5

isLoading: _.has(transactionChanges, 'waypoints'),

Onyx merging with null failed and can't merge successData and failureData and so isLoading remains true
This is the root cause

What changes do you think we should make in order to solve the problem?

We can fix this in frontend or backend, but I suggest to update both the frontend and backend

1. Backend should not return onyx merge null in any case
2. Frontend should not call the API if waypoints data are not changed. We can go back simply if there is no change

What alternative solutions did you explore? (Optional)

[Beamanator]

Looks like this bug exists on prod too :'(

Screen.Recording.2023-10-06.at.10.25.40.AM.mov

[Beamanator]

Not a deploy blocker, though the backend fix was merged.

Going to see if any internal eng working on distance requests wants to deal with this from here

• posted: https://expensify.slack.com/archives/C05DWUDHVK7/p1696577432551439

[redpanda-bit]

Is the backend not supposed to return value: null for onyx merge updates?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011d07e671b703f4b0

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: close modal simply when waypoints not changed in edit distance request #29047

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator / @neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator / @neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator / @neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s-alves10] Determine if we should create a regression test for this bug.
• [@s-alves10] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[petriyamamoto]

qw

[melvin-bot]

📣 @petriyamamoto! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: close modal simply when waypoints not changed in edit distance request #29047

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator / @neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator / @neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator / @neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s-alves10] Determine if we should create a regression test for this bug.
• [@s-alves10] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: close modal simply when waypoints not changed in edit distance request #29047

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator / @neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator / @neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator / @neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s-alves10] Determine if we should create a regression test for this bug.
• [@s-alves10] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Beamanator]

looks like this is ready for payment, not overdue

[lschurr]

@s-alves10 could you work on the checklist?

[lschurr]

Could you also accept the offer in Upwork @s-alves10 - https://www.upwork.com/nx/wm/offer/27066246

[dummy-1111]

@lschurr

I think C+ member would work on checklist. Should I work on that? I'm asking because I don't know well about this process

Offer accepted, thanks

[dummy-1111]

Regression Test Proposal

1. Open ND and log in with any account
2. Go to a workspace chat
3. Tap "+" button and select "Request money"
4. Select "Distance" tab and create a money request with any waypoints
5. Navigate to the money request detail page
6. Tap "Distance"
7. Tap "Save" button without any changes
8. Verify that user is navigated back to the money request detail page
9. Tap "Distance" again and make some changes to the waypoints
10. Tap "Save" button
11. Verify that the waypoints data are saved and navigated to the money request detail page

Do we agree 👍 or 👎

[lschurr]

Payment summary:

• Bug reporter: Applause (no payment)
• Contributor: @s-alves10 $750
• Contributor+: Internal (no payment)

[lschurr]

All done. Closing!