[HOLD for payment 2023-11-02] [$500] Chat - No details tooltip for assignee name on task title

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696778672195119

Action Performed:

1. Open any task report
2. Hover on assignee name in title section
3. Observe there is no user details

Expected Result:

There should be a user details tooltip when we hover on task title

Actual Result:

There is no user details tooltip when we hover on task title

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e82f506a63979657
• Upwork Job ID: 1711714321879621632
• Last Price Increase: 2023-10-10
• Automatic offers:
• jjcoffee | Reviewer | 27226207
• Krishna2323 | Contributor | 27226211
• Krishna2323 | Reporter | 27226213

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e82f506a63979657

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[kbecciv]

Proposal by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696778672195119

Proposal

Please re-state the problem that we are trying to solve in this issue.

No details tooltip for assignee name on task title.

What is the root cause of that problem?

We are not wrapping title text with UserDetailsTooltip.

What changes do you think we should make in order to solve the problem?

Option 1

We should add one more prop to MenuItem called shouldShowTitleTooltip or something like that and also pass data for it and based on that we will wrap title with UserDetailsTooltip.

Option 2

We can also use data passed in the avatar icon and show the UserDetailsTooltip on title based on that but I don't think that is the best way to do that.

Result

[jjcoffee]

@Krishna2323's proposal LGTM - I think option 1 makes the most sense.

I think we may want to avoid showing the tooltip when hovering over the assignee's name whilst we're on the Confirm Task screen, and only show it in the task detail view. cc @Expensify/design for thoughts.

[jjcoffee]

Forgot to add... 😄

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shawnborton]

Curious why we are treating this like a bug? This seems like polish that either @thienlnam or @jasperhuangg forgot to add to their PRs when they worked on this feature, so perhaps we just have one of them follow up?

Either way, I think we'd show the tooltip everywhere (including confirm screen) to stay consistent with what we do elsewhere?

[thienlnam]

Yeah this just looks like an improvement we can add to be consistent everywhere - and agree with showing the tooltip everywhere

[peterdbarkerUK]

Alrighty, @thienlnam @jasperhuangg do either of you want to pick this up?

[thienlnam]

I think it's best if we continue with this externally since my main focus is on the wave stuff (and it's not really a bug created by a previous PR) - I'll manage this as a CME but think we should keep this as external

[jjcoffee]

@thienlnam Makes sense to me! I think we're then good to hire @Krishna2323 (option 1 in his proposal).

[thienlnam]

I can't seem to assign external people who haven't participated in the convo - @Krishna2323 can you comment in this issue?

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Krishna2323]

@jjcoffee, PR ready for review.

[melvin-bot]

@peterdbarkerUK, @jjcoffee, @thienlnam, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jjcoffee]

PR is in active review, we're nearly there!

[jjcoffee]

Just a quick update - PR is C+ approved, just waiting for @thienlnam's approval and then we're good!

[melvin-bot]

@peterdbarkerUK @jjcoffee @thienlnam @Krishna2323 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @Krishna2323 got assigned: 2023-10-16 18:34:41 Z
• when the PR got merged: 2023-10-24 17:32:48 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Chat - No details tooltip for assignee name on task title. #29725

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment offer (Reviewer)
• @Krishna2323 requires payment offer (Contributor)
• @Krishna2323 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Krishna2323]

@peterdbarkerUK, bump for payments here.

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - this was never implemented
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes - easy enough to test
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to FAB -> Assign Task
2. Enter any title and tap Next
3. Assign to any user and verify that the user tooltip appears when you hover over the name
4. Confirm the task and verify that in the task report page the user tooltip also shows when you hover over the assignee

Do we agree 👍 or 👎

[peterdbarkerUK]

Payment Summary:

@jjcoffee $500 (Reviewer)
@Krishna2323 $500 (Contributor)
@Krishna2323 $50 (Reporter)

[peterdbarkerUK]

TR Request is up