fix: Chat - No details tooltip for assignee name on task title. #29725

Krishna2323 · 2023-10-16T22:31:05Z

Details

Fixed Issues

$ #29175
PROPOSAL: #29175 (comment)

Tests

Open any task report
Hover on assignee name in title section
Verify there is user details tooltip

Verify that no errors appear in the JS console

Offline tests

Open any task report
Hover on assignee name in title section
Verify there is user details tooltip

QA Steps

Open any task report
Hover on assignee name in title section
Verify there is user details tooltip

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

jjcoffee · 2023-10-17T10:12:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome-desktop-2023-10-17_11.58.06.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari-2023-10-17_12.01.27.mp4

Desktop

mac-desktop-2023-10-17_12.06.03.mp4

iOS

ios-native-2023-10-17_12.08.04.mp4

Android

android-native.mp4

jjcoffee · 2023-10-17T10:13:12Z

@Krishna2323 Not sure what happened to the automation here, can you try re-requesting a review from pullerbear (if you can!)?

src/components/ReportActionItem/TaskView.js

src/components/MenuItem.js

jjcoffee · 2023-10-17T10:55:53Z

@Krishna2323 I think one of the expected changes here was for the tooltip to show on the confirm screen. Or do you think this isn't consistent with elsewhere?

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

…323/App into krishna2323/issue/29175

Krishna2323 · 2023-10-18T08:26:02Z

@jjcoffee, can you pls have a look once again :), fixed the tooltip on task report page & task confirm page.

test_assignee_tooltip.mp4

jjcoffee · 2023-10-18T09:54:18Z

@Krishna2323 Lint and TS checks are failing.

src/components/MenuItem.js

jjcoffee · 2023-10-18T10:00:49Z

src/libs/actions/Task.js

@@ -721,6 +727,13 @@ function getShareDestination(reportID, reports, personalDetails) {
 icons: ReportUtils.getIcons(report, personalDetails, Expensicons.FallbackAvatar),
 displayName: ReportUtils.getReportName(report),
 subtitle,
+ displayNamesWithTooltips,
+ shouldShowDestinationTooltip:


Could you explain what this is based on?

We need to retrieve both the display name and tooltip details for all participants. Our previous code was functioning well when dealing with only assignee. However, tasks can be shared within groups, and given that a single group can comprise multiple users, it's essential to obtain the details for all users within these groups. From our report, we've procured the participant IDs. We then utilize these IDs to fetch the displayNamesWithTooltips.

src/pages/tasks/NewTaskPage.js

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2023-10-18T22:29:42Z

@jjcoffee, bump for a look at review comments.

Krishna2323 · 2023-10-19T09:18:47Z

@jjcoffee, Apologies for the follow-up. I'd appreciate it if we could have this approved within three working days. I believe there are no further changes needed.

src/components/MenuItem.js

src/components/menuItemPropTypes.js

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

jjcoffee · 2023-10-20T09:23:02Z

src/components/MenuItem.js

+ {Boolean(isEllipsisActive) && (
+ <View style={styles.displayNameTooltipEllipsis}>
+ <Tooltip text={props.title}>
+ {/* There is some Gap for real ellipsis so we are adding 5 `.` to cover */}


Can you explain why this is needed?

@Krishna2323 Oh wait I see you've taken this from DisplayNamesWithTooltip. I'm wondering now if there's any reason why we don't just use DisplayNames here actually, rather than reproducing most of the code from it?

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2023-10-23T07:03:31Z

@jjcoffee, bump.

jjcoffee · 2023-10-24T08:40:11Z

@Krishna2323 Code is looking much tidier, thanks! Could you just update the test steps to include that the tooltip should appear on the confirm task page too?

jjcoffee

LGTM!

thienlnam

Great, looks good thanks!

OSBotify · 2023-10-24T17:39:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-25T17:00:23Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:42:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Chat - No details tooltip for assignee name on task title.

faf0a09

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner October 16, 2023 22:31

jjcoffee reviewed Oct 17, 2023

View reviewed changes

src/components/ReportActionItem/TaskView.js Outdated Show resolved Hide resolved

jjcoffee reviewed Oct 17, 2023

View reviewed changes

src/components/MenuItem.js Outdated Show resolved Hide resolved

Krishna2323 added 9 commits October 18, 2023 12:52

fix: tooltip for assignee & share report.

79b030d

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

fix: getShareDestination function.

7046eac

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

cleaup.

9259899

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

cleaup.

9e1713d

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

fix: use displayNamesWithTooltips for assignee tooltip.

0228fbc

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

update: menuItemPropTypes. .

3e76f62

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/29175

ae62875

fix: add key for title content.

ab7df2f

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'krishna2323/issue/29175' of https://github.com/Krishna2…

7651afd

…323/App into krishna2323/issue/29175

jjcoffee reviewed Oct 18, 2023

View reviewed changes

src/components/MenuItem.js Show resolved Hide resolved

jjcoffee reviewed Oct 18, 2023

View reviewed changes

src/pages/tasks/NewTaskPage.js Outdated Show resolved Hide resolved

fix lint error.

f19e36c

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

jjcoffee reviewed Oct 19, 2023

View reviewed changes

src/components/MenuItem.js Outdated Show resolved Hide resolved

jjcoffee reviewed Oct 19, 2023

View reviewed changes

src/components/menuItemPropTypes.js Outdated Show resolved Hide resolved

jjcoffee reviewed Oct 19, 2023

View reviewed changes

src/components/menuItemPropTypes.js Outdated Show resolved Hide resolved

Krishna2323 added 3 commits October 20, 2023 00:36

fix: map item name, removed unnecessary flag.

cd039db

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

54dcc54

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

aa81479

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 added 2 commits October 20, 2023 01:14

fix: show title on tooltip ellipsis.

e29b08b

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

07c5236

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

jjcoffee reviewed Oct 20, 2023

View reviewed changes

Krishna2323 added 2 commits October 20, 2023 19:03

fix: use DisplayNamesWithTooltip for assignee tooltip.

f64ffd0

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

1608cca

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

jjcoffee approved these changes Oct 24, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam October 24, 2023 08:42

This comment was marked as resolved.

Sign in to view

thienlnam approved these changes Oct 24, 2023

View reviewed changes

thienlnam merged commit e9507a0 into Expensify:main Oct 24, 2023
14 checks passed

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

melvin-bot bot mentioned this pull request Oct 26, 2023

[HOLD for payment 2023-11-02] [$500] Chat - No details tooltip for assignee name on task title #29175

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Chat - No details tooltip for assignee name on task title. #29725

fix: Chat - No details tooltip for assignee name on task title. #29725

Krishna2323 commented Oct 16, 2023

jjcoffee commented Oct 17, 2023 •

edited

Loading

jjcoffee commented Oct 17, 2023

jjcoffee commented Oct 17, 2023

Krishna2323 commented Oct 18, 2023 •

edited

Loading

jjcoffee commented Oct 18, 2023

jjcoffee Oct 18, 2023

Krishna2323 Oct 18, 2023

Krishna2323 commented Oct 18, 2023

Krishna2323 commented Oct 19, 2023

jjcoffee Oct 20, 2023

jjcoffee Oct 20, 2023

Krishna2323 commented Oct 23, 2023

jjcoffee commented Oct 24, 2023

jjcoffee left a comment

This comment was marked as resolved.

thienlnam left a comment

OSBotify commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

fix: Chat - No details tooltip for assignee name on task title. #29725

fix: Chat - No details tooltip for assignee name on task title. #29725

Conversation

Krishna2323 commented Oct 16, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

jjcoffee commented Oct 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Oct 17, 2023

jjcoffee commented Oct 17, 2023

Krishna2323 commented Oct 18, 2023 • edited Loading

jjcoffee commented Oct 18, 2023

jjcoffee Oct 18, 2023

Choose a reason for hiding this comment

Krishna2323 Oct 18, 2023

Choose a reason for hiding this comment

Krishna2323 commented Oct 18, 2023

Krishna2323 commented Oct 19, 2023

jjcoffee Oct 20, 2023

Choose a reason for hiding this comment

jjcoffee Oct 20, 2023

Choose a reason for hiding this comment

Krishna2323 commented Oct 23, 2023

jjcoffee commented Oct 24, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

thienlnam left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

jjcoffee commented Oct 17, 2023 •

edited

Loading

Krishna2323 commented Oct 18, 2023 •

edited

Loading