Deploy Checklist: New Expensify 2023-10-25

[OSBotify]

Release Version: 1.3.91-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix: Two line markers appear for a second #25554
• Bidirectional pagination #26166
• [No QA] feat: add unit tests for edit money request and payment via vbba #27609
• [No QA] [TS migration] Migrate 'MapboxToken.js' lib to TypeScript #27999
• reafctor: migrated AddPersonalBankAccountPage component to the function #28251
• fix: ignore other actions if navigation in progress in menu Items #28338
• [No QA] Remove receipt from IOU report action #28424
• [No QA][TS migration] Migrate 'Session' lib to TypeScript #28697
• Fix: Android-Scan camera preview in Scan becomes blank #28792
• fix/28334: Missing displayName prop leads to console error (testID undefined) #28813
• fix: sort header display names and avatars in a group chat view #28991
• 22875 Add API Calls when clicking “Reveal details” buttons #29017
• Fix: Keyboard shouldn't be active/enabled automatically for request details #29086
• Improve conditions for allowing/disallowing editing a money request #29101
• Create Tips-And-Tricks.md #29244
• Fix incorrect ordering of subcategories #29281
• [No-QA] Images form Managing Employees and Reports > Approving Reports #29282
• redirect Anon user to sign in page on shortcut use #29323
• [No QA] Create Expensify-Card-Perks.md #29407
• [No QA][TS migration] Migrate 'withNavigationFocus.js' HOC to TypeScript #29426
• Delete docs/articles/expensify-classic/integrations/travel-integratio… #29515
• Show reply in thread option for all system messages #29528
• [NoQA] Improved initial state setting by calling initial setter only once #29630
• fix: Chat - Can't open context menu by long press on mentions. #29648
• Amount changing to zero when editing it by going back in split bill workflow #29654
• [No QA]Separate e2e test runs #29656
• Update UI to show fraud states #29680
• [No QA][TS migration] Remove CardOverlay.js - Dead code #29683
• fix: blank space for corrupt files preview #29692
• fix: Chat - No details tooltip for assignee name on task title. #29725
• [No QA] [TS migration] Migrate 'FixedFooter.js' component to TypeScript #29760
• [No QA] [TS Migration] Migrate withReportOrNotFound.js to TypeScript #29768
• Fix/29557: Delete receipt option appear on the receiver side #29791
• [No QA] [TS Migration] Migrate usePermissions.js to TypeScript #29856
• [No QA][TS migration] Migrate 'TestToolRow.js' & 'Text' components to TypeScript #29866
• Move currency selection language to a different object #29876
• Added 'name' field to waypoint #29931
• Fix can't close location error message while address suggestion dropdown is open #29932
• fix show thread first message #29934
• Remove old, unused EditTask params & stop unnecessary Onyx data setting #29943
• Migrate DatePicker/index.android.js to function component #29944
• Fix/29336: App crash on pay elsewhere #29946
• Fix/29868/requestor onfido props warnings #29950
• fix: Chat - App displays mention suggestion for sometime when we remove spaces before #29957
• Fix: 29552 IOU - The message "Only visible to you" does not disappear when editing details #29961
• [Form Provider Refactor] CloseAccountPage #29962
• [No QA] [TS Migration] migrate LottieAnimations.js to TypeScript #29969
• Prevent multiple redundant API calls for 2FA #29985
• Disallow flagging whispers #29994
• Update image border radius in Expensify Help #30010
• Optimized listening to hasDraft property changes #30031
• fix: 28698 Tapping emoji picker the message section is selected and shown #30048
• Fix report action draft still present after deleting the workspace #30049
• [Perf] ReportScreen rendering optimisation #30063
• Fix bug to show the secondary avatar when the repost is is a policy expense chat #30068
• Resolve Cursor Position Issue on Long-Press in Android Chrome #30082
• [CP Stag] Add GBR to pending wallet reports & update perview for 1:1 reports #30090
• [CP stag]Skip rendering IOU pay action for non-send money flow if the user needs to enable wallet or add bank account #30112
• fix for [Deleted message] keeps showing up #30131
• [NoQA] fix typo in offline UX documentation #30132
• Add popover anchor tooltip #30150
• Hide the thread that have not been commented #30154
• Update optimistic data for unit currency #30156
• [CP stag]Update wallet activate pending translation #30158
• [Form Provider Refactor] NewTaskDetailsPage #30165
• fix format phone number #30171
• Fix focus in tab in newchat #30172
• merge reportActions instead of set #30184
• [CP Staging] Fix missing footerContent in split details page #30185
• Use official github action for installation token #30187
• Update ReadMe to remove internal SO link for Android Setup #30189
• fix: vertical centering button text without padding #30192
• Update adhoc profile #30199
• Create receipt-breakdown #30221
• Fix Changed date appears for a second in LHN #30223
• fix: Attachment's close icon is not entirely clickable on the desktop app. #30225
• Fix going back from magic code page after refresh doesn't show the submitted email #30228
• fix: #30250 require cycle #30251
• Add github action for imgbot review and merge #30270
• [No QA]Move to M1 MacOS Runners (macos-13-xlarge) for building iOS and Desktop apps #30299
• Fix crash when opening sign in modal as anonymous user #30363
• [CP staging] fix/30373 - regression fix for NavigationAwareCamera #30397
• Build MacOS Desktop from Intel machines in order to support x86 #30402
• Revert "Amount changing to zero when editing it by going back in spli… #30403
• fix: update style if icon is in button #30417
• Add autoScrollToTopThreshold to main chat list #30461

Internal QA:

• added manifest to web to prompt app install in chrome #29491 - @rlinoz

Deploy Blockers:

• [HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] Request Money- Unable to cature image with camera button #30373
• [HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] IOU - After making manual &distance request, user is directed to request money BNP& Scan page #30386
• Request money - All currencies not displayed in search results #30387
• Room - App crashes when using CMD+K shortcut in public room as a logged out user #30389
• Home Page - Page crashes after refreshing home page #30394
• [HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] Android - Attachments- uploaded attachments can be seen only after scrolling up the page #30395
• mac12.5 - Unable to install the staging app #30396
• [PAID] BA - Icons and text on “Connect online with Plaid” button is offset relative other buttons #30400
• [HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] [$500] iOS - IOU - Empty space below IOU preview in 1:1 DM after paying elsewhere #30423

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[kbecciv]

Checking off the following PRs as they were deployed in past builds:

#25554
#28792
#28251
#28991
#29101
#29680
#29692
#29791
#29932
#29944
#29946
#29950
#29957
#29962
#29985
#29994
#30048
#30063
#30090
#30112
#30131
#30150
#30158
#30185
#30199

[kbecciv]

Are we ok to check it off below PR?
#30010 - Prod QA
#29244 - Prod QA

[kbecciv]

Regression is 25% done in TR.

[marcaaron]

I think #29491 is already on production right @rlinoz?

[marcaaron]

Are we ok to check it off below PR?
#30010 - Prod QA
#29244 - Prod QA

@kbecciv Those PRs can be tested on production right away (they should go straight to production) and can be tested now.

[mvtglobally]

@marcaaron are you saying that we don't need to wait for PROD deploys when testing HELP pages?

[marcaaron]

yes, my understanding is that you don't need to wait and it can be tested now.

[kbecciv]

Regression is 60 % done in TR.

PR #29086 is failing with #30386
PR #29876 is failing with #30387

[marcaaron]

Checking off #30373 as we deployed and CP'd a fix

[marcaaron]

Checking off #30394 should be fixed by #30363

[marcaaron]

Can we try to see if this is reproducible anymore? #30396

[mvtglobally]

@marcaaron We are able to install, so #30396 is not longer repro. But app is offline at the current moment. Not sure if this is build related, or just app Outage across

[marcaaron]

Yes, we were experiencing an outage. I think it has just been resolved.

[kbecciv]

Regression TR is only 5% left

PR #26166 is failing with #30385. Repro in Production, checking off
PR #29017 is failing with #30390. Repro in Production, checking off
PR #29086 is failing with #30390. Repro in Production, checking off
PR #29961 is failing with #29552. Repro in Production, checking off

[mvtglobally]

Regression is almost completed (3steps left)

Open blockers
#30386
#30395
#30400
#30423

Unchecked PRs
#29323 is failing #30389
#30402 internal QA #30402 (comment)
#30403 - Validating CP

#30363 is pass on all but Desktop. Desktop is blocked by KI #25790. Ok to check off?

[mvtglobally]

Regression is done

[marcaaron]

Checking off #30400 as it is fixed now on staging.

[marcaaron]

#30363 is pass on all but Desktop. Desktop is blocked by KI #25790. Ok to check off?

I would say yes, because people don't really "refresh" the desktop app.

[marcaaron]

Noting: There is a “fresh crash” for the current staging version here https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues/cde14f9da341ac3df72730b0ddd65f39?time=last-seven-days&types=crash&sessionEventKey=653A40BF02FE00011BE1D336FD4CE3FB_1872698221178451523 on Android.

It looks benign to me. The package is react-native-blob-util and there was a single crash on Android - but the files using this package have not been changed in this release.

[marcaaron]

Checking off #30395 #30423 as they should both be fixed on the staging branch now (not yet deployed to staging).

I will re-test in a bit and start the deploy shortly.

[marcaaron]