[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

kbecciv · 2023-10-10T17:55:02Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696924602489199

Action Performed:

Open the app and login with user A
Open the app using any other device and login with user B
From user A, add user B as member in any of user A workspaces
From user A, open workspace chat created newly after step 3
From user B, click on green plus button situated in LHN of app
From user B, click on request money->manual
Type in any amount and click Next
In the user list, click on split besides workspace report name used in step 3 and finish the request money process
From user A, click on split bill message and observe that in details, instead of workspace name it displays username

Expected Result:

App should display workspace name besides workspace avatar in split bill details page

Actual Result:

App displays username name besides workspace avatar to admin user in split bill details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

android.native.wrong.workspace.name.split.details.mp4

Android: mWeb Chrome

android.chrome.wrong.split.bill.workspace.name.mp4

iOS: Native

ios.native.split.bill.wrong.workspace.name.1.mov

iOS: mWeb Safari

ios.safari.wrong.split.bill.workspace.name.mov

MacOS: Chrome / Safari

mac.chrome.wrong.split.bill.workspace.name.mov

windows.chrome.wrong.workspace.name.split.bill.mp4

Recording.4932.mp4

MacOS: Desktop

mac.desktop.wrong.split.bill.workspace.name.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015f60ccd423ab1d2e
Upwork Job ID: 1711802547356061696
Last Price Increase: 2023-10-10
Automatic offers:

s77rt | Reviewer | 27154595
akamefi202 | Contributor | 27154596
dhanashree-sawant | Reporter | 27154598

melvin-bot · 2023-10-10T17:55:08Z

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-10T17:55:08Z

Job added to Upwork: https://www.upwork.com/jobs/~015f60ccd423ab1d2e

melvin-bot · 2023-10-10T17:55:10Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-10T17:55:14Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

akamefi202 · 2023-10-10T21:05:12Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace split bill displays user name instead of workspace name in split details.

What is the root cause of that problem?

App/src/libs/OptionsListUtils.js

Lines 99 to 102 in b5445bd

    
           function getPolicyExpenseReportOption(report) { 
        
               const expenseReport = policyExpenseReports[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]; 
        
               const policyExpenseChatAvatarSource = ReportUtils.getWorkspaceAvatar(expenseReport); 
        
               const reportName = ReportUtils.getReportName(expenseReport);

The app gets the information to display inside getPolicyExpenseReportOption function.
And inside it, the app calls getReportName function to get name.

App/src/libs/ReportUtils.js

Lines 1798 to 1800 in b5445bd

    
           if (isPolicyExpenseChat(report)) { 
        
               formattedName = getPolicyExpenseChatName(report, policy); 
        
           }

Inside getReportName function, it calls getPolicyExpenseChatName function to get the name of workspace.

App/src/libs/ReportUtils.js

Lines 1308 to 1310 in b5445bd

    
           if (report.isOwnPolicyExpenseChat) { 
        
               return getPolicyName(report, false, policy); 
        
           }

But the getPolicyExpenseChatName function returns workspace name only if policy is owned by the user.
If not, it returns the name of owner.

As a result, we see the name of user B instead of the workspace name if we check split details as user A.
Because the policy is owned by user B.

What changes do you think we should make in order to solve the problem?

We should call getPolicyName function directly inside getPolicyExpenseReportOption function.
Because we're always meant to get workspace name here.

const workspaceName = ReportUtils.getPolicyName(expenseReport);

What alternative solutions did you explore? (Optional)

N/A

mallenexpensify · 2023-10-11T02:41:01Z

@s77rt can you please review @akamefi202 's proposal? Thx

s77rt · 2023-10-11T13:21:27Z

@akamefi202 Thanks for the proposal. Your RCA is correct and the solution looks good to me 👍

🎀 👀 🎀 C+ reviewed
Link to proposal

melvin-bot · 2023-10-11T13:21:33Z

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

mallenexpensify · 2023-10-12T01:37:41Z

@lakchote 👀 please on the proposal above when ya have a min

melvin-bot · 2023-10-12T05:24:02Z

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-12T05:24:07Z

📣 @akamefi202 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-12T05:24:11Z

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

lakchote · 2023-10-12T05:24:23Z

@akamefi202 proposal LGTM.

akamefi202 · 2023-10-12T05:35:14Z

I accepted the offer and PR will be ready by today.

melvin-bot · 2023-10-13T06:19:37Z

🎯 ⚡️ Woah @s77rt / @akamefi202, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @akamefi202 got assigned: 2023-10-12 05:24:07 Z
when the PR got merged: 2023-10-13 06:19:36 UTC

On to the next one 🚀

melvin-bot · 2023-10-16T21:27:33Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:52:48Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

update text and alternateText in getPolicyExpenseReportOption function #29424

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment offer (Reviewer)
@akamefi202 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:52:51Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt · 2023-10-16T23:55:04Z

The PR that introduced the bug has been identified: Workspaces in money request modal #17132
The offending PR has been commented on: Workspaces in money request modal #17132 (comment)
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No

mallenexpensify · 2023-10-17T21:43:44Z

@s77rt what's your reasoning for not wanting a regression test for this?

s77rt · 2023-10-18T02:37:48Z

@mallenexpensify Due to the nature of the bug I don't think it would resurface again where a regression test would be needed. Do you think we would be better with a test for this case?

Christinadobrzyn · 2023-10-18T19:14:31Z

Hey @mallenexpensify - there was an accidental overpayment to @akamefi202 on this job (payment was $1000 but there were some regressions so the actual payment should have been $250).

Is it possible to adjust the payment from this one? cc @akamefi202

s77rt · 2023-10-18T22:44:13Z

@Christinadobrzyn I think @akamefi202 can issue a refund for that past payment

mallenexpensify · 2023-10-18T23:32:05Z

@Christinadobrzyn , I'd recommend requesting a refund on that job then, once it's confirmed, I can pay this one out. Assuming we do that, we should also update the title to reflect to hold (so I don't forget)

akamefi202 · 2023-10-23T16:41:41Z

@mallenexpensify @s77rt Could you please finish this issue if you have any time?

Christinadobrzyn · 2023-10-23T17:05:59Z

Ah okay, thanks @mallenexpensify I do see the option to request a refund on this job so I did that. Just a heads up @akamefi202 I requested a partial refund for this job through Upwork.

akamefi202 · 2023-10-23T18:36:27Z

@mallenexpensify Could you please pay here first? That $1000 payment was more than 3 weeks ago so that I don't have enough money for refund in Upwork now. I promise that I will do refund.

mallenexpensify · 2023-10-24T23:19:27Z

Oooof, that is a tricky situation @akamefi202. I just paid this

Issue reporter: @@dhanashree-sawant paid $50 via Upwork
Contributor: @akamefi202 paid $750 via Upwork. Please accept/pay the refund for the other job
Contributor+: @s77rt paid $750 via Upwork.

@s77rt I wasn't sure about the regression test so I created on, Applause/QA will do something with it if they think it'd be helpful
https://github.com/Expensify/Expensify/issues/329593

Gonna leave this open and a weekly til I'm able to confirm @akamefi202 's refund for the other issue.

mallenexpensify · 2023-11-03T23:37:31Z

Awaiting refund on other issue
#26214 (comment)

akamefi202 · 2023-11-06T06:32:34Z

@mallenexpensify Sorry for late reply. I was OOO last week. I made the refund and I think we might close this issue now.

mallenexpensify · 2023-11-06T20:30:55Z

Thanks @akamefi202 , confirming refund was issued for #26214

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 10, 2023

melvin-bot bot changed the title ~~Details - Workspace split bill displays user name instead of workspace name to admin~~ [$500] Details - Workspace split bill displays user name instead of workspace name to admin Oct 10, 2023

melvin-bot bot assigned mallenexpensify Oct 10, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 10, 2023

melvin-bot bot assigned s77rt Oct 10, 2023

melvin-bot bot assigned lakchote Oct 11, 2023

lakchote assigned akamefi202 Oct 12, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

akamefi202 mentioned this issue Oct 12, 2023

update text and alternateText in getPolicyExpenseReportOption function #29424

Merged

59 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 12, 2023

Christinadobrzyn mentioned this issue Oct 12, 2023

[HOLD for payment 2023-09-27] [$1000] Link Request Money not work #26214

Closed

6 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 23, 2023

mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 24, 2023

melvin-bot bot added the Overdue label Nov 2, 2023

melvin-bot bot removed the Overdue label Nov 3, 2023

mallenexpensify closed this as completed Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

kbecciv commented Oct 10, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

akamefi202 commented Oct 10, 2023 •

edited

Loading

mallenexpensify commented Oct 11, 2023

s77rt commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

mallenexpensify commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

lakchote commented Oct 12, 2023

akamefi202 commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

s77rt commented Oct 16, 2023

mallenexpensify commented Oct 17, 2023

s77rt commented Oct 18, 2023

Christinadobrzyn commented Oct 18, 2023

s77rt commented Oct 18, 2023

mallenexpensify commented Oct 18, 2023

akamefi202 commented Oct 23, 2023

Christinadobrzyn commented Oct 23, 2023

akamefi202 commented Oct 23, 2023

mallenexpensify commented Oct 24, 2023

mallenexpensify commented Nov 3, 2023

akamefi202 commented Nov 6, 2023

mallenexpensify commented Nov 6, 2023 •

edited

Loading

[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

Comments

kbecciv commented Oct 10, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 10, 2023

akamefi202 commented Oct 10, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mallenexpensify commented Oct 11, 2023

s77rt commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

mallenexpensify commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

lakchote commented Oct 12, 2023

akamefi202 commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

s77rt commented Oct 16, 2023

mallenexpensify commented Oct 17, 2023

s77rt commented Oct 18, 2023

Christinadobrzyn commented Oct 18, 2023

s77rt commented Oct 18, 2023

mallenexpensify commented Oct 18, 2023

akamefi202 commented Oct 23, 2023

Christinadobrzyn commented Oct 23, 2023

akamefi202 commented Oct 23, 2023

mallenexpensify commented Oct 24, 2023

mallenexpensify commented Nov 3, 2023

akamefi202 commented Nov 6, 2023

mallenexpensify commented Nov 6, 2023 • edited Loading

kbecciv commented Oct 10, 2023 •

edited by melvin-bot bot

Loading

akamefi202 commented Oct 10, 2023 •

edited

Loading

mallenexpensify commented Nov 6, 2023 •

edited

Loading