update text and alternateText in getPolicyExpenseReportOption function #29424

akamefi202 · 2023-10-12T11:25:41Z

Details

After the user B sends split request with the workspace of user A.
The split details page shows username instead of workspace name, when user A sees the details of split request message.

This is happening because the app currently shows workspace name only if the policy is owned by user.
We should update text and alternateText correctly inside getPolicyExpenseReportOption function.

Fixed Issues

$ #29219
PROPOSAL: #29219 (comment)

Tests

Open the app and login with user A.
Open the app using any other device and login with user B.
From user A, add user B as member in any of user A workspaces.
From user A, open workspace chat created newly after step 3.
From user B, click on green plus button situated in LHN of app.
From user B, click on request money->manual.
Type in any amount and click Next.
In the user list, click on split besides workspace name used in step 3 and finish the request money process.
From user A, click on split bill message and observe that in details.
Check if the split details page displays workspace name, not username.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

REC-20231012174106.webm

Android: mWeb Chrome

REC-20231012161725.mp4

iOS: Native

REC-20231012174105.mp4

iOS: mWeb Safari

REC-20231012152255.mp4

MacOS: Chrome / Safari

REC-20231012150602.mp4

MacOS: Desktop

REC-20231012151454.mp4

melvin-bot · 2023-10-12T11:25:46Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-10-12T17:38:05Z

@akamefi202 The PR is different than the proposal after #29164. Can you check if we can revert that PR and still fix the other issue? Adding checkPolicyOwner prop seems too much overhead

akamefi202 · 2023-10-12T18:03:44Z

@s77rt
We can fix #28731 by only inputting correct value to icons parameter instead of using createOption function.
Like this proposal, #28731 (comment)
If we fix that issue like that, we can fix this issue with original proposal.

s77rt · 2023-10-12T18:12:23Z

Hmm I think it would be safer if we just overwrote the text field?

option.text = ReportUtils.getPolicyName(expenseReport);

akamefi202 · 2023-10-12T18:18:06Z

@s77rt That's possible. We should update alternateText too. If you think that it's appropriate, I will update the PR.

s77rt · 2023-10-12T18:26:06Z

Yes please do that and add a comment explaining why we need to overwrite those fields

src/libs/OptionsListUtils.js

s77rt · 2023-10-12T19:38:59Z

@akamefi202 Please attach screenshots/videos

akamefi202 · 2023-10-12T22:26:51Z

@s77rt I uploaded all screen records. Please review.

s77rt · 2023-10-13T02:11:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt · 2023-10-13T02:12:09Z

@akamefi202 Thanks!

OSBotify · 2023-10-13T06:25:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:11:31Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:11:59Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:48:19Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:51:15Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:16:00Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

akamefi202 requested a review from a team as a code owner October 12, 2023 11:25

melvin-bot bot requested review from s77rt and removed request for a team October 12, 2023 11:25

akamefi202 force-pushed the split-details-workspace-name branch from b27d03e to d1ad56c Compare October 12, 2023 15:32

akamefi202 added 4 commits October 13, 2023 02:48

add checkPolicyOwner parameter

e288859

add jsdoc

83be645

fix lint error

1b84d3c

set text and alternate text

fdca0ec

akamefi202 force-pushed the split-details-workspace-name branch from d1ad56c to fdca0ec Compare October 12, 2023 18:49

add comment

7bc1fcb

akamefi202 changed the title ~~add checkPolicyOwner parameter~~ update text and alternateText in getPolicyExpenseReportOption function Oct 12, 2023

s77rt suggested changes Oct 12, 2023

View reviewed changes

src/libs/OptionsListUtils.js Outdated Show resolved Hide resolved

resolve suggestion

1ef2811

s77rt approved these changes Oct 13, 2023

View reviewed changes

melvin-bot bot requested a review from lakchote October 13, 2023 02:12

lakchote approved these changes Oct 13, 2023

View reviewed changes

lakchote merged commit be54929 into Expensify:main Oct 13, 2023
15 checks passed

akamefi202 deleted the split-details-workspace-name branch October 13, 2023 06:22

OSBotify mentioned this pull request Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

lanitochka17 mentioned this pull request Oct 14, 2023

Split - Total group split details card does not appear in chat until the chat is revisited #29634

Closed

6 tasks

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

melvin-bot bot mentioned this pull request Oct 16, 2023

[HOLD awaiting refund from overpayment] [$500] Details - Workspace split bill displays user name instead of workspace name to admin #29219

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update text and alternateText in getPolicyExpenseReportOption function #29424

update text and alternateText in getPolicyExpenseReportOption function #29424

akamefi202 commented Oct 12, 2023 •

edited

Loading

melvin-bot bot commented Oct 12, 2023

s77rt commented Oct 12, 2023

akamefi202 commented Oct 12, 2023 •

edited

Loading

s77rt commented Oct 12, 2023

akamefi202 commented Oct 12, 2023

s77rt commented Oct 12, 2023

s77rt commented Oct 12, 2023

akamefi202 commented Oct 12, 2023

s77rt commented Oct 13, 2023

s77rt commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

update text and alternateText in getPolicyExpenseReportOption function #29424

update text and alternateText in getPolicyExpenseReportOption function #29424

Conversation

akamefi202 commented Oct 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 12, 2023

s77rt commented Oct 12, 2023

akamefi202 commented Oct 12, 2023 • edited Loading

s77rt commented Oct 12, 2023

akamefi202 commented Oct 12, 2023

s77rt commented Oct 12, 2023

s77rt commented Oct 12, 2023

akamefi202 commented Oct 12, 2023

s77rt commented Oct 13, 2023

Reviewer Checklist

Screenshots/Videos

s77rt commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

akamefi202 commented Oct 12, 2023 •

edited

Loading

akamefi202 commented Oct 12, 2023 •

edited

Loading