[HOLD for payment 2024-01-11] [$500] Android - IOU-In a address, one word in Hindi and other text in English are shown.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.90-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Launch app
2. Tap fab---request money--Distance
3. Tap start
4. Enter Chandigarh railway
5. Select suggested address "Chandigarh Railway Station Ticket Counter, Gali Number 2, Daria, Chandigarh, India"
6. Tap Start

Expected Result:

The address in address field and suggested addresses with text in Hindi language must not be shown.The entire address must only be in English language. In a address, one word in Hindi and other text in English must not be shown

Actual Result:

The address in address field and suggested addresses showing address with text in Hindi language. In a address, one word in Hindi and other text in English are shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6249418_1698181669205.hindi.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ca2087437191a6c
• Upwork Job ID: 1716936389696782336
• Last Price Increase: 2023-11-14
• Automatic offers:
• 0xmiroslav | Reviewer | 27999208
• tienifr | Contributor | 27999210

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015ca2087437191a6c

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[JmillsExpensify]

Waiting for proposals

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - IOU-In a address, one word in Hindi and other text in English are shown.

What is the root cause of that problem?

We're using AddressSearch to show the list address

And when we select the address item, we store the address value from details.formatted_address

App/src/components/AddressSearch/index.js

Line 238 in 1c85ebe

address: lodashGet(details, 'formatted_address', ''),

But we're using address from autocompleteData to display in the address list

In this case, details.formatted_address contain the hindi character

What changes do you think we should make in order to solve the problem?

We should use autocompleteData.description to get the address here for more consistency

App/src/components/AddressSearch/index.js

Line 238 in 1c85ebe

address: lodashGet(details, 'formatted_address', ''),

and

App/src/components/AddressSearch/index.js

Line 170 in 1c85ebe

address: lodashGet(details, 'description', ''),

For example:

            address: autocompleteData.description || lodashGet(details, 'formatted_address', ''),

Result

Screen.Recording.2023-10-25.at.12.31.27.mov

[esh-g]

Will be changed here: #29931

[melvin-bot]

@JmillsExpensify, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JmillsExpensify]

@0xmiroslav thoughts on the proposal above?

[0xmiros]

Will be changed here: #29931

@esh-g I didn't get you. #29931 is merged but this is still reproducible

[esh-g]

@0xmiroslav I just added it as a a heads up that it may 'change' the behaviour here I didn't say it would get fixed...

[melvin-bot]

@JmillsExpensify @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JmillsExpensify]

Still waiting on proposals

[tienifr]

@JmillsExpensify @0xmiroslav I already post the proposal above. What do you think?

[melvin-bot]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

PR ready for review #32708.

[JmillsExpensify]

PR still in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Inconsistency between autocomplete address and displayed address #32708

If no regressions arise, payment will be issued on 2024-01-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @0xmiroslav requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @amyevans, @0xmiroslav, @tienifr Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify, @amyevans, @0xmiroslav, @tienifr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[0xmiros]

No regression. This is not bug but inconsistency & improvement.
As this was reported by QA team, I think we can skip regression test.

[JmillsExpensify]

Thanks for that @0xmiroslav. Adding a payment summary and issuing payments via Upwork:

• Issuer reporter: QA
• Contributor: @tienifr $500
• Contributor+: @0xmiroslav $500

[JmillsExpensify]

All contracts paid out. Closing!