Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Onyx entry for LAST_VISITED_PATH #31886

Closed
hayata-suenaga opened this issue Nov 26, 2023 · 16 comments
Closed

Add a new Onyx entry for LAST_VISITED_PATH #31886

hayata-suenaga opened this issue Nov 26, 2023 · 16 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Nov 26, 2023

We need to keep track of the last visited route/URL to make it possible to navigate back to the place in the app where the user was last active.

To implement this feature, we will store the last visited path/URL as a new entry in Onyx. Please follow this section of the design doc.

You can read the further details on it in this section of the design doc.

@hayata-suenaga hayata-suenaga added the NewFeature Something to build that is a new item. label Nov 26, 2023
@hayata-suenaga hayata-suenaga self-assigned this Nov 26, 2023
Copy link

melvin-bot bot commented Nov 26, 2023

@joekaufmanexpensify
Copy link
Contributor

Looks like this is an internal new feature, so going to unassign myself for now. If anything related to hiring/paying contributors comes up in the issue, feel free to reassign me, and happy to handle it!

@joekaufmanexpensify joekaufmanexpensify removed their assignment Nov 27, 2023
@hayata-suenaga hayata-suenaga changed the title Add a new Onyx entry for ACTIVE_WORKSPACE_ID [Draft] Add a new Onyx entry for ACTIVE_WORKSPACE_ID Nov 27, 2023
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 6, 2023
@hayata-suenaga hayata-suenaga changed the title [Draft] Add a new Onyx entry for ACTIVE_WORKSPACE_ID Add a new Onyx entry for ACTIVE_WORKSPACE_ID Dec 12, 2023
@mateuuszzzzz
Copy link
Contributor

Hi, I'll handle this issue 🚀

Copy link

melvin-bot bot commented Dec 13, 2023

📣 @mateuuszzzzz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@hayata-suenaga hayata-suenaga changed the title Add a new Onyx entry for ACTIVE_WORKSPACE_ID Add a new Onyx entry for LAST_VISITED_PATH Dec 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 15, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

@mateuuszzzzz, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Dec 20, 2023

@mateuuszzzzz what is the progress for this one? I remember that the last update was that you need to coordinate with Adam about how to go about implementing this requirement as it's more tied to the navigation logic after the requirement change. How the planning going?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 20, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@mateuuszzzzz, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 28, 2023

@mateuuszzzzz, @hayata-suenaga Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 1, 2024

@mateuuszzzzz, @hayata-suenaga 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Jan 2, 2024

@mateuuszzzzz, @hayata-suenaga 12 days overdue. Walking. Toward. The. Light...

Copy link

melvin-bot bot commented Jan 3, 2024

@mateuuszzzzz, @hayata-suenaga 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jan 8, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

This issue has not been updated in over 14 days. @mateuuszzzzz, @hayata-suenaga eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Jan 8, 2024
@hayata-suenaga
Copy link
Contributor Author

@mateuuszzzzz I'd appreciate if you could give an update on this one once you're back at the office

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2024
@hayata-suenaga
Copy link
Contributor Author

the work is on progress

@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@mountiny mountiny mentioned this issue Jan 19, 2024
50 tasks
@mountiny mountiny self-assigned this Jan 19, 2024
@mountiny
Copy link
Contributor

this is now kinda the main tracking issue

@mountiny
Copy link
Contributor

Actually i think this is better issue to track it #32941

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants