[$500] [HOLD for payment 2023-12-20] [HOLD for payment 2023-12-18] LHN - Applausecard account is crashing after clicking on any Request in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.10.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with tester@applausecard.expensifail.com
3. Click on any Request in LHN

Expected Result:

Applausecard account is not crashing after clicking on any Request in LHN

Actual Result:

Applausecard account is crashing after clicking on any Request in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5661.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0163fa2ca7f62b144d
• Upwork Job ID: 1738223765809868800
• Last Price Increase: 2023-12-22

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Not reproduced on production

Recording.5662.mp4

[situchan]

@kbecciv can you please share console error?

[kbecciv]

@situchan Please attached!

[ZhenjaHorbach]

9b3ed5e#diff-7472918ae174ded3ed9ce8b5fa05c744d77074207fb84f1fce28d1bfd2ba1e56

Looks like a regression from this PR
#32498

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Crash when opening a money request with EReceipt.

What is the root cause of that problem?

This is a regression from #32498. Here, we use a useMemo to get the bg image, but useMemo function takes no argument/param, so trans is always undefined.

App/src/components/EReceiptThumbnail.js

Line 75 in 21f5875

const getBackgroundImage = useMemo((trans) => backgroundImages[StyleUtils.getEReceiptColorCode(trans)], [StyleUtils]);

App/src/components/EReceiptThumbnail.js

Line 89 in 21f5875

source={getBackgroundImage(transaction)}

It should be a useCallback if we want to pass an argument.

What changes do you think we should make in order to solve the problem?

Replace with useCallback

OR

Keep the useMemo and change it like this:

-const getBackgroundImage = useMemo((trans) => backgroundImages[StyleUtils.getEReceiptColorCode(trans)], [StyleUtils]);
+const backgroundImage = useMemo(() => backgroundImages[StyleUtils.getEReceiptColorCode(transaction)], [StyleUtils, transaction]);

<Image
-   source={getBackgroundImage(transaction)}
+   source={backgroundImage}

[situchan]

@grgia can you please add this fix to PR as well?

[grgia]

On it @situchan

[yuwenmemon]

CP'ed! Removing blocker.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR — @situchan paid $500 in Upwork as the reviewer

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[grgia]

@CortneyOfstad could you help ensure that the $500 C+ review payment is made to @situchan for #32721

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0163fa2ca7f62b144d

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[CortneyOfstad]

@situchan I just sent you a proposal in Upwork — please let me know as soon as you accept and I'll get that paid ASAP. Thanks!

[CortneyOfstad]

Paid! Thank you!