[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

grgia · 2023-12-08T14:39:49Z

Details

This PR fixes the MenuItem button colors. Now the button is unchanged and the active menuItem is product500. (approved by design in slack convo linked in issue)

It also reverts the skeleton UI colors to the old color (minor regression)

Finally it fixes a crash due to a useMemo with missing param

Fixed Issues

$ #32688
$ #32719
$ #32727

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console
Click FAB -> Chat -> visually verify that the colors of the selection list match screenshots in the description
Click FAB -> Money Request -> Manual -> Enter amount -> visually verify that the colors of the selection list match screenshots in the description
Load a large chat, verify skeleton UI colors animate.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…product500

melvin-bot · 2023-12-08T15:52:59Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2023-12-08T15:53:42Z

src/components/OptionRow.js

@@ -196,7 +196,7 @@ function OptionRow(props) {
                        accessibilityLabel={props.option.text}
                        role={CONST.ACCESSIBILITY_ROLE.BUTTON}
                        hoverDimmingValue={1}
-                        hoverStyle={props.hoverStyle || styles.sidebarLinkHover}
+                        hoverStyle={!props.optionIsFocused ? props.hoverStyle || styles.sidebarLinkHover : undefined}


this change favors the active color over hover (same pattern as LHN)

c3024 · 2023-12-08T15:57:00Z

Does this require a C+ review?

grgia · 2023-12-08T16:06:47Z

@c3024 yes

grgia · 2023-12-08T16:10:05Z

@c3024 this PR fixes multiple deploy blockers so if you're able, please prioritize this one

c3024 · 2023-12-08T16:11:40Z

I see @situchan suggested fixes in the issues. Do you like to review this? @situchan

situchan · 2023-12-08T16:12:05Z

sure thanks @c3024

grgia · 2023-12-08T16:14:11Z

@situchan thank you! assigned 🙏

situchan · 2023-12-08T16:26:52Z

"Add to group" button background color is different from production. Also no hover color

Screen.Recording.2023-12-08.at.10.22.54.PM.mov

And item background hover color change is intentional?
this branch: rgb(34, 79, 65);
production: rgb(26, 61, 50);

grgia · 2023-12-08T16:43:35Z

@situchan yes, we discussed internally with design and changed the colors / removed the button hover color changes. Screenshots have been approved!

situchan · 2023-12-08T16:47:44Z

@situchan yes, we discussed internally with design and changed the colors / removed the button hover color changes. Screenshots have been approved!

ok so all above concerns are expected?

situchan · 2023-12-08T16:59:39Z

dark mode tests well for all 3 issues.
@grgia can you share shortcut to test light mode?

grgia · 2023-12-08T17:02:42Z

@situchan

Onyx.merge('preferredTheme', 'light');

situchan · 2023-12-08T17:19:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

ios-light.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web-dark.mov

web-light.mov

MacOS: Desktop

desktop.mov

situchan

melvin-bot · 2023-12-08T17:20:30Z

@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga

👍

OSBotify · 2023-12-08T19:40:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI (cherry picked from commit d4fb27a)

OSBotify · 2023-12-08T22:27:40Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-08T22:47:00Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-11T10:41:51Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T15:23:46Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

grgia added 3 commits December 8, 2023 09:37

fix split button highlight color

aa30d35

prettier

7d62412

do not change button color, modify appBG menuItem hover color to use …

87fd4de

…product500

grgia self-assigned this Dec 8, 2023

grgia changed the title ~~Fix Split Button Highlight Color~~ Fix Split/Add to Group Button Highlight Color Dec 8, 2023

grgia changed the title ~~Fix Split/Add to Group Button Highlight Color~~ Fix Split/Add to Group Button Highlight Color and Skeleton UI Dec 8, 2023

grgia mentioned this pull request Dec 8, 2023

[HOLD for payment 2023-12-20] [HOLD for payment 2023-12-18] Chat - Skeleton has no animation in the LHN and in the report at the time the user logs in #32719

Closed

6 tasks

revert skeleton UI color

d94c1e3

grgia marked this pull request as ready for review December 8, 2023 15:52

grgia requested a review from a team as a code owner December 8, 2023 15:52

melvin-bot bot requested review from c3024 and removed request for a team December 8, 2023 15:52

grgia commented Dec 8, 2023

View reviewed changes

situchan mentioned this pull request Dec 8, 2023

[$500] [HOLD for payment 2023-12-20] [HOLD for payment 2023-12-18] LHN - Applausecard account is crashing after clicking on any Request in LHN #32727

Closed

6 tasks

fix eReceipt image crash

8472d23

grgia requested review from situchan and removed request for c3024 December 8, 2023 16:14

situchan approved these changes Dec 8, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga December 8, 2023 17:20

grgia changed the title ~~Fix Split/Add to Group Button Highlight Color and Skeleton UI~~ [Deploy Blocker Fix] \Fix Split/Add to Group Button Highlight Color and Skeleton UI Dec 8, 2023

grgia changed the title ~~[Deploy Blocker Fix] \Fix Split/Add to Group Button Highlight Color and Skeleton UI~~ [Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI Dec 8, 2023

hayata-suenaga approved these changes Dec 8, 2023

View reviewed changes

hayata-suenaga merged commit d4fb27a into main Dec 8, 2023
21 checks passed

hayata-suenaga deleted the georgia-splitButtonHoverThemes branch December 8, 2023 19:37

OSBotify pushed a commit that referenced this pull request Dec 8, 2023

Merge pull request #32721 from Expensify/georgia-splitButtonHoverThemes

c2a409a

[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI (cherry picked from commit d4fb27a)

github-actions bot mentioned this pull request Dec 8, 2023

Deploy Checklist: New Expensify 2023-12-08 #32704

Closed

27 tasks

melvin-bot bot mentioned this pull request Dec 11, 2023

[HOLD for payment 2023-12-20] [HOLD for payment 2023-12-18] [Theme Switching] Fix Split Button Highlight Color #32688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

grgia commented Dec 8, 2023 •

edited

Loading

melvin-bot bot commented Dec 8, 2023

grgia Dec 8, 2023

c3024 commented Dec 8, 2023

grgia commented Dec 8, 2023

grgia commented Dec 8, 2023

c3024 commented Dec 8, 2023

situchan commented Dec 8, 2023

grgia commented Dec 8, 2023

situchan commented Dec 8, 2023 •

edited

Loading

grgia commented Dec 8, 2023

situchan commented Dec 8, 2023

situchan commented Dec 8, 2023

grgia commented Dec 8, 2023

situchan commented Dec 8, 2023

situchan left a comment

melvin-bot bot commented Dec 8, 2023

hayata-suenaga left a comment

OSBotify commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 11, 2023

OSBotify commented Dec 11, 2023

[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

[Deploy Blocker Fix] Fix Split/Add to Group Button Highlight Color and Skeleton UI #32721

Conversation

grgia commented Dec 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 8, 2023

grgia Dec 8, 2023

Choose a reason for hiding this comment

c3024 commented Dec 8, 2023

grgia commented Dec 8, 2023

grgia commented Dec 8, 2023

c3024 commented Dec 8, 2023

situchan commented Dec 8, 2023

grgia commented Dec 8, 2023

situchan commented Dec 8, 2023 • edited Loading

grgia commented Dec 8, 2023

situchan commented Dec 8, 2023

situchan commented Dec 8, 2023

grgia commented Dec 8, 2023

situchan commented Dec 8, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 8, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 11, 2023

OSBotify commented Dec 11, 2023

grgia commented Dec 8, 2023 •

edited

Loading

situchan commented Dec 8, 2023 •

edited

Loading