[HOLD for payment 2024-03-07] [$500] Android - Home - Time and other elements in phone header is not visible in light mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.18-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-condition open app in light mode

1. Launch app
2. Note header elements like phone time etc.,

Expected Result:

Time and other elements in phone header must be visible in light mode

Actual Result:

Time and other elements in phone header is not visible in light mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d884bdaeefe025ea
• Upwork Job ID: 1740123637523148800
• Last Price Increase: 2024-01-03
• Automatic offers:
• jjcoffee | Reviewer | 28080054
• tienifr | Contributor | 28080055

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d884bdaeefe025ea

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android status bar is not visible in light mode.

What is the root cause of that problem?

we are setting an incorrect status bar style here:

App/src/styles/theme/themes/light.ts

Line 139 in 93db6db

statusBarStyle: CONST.STATUS_BAR_STYLE.DARK_CONTENT,

What changes do you think we should make in order to solve the problem?

we should change it to:

    statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,

Result:

before:

after:

What alternative solutions did you explore? (Optional)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Time and other elements in phone header is not visible in light mode

What is the root cause of that problem?

In here, we set the initial state of the status bar. But the status bar color isn't updated via updateStatusBarAppearance yet, that initial state causes the status bar not to change color due to this logic because we think that the color was already updated, but it was not, only the state was initialized.

What changes do you think we should make in order to solve the problem?

We can simply initiate the status bar state to undefined here instead of initialize it with the theme current status bar.

const [statusBarStyle, setStatusBarStyle] = useState();

This will make sure initially when no status bar style is set, this will be evaluated to false and the status bar style will be set correctly.

Or in an useEffect, set the initial colors (same as initial value of statusBarStyle state) of the status bar by updateStatusBarAppearance, to make sure when we say, in the state, initial color of statusBar is something, it is correctly initialized like that.

What alternative solutions did you explore? (Optional)

Set barStyle prop for the StatusBar based on the status bar style in the initial state.

[bfitzexpensify]

Couple of proposals ready for review @jjcoffee - thank you!

[melvin-bot]

@jjcoffee, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jjcoffee]

@rayane-djouah seems to have the incorrect root cause as dark-content is the correct style to have here (per the docs this results in Light background, dark texts and icons).

@tienifr's proposal makes the most sense to me. I'm unsure if there would be any negative effects of initialising the status bar state to undefined, but we can test and deal with that on the PR.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[situchan]

Dupe of #33309
cc: @grgia @chrispader

[grgia]

@madmax330 mind if I take this one?

[grgia]

@tienifr does your proposal fix it for both light mode and dark (#33309)

[tienifr]

@tienifr does your proposal fix it for both light mode and dark (#33309)

@grgia yup it will fix for both, I can raise a PR asap once assigned

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jjcoffee]

Apologies this one fell off my radar somehow, it's back on my list!

[jjcoffee]

Reviewing now!

[jjcoffee]

PR reviewed, @tienifr just needs to work on a tweak.

[bfitzexpensify]

How's this one going @tienifr?

[tienifr]

I'm having problems with perf test and investigating that.

[bfitzexpensify]

Bump on this one @tienifr - how are the performance tests going?

[tienifr]

PR was merged ytd.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Status bar style not update #34637

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Switching to Daily so that I action this when payment is due tomorrow

[bfitzexpensify]

Payments all done - please complete the BZ checklist when you get a moment @jjcoffee - thank you!

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: [CP Staging] Fix issues with scrollbar and status bar color #32672
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [CP Staging] Fix issues with scrollbar and status bar color #32672 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Set app in light mode
2. Reopen app
3. Verify that the status bar renders correctly with the appropriate text colour for the theme
4. Sign out and verify 3
5. Sign in and verify 3
6. Repeat all steps with dark mode
7. Change theme from another device
8. Verify theme and status bar are updated accordingly

Do we agree 👍 or 👎

[bfitzexpensify]

Looks good to me - proposed via https://github.com/Expensify/Expensify/issues/376686. Let's close this out - thanks everyone!