Fix: Status bar style not update #34637

tienifr · 2024-01-17T09:49:11Z

Details

This PR fixes the issue of status bar not get updated.

Fixed Issues

$ #33674
PROPOSAL: #33674 (comment)

Tests

Set app in light mode
Reopen app
Verify the status bar is visible
Sign out
Verify 3
Sign in
Verify 3
Repeat all steps with dark mode
======
Change theme from another device
Verify theme and status bar are updated accordingly

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Set app in light mode
Reopen app
Verify the status bar is visible
Repeat step 1-3 with dark mode

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-17.at.17.01.40-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-01-17.at.17.12.22-compressed.mov

iOS: Native

Screen.Recording.2024-01-17.at.16.56.25-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-01-17.at.16.51.44-compressed.mov

melvin-bot · 2024-01-17T10:16:00Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/CustomStatusBarAndBackground/index.tsx

jjcoffee · 2024-01-25T13:58:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-01-25_15.27.12.mp4

Android: mWeb Chrome

android-chrome-2024-01-25_15.33.04.mp4

iOS: Native

ios-native-2024-01-25_15.08.14.mp4

iOS: mWeb Safari

ios-safari-2024-01-25_15.14.15.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-01-25_15.35.46.mp4

MacOS: Desktop

desktop-app-2024-01-25_15.38.51.mp4

jjcoffee · 2024-01-25T14:47:23Z

Testing pretty well!

One thing I'm getting on Android native is that the status bar text changes colour on the login screen (after entering the magic code), before the home screen loads. This causes the status bar to temporarily "disappear". Any way to handle that?

out.mp4

jjcoffee · 2024-01-29T09:28:22Z

@tienifr Friendly bump on the above 🙇

tienifr · 2024-01-29T09:49:59Z

I think that's because Android dev build is slow, the route and theme already change but component is not rendered yet. We do not have this issue on iOS. I think we won't have it in Android production build. I also tested and found no solution for that.

jjcoffee · 2024-01-29T12:44:42Z

@tienifr Gotcha! It's still a big improvement anyway so I think we're good.

jjcoffee

LGTM!

parasharrajat · 2024-01-29T15:54:00Z

Looks like a couple of changes will overlap with #34409 but we should be good to move forward here.

grgia · 2024-01-29T18:26:02Z

src/components/CustomStatusBarAndBackground/index.tsx

+        updateStatusBarStyle();
+
+        // Add navigation state listeners to update the status bar every time the route changes
+        // We have to pass a count as the listener id, because "react-navigation" somehow doesn't remove listeners properly
        const listenerId = ++listenerCount.current;


as part of this PR, would you mind updating the capitalization to listenerID

grgia

LGTM, minor variable name comment unrelated to your code if you're up for it

grgia

LGTM, thanks!

grgia · 2024-01-29T19:03:04Z

@tienifr you may need to merge main for the performance tests

tienifr · 2024-02-01T07:48:49Z

The perf-test is failing due to changes in this PR. I'm investigating that.

grgia · 2024-02-14T17:45:20Z

@tienifr any updates on the performance tests

grgia · 2024-02-21T18:38:48Z

@tienifr would you mind posting a quick update on this PR?

tienifr · 2024-02-24T16:45:12Z

Perf-test failure is resolved. The TS check is already on main and not related to this PR. We're good to go @grgia.

tienifr · 2024-02-26T11:05:46Z

@grgia TS failure is fixed. We're good to go.

tienifr · 2024-02-27T12:54:29Z

Merged main and retested today, every works as expected:

Screen.Recording.2024-02-27.at.19.52.29-compressed.mov

Screen.Recording.2024-02-27.at.19.51.20-compressed.mov

OSBotify · 2024-02-28T13:19:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:06:31Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-29T23:30:59Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 3 commits January 17, 2024 16:44

fix: status bar style not update

1e8778c

use usePrevious

84b4eb4

fix lint

acfc823

tienifr marked this pull request as ready for review January 17, 2024 10:15

tienifr requested a review from a team as a code owner January 17, 2024 10:15

melvin-bot bot removed the request for review from a team January 17, 2024 10:15

melvin-bot bot requested a review from jjcoffee January 17, 2024 10:16

tienifr mentioned this pull request Jan 17, 2024

[HOLD for payment 2024-03-07] [$500] Android - Home - Time and other elements in phone header is not visible in light mode #33674

Closed

6 tasks

tienifr commented Jan 17, 2024

View reviewed changes

src/components/CustomStatusBarAndBackground/index.tsx Show resolved Hide resolved

tienifr commented Jan 17, 2024

View reviewed changes

src/components/CustomStatusBarAndBackground/index.tsx Outdated Show resolved Hide resolved

jjcoffee approved these changes Jan 29, 2024

View reviewed changes

melvin-bot bot requested a review from grgia January 29, 2024 12:45

ishpaul777 mentioned this pull request Jan 29, 2024

Fix/status bar color on mweb #34409

Merged

50 tasks

grgia reviewed Jan 29, 2024

View reviewed changes

grgia previously approved these changes Jan 29, 2024

View reviewed changes

tienifr added 2 commits January 30, 2024 01:30

Merge branch 'main' of https://github.com/tienifr/App into fix/33674

f19b9fa

fix variable cap

5682437

tienifr dismissed grgia’s stale review via 5682437 January 29, 2024 18:31

grgia previously approved these changes Jan 29, 2024

View reviewed changes

tienifr added 3 commits January 30, 2024 02:05

Merge branch 'main' of https://github.com/tienifr/App into fix/33674

dc54b60

Merge branch 'main' of https://github.com/tienifr/App into fix/33674

1a6c066

Merge branch 'main' of https://github.com/tienifr/App into fix/33674

d2706ae

add missing mock functions for navigationRef

eb50d45

tienifr dismissed grgia’s stale review via eb50d45 January 30, 2024 13:00

Merge branch 'main' into fix/33674

787c374

Merge branch 'main' of https://github.com/tienifr/App into fix/33674

1d7da4f

Merge branch 'main' of https://github.com/tienifr/App into fix/33674

eb6b6b6

Merge branch 'main' into fix/33674

90b4576

ishpaul777 mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-02-19] [$500] [Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent #35632

Closed

6 tasks

grgia approved these changes Feb 28, 2024

View reviewed changes

grgia merged commit b6b1c05 into Expensify:main Feb 28, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

tienifr mentioned this pull request Mar 18, 2024

Fix: Status bar color is not correct on deeplink #38460

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Status bar style not update #34637

Fix: Status bar style not update #34637

tienifr commented Jan 17, 2024 •

edited

Loading

melvin-bot bot commented Jan 17, 2024

jjcoffee commented Jan 25, 2024 •

edited

Loading

jjcoffee commented Jan 25, 2024 •

edited

Loading

jjcoffee commented Jan 29, 2024

tienifr commented Jan 29, 2024 •

edited

Loading

jjcoffee commented Jan 29, 2024

jjcoffee left a comment

parasharrajat commented Jan 29, 2024 •

edited

Loading

grgia Jan 29, 2024

tienifr Jan 29, 2024

grgia left a comment

grgia left a comment

grgia commented Jan 29, 2024

tienifr commented Feb 1, 2024

grgia commented Feb 14, 2024 •

edited

Loading

grgia commented Feb 21, 2024

tienifr commented Feb 24, 2024 •

edited

Loading

tienifr commented Feb 26, 2024

tienifr commented Feb 27, 2024

OSBotify commented Feb 28, 2024

OSBotify commented Feb 29, 2024

OSBotify commented Feb 29, 2024

Fix: Status bar style not update #34637

Fix: Status bar style not update #34637

Conversation

tienifr commented Jan 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 17, 2024

jjcoffee commented Jan 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Jan 25, 2024 • edited Loading

jjcoffee commented Jan 29, 2024

tienifr commented Jan 29, 2024 • edited Loading

jjcoffee commented Jan 29, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

parasharrajat commented Jan 29, 2024 • edited Loading

grgia Jan 29, 2024

Choose a reason for hiding this comment

tienifr Jan 29, 2024

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

grgia commented Jan 29, 2024

tienifr commented Feb 1, 2024

grgia commented Feb 14, 2024 • edited Loading

grgia commented Feb 21, 2024

tienifr commented Feb 24, 2024 • edited Loading

tienifr commented Feb 26, 2024

tienifr commented Feb 27, 2024

OSBotify commented Feb 28, 2024

OSBotify commented Feb 29, 2024

OSBotify commented Feb 29, 2024

tienifr commented Jan 17, 2024 •

edited

Loading

jjcoffee commented Jan 25, 2024 •

edited

Loading

jjcoffee commented Jan 25, 2024 •

edited

Loading

tienifr commented Jan 29, 2024 •

edited

Loading

parasharrajat commented Jan 29, 2024 •

edited

Loading

grgia commented Feb 14, 2024 •

edited

Loading

tienifr commented Feb 24, 2024 •

edited

Loading