[$500] [Wave 6: Tags] Allow for multiple levels of tags on workspace requests

[yuwenmemon]

Part of the Wave 6: Tags project

Main issue: #32828
Doc section: N/A (Orignal tags doc is here: https://docs.google.com/document/d/1eXGKhdUP98f6RUVYpRzxLi49El9Rizeqq-EYjrF24tU/edit)
Project: https://github.com/orgs/Expensify/projects/73

Feature Description

We already support multiple levels of tags on policies in Expensify and within our workspaces. Our current code assumes you have a single tag list. We need to update it to juggle the potential for multiple tags. Thankfully, from there, the rest of the framework is already in place. We will do this by:

• Updating MoneyRequestConfirmationList to retrieve all tags in the policy instead of just the first here. Then, when rendering the MenuItem for tag, iteratively render a single MenuItem for each tag here. The same applies to MoneyTemporaryForRefactorRequestConfirmationList.
• Do the same thing in MoneyRequestView.
• Adjusting the routes for tags to incorporate the tag index (discussion). This means adjusting the current routes for editing/selecting tags in the following way:
  • ${iouType}/new/tag/${reportID} -> ${iouType}/new/tag/0/${reportID}
  • create/${iouType}/tag/${transactionID}/${reportID}/ -> create/${iouType}/tag/0/${transactionID}/${reportID}/
  • r/:threadReportID/edit/:field -> r/:threadReportID/edit/:field/0
• Then for the tag we send to the API, we create a string of all tags, by order of index, delimited by colons, like so tag1:tag2:tag3. The Expensify API already understands this format.
• For displaying the tag, for instance when we have the tag key from getTransactionDetails, we should split the tag by the colon delimiter and display each in it's corresponding index.
• We'll need to create a method that translates a tag index to a tag name. This would correspond to the order a tag appears in the policyTags_ OnyxKey:
  
• For any "Modified Expense" message, anytime we change a single tag level, we'll just display the entire colon-delimited tag, like we do on OldDot:
  • 

Manual Test Steps

1. In OldDot, create a policy with multiple tags. One can do this by following the instructions here, and using the following csv with multiple tag levels:
   independentTags.csv
2. Create a new workspace request
3. Make sure you see a row rendered for each tag in the workspace
4. Make sure that selection works for each row, and that the appropriate list of tags show for the appropriate level.
5. Save the request, make sure that the tags save properly on the expense
6. Open the recently saved request, make sure that the saved tag selections show up in the correct rows.
7. Edit the request, again make sure that the selections work the same as when you created the expense, and save properly.

cc @amyevans @rezkiy37 @waterim @puneetlath

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131596ecedabdad1c
• Upwork Job ID: 1744420931750514688
• Last Price Increase: 2024-01-08

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f8d7e73e93a9b90b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[yuwenmemon]

Thanks @rezkiy37! Let me know if you have any questions and if there's any updates you'd like to see on the back-end that we overlooked.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131596ecedabdad1c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @allroundexperts, @rezkiy37 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@allroundexperts, @rezkiy37, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[allroundexperts]

I reviewed #34983 and am eligible for payment I think. Can someone please check?

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[yuwenmemon]

@Christinadobrzyn Can we pay @allroundexperts for his review?

[Christinadobrzyn]

Yes! Payouts due:

• Contributor+: $500 @allroundexperts (Payment through NewDot)

[yuwenmemon]

Thank you!!

[allroundexperts]

Hi @Christinadobrzyn!
I get paid through ND. Can you please write a payment summary instead? Thanks!

[Christinadobrzyn]

hi! @allroundexperts Thanks for letting me know! The payment summary has been updated to be paid through NewDot. Let me know if you need anything else.

[Christinadobrzyn]

I think we can close this? @allroundexperts does that sound good?

[allroundexperts]

Yep. Good to close!

[JmillsExpensify]

$500 approved for @allroundexperts