Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [MEDIUM] Tags: Selected parent tag with sub-tag is displayed incorrectly #36916

Closed
6 tasks done
lanitochka17 opened this issue Feb 20, 2024 · 29 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4327832
Email or phone of affected tester (no customers): sustinov@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Preconditions:
In OldDot under admin, create a Collect group policy, enable tags and add the tag "Child: Tom", add the employee to the policy. Setup OldDot Collect Policy:
https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0

  1. Open https://staging.new.expensify.com/
  2. Log in to the employee's account
  3. Tap on the green plus button (FAB)
  4. Select Request money
  5. Select any currency and amount
  6. Click next
  7. Choose a group policy room
  8. Click on "Show more"
  9. In the tag section, select "Child: Tom"

Expected Result:

The selected sub-tag of the parent tag must be displayed correctly

Actual Result:

Selected parent tag with sub-tag is displayed incorrectly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385738_1708436744716.Recording__1360.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a4732f27aa3c183f
  • Upwork Job ID: 1759969701776297984
  • Last Price Increase: 2024-02-20
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 20, 2024
@melvin-bot melvin-bot bot changed the title Tag - Selected parent tag with sub-tag is displayed incorrectly [$500] Tag - Selected parent tag with sub-tag is displayed incorrectly Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01a4732f27aa3c183f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 20, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave6
CC @greg-schroeder

@yuwenmemon
Copy link
Contributor

I can look into this

@yuwenmemon yuwenmemon assigned yuwenmemon and unassigned AndrewGable Feb 20, 2024
@yuwenmemon
Copy link
Contributor

Also cc @rezkiy37

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Feb 21, 2024
@yuwenmemon yuwenmemon removed the External Added to denote the issue can be worked on by a contributor label Feb 21, 2024
@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@greg-schroeder greg-schroeder changed the title [$500] Tag - Selected parent tag with sub-tag is displayed incorrectly [$500] [MEDIUM] Tags: Selected parent tag with sub-tag is displayed incorrectly Feb 27, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@kbecciv
Copy link

kbecciv commented Mar 6, 2024

Issue is not reproducible

Recording.1407.mp4

@Ollyws
Copy link
Contributor

Ollyws commented Mar 6, 2024

@AndrewGable I reviewed this in #36978, could we reopen for payment? Thanks.

@AndrewGable AndrewGable reopened this Mar 6, 2024
@AndrewGable AndrewGable added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 6, 2024
@AndrewGable
Copy link
Contributor

@Ollyws - Oops yes, @muttmuure can you pay @Ollyws for the review? It's been 7+ days with no regression.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week) Good to close?

@yuwenmemon
Copy link
Contributor

Yep!

@Ollyws
Copy link
Contributor

Ollyws commented Mar 20, 2024

@yuwenmemon Still haven't been paid for this one, can we re-open it?

@yuwenmemon
Copy link
Contributor

Oh sure! @muttmuure can you please resolve this?

@yuwenmemon yuwenmemon reopened this Mar 20, 2024
@muttmuure
Copy link
Contributor

Sorry was out of office - doing this now

@muttmuure
Copy link
Contributor

Balls, the message references the wrong issue number. Anyway, I've sent an offer @Ollyws!

@Ollyws
Copy link
Contributor

Ollyws commented Mar 21, 2024

Strange, I'm not seeing any offer @muttmuure

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fourth week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fifth week)

@Ollyws
Copy link
Contributor

Ollyws commented Apr 4, 2024

Bump @muttmuure

@muttmuure
Copy link
Contributor

Looking

@muttmuure
Copy link
Contributor

Did you get the one I just sent?

@Ollyws
Copy link
Contributor

Ollyws commented Apr 4, 2024

Yeah, accepted thanks!

@Ollyws
Copy link
Contributor

Ollyws commented Apr 9, 2024

Friendly bump @muttmuure

@muttmuure
Copy link
Contributor

Paid, sorry - little snowed under

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
No open projects
Development

No branches or pull requests

8 participants