Attachment Picker Issues

[kidroca]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This is a list of existing issues I've stumbled on while working on #2531. I've added threads with details for each item

• Low: This block of code can be moved so that all error handling happens on one place. https://github.com/Expensify/Expensify.cash/pull/2731/files#r646583159
• Med: The fix for "document attachment label" fixes the bugs for document attachment and introduces a new bug for image/video attachments: https://github.com/Expensify/Expensify.cash/pull/2919/files#r646696781
• Med: Missing localization data prevents an alert message to appear: https://github.com/Expensify/Expensify.cash/pull/2718/files#r646793647
• Low: showDocumentPicker is setup in a way that can produce an error regarding this usage: https://github.com/Expensify/Expensify.cash/pull/2718/files#r646741428
• Low: Error message does not need to be translated, it's only printed on the console: https://github.com/Expensify/Expensify.cash/pull/2718/files#r647273525
• Low: Two messages that say the same thing in languages: https://github.com/Expensify/Expensify.cash/pull/2718/files#r647276547

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.63-3
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kidroca]

Added 2 new items

[kidroca]

Closing this as all but one issue were resolved