#3402 fix image picker preview on native #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
thienlnam
approved these changes
Jun 7, 2021
|
Added reference to #3385 in the original post. |
9 tasks
|
🚀 Deployed to staging in version: 1.0.64-2🚀
|
|
🚀 Deployed to production in version: 1.0.65-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thienlnam
Details
Addresses the 3rd point made on issue #3402 (The fix for "document attachment label" fixes the bugs for document attachment and introduces a new bug for image/video attachments).
Fixed Issues
Fixes part of #3402
Fixes #3385
Tests / QA Steps
Android/iOS:
chat_attachmentlabel.Tested On
Only needs to be tested on native since only one .native.js file was changed.
Screenshots
Web
Mobile Web
Desktop
iOS
Android