[Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

[tgolen]

Held on #34613

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: NewDistanceRequestPage
New Component IOURequestStepDistance

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

1. Look at the history of the Old Component
2. If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
3. Replace all uses of the Old Component with the New Component
4. Remove all traces of Old Component
5. Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
6. Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f10eeacf3fc8d218
• Upwork Job ID: 1747632624829898752
• Last Price Increase: 2024-01-17
• Automatic offers:
• cubuspl42 | Reviewer | 28115391
• DylanDylann | Contributor | 28115392

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[KrAbhas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

What is the root cause of that problem?

Refactoring
 of navigation among screens for NewDistanceRequestPage

What changes do you think we should make in order

We will be deleting the component here:

App/src/pages/iou/NewDistanceRequestPage.js

Line 47 in a7a3e7f

function NewDistanceRequestPage({iou, report, route}) {

We will remove the screen from ModalStackNavigators.tsx

[njmulsqb]

I would love to take this!

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

What is the root cause of that problem?

Remove deprecated component

What changes do you think we should make in order to solve the problem?

1. Currently, we only use NewDistanceRequestPage in the MoneyRequestSelectorPage but MoneyRequestSelectorPage also be removed in this issue. So that we can remove NewDistanceRequestPage component and all traces like

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 107 in 278d04e

[SCREENS.MONEY_REQUEST.DISTANCE]: () => require('../../../pages/iou/NewDistanceRequestPage').default as React.ComponentType,

App/src/libs/Navigation/linkingConfig.ts

Line 437 in 278d04e

[SCREENS.MONEY_REQUEST.DISTANCE]: ROUTES.MONEY_REQUEST_DISTANCE.route,

App/src/ROUTES.ts

Lines 293 to 296 in a2f5bd5

	MONEY_REQUEST_DISTANCE: {
	route: ':iouType/new/address/:reportID?',
	getRoute: (iouType: string, reportID = '') => `${iouType}/new/address/${reportID}` as const,
	},

App/src/SCREENS.ts

Line 150 in a2f5bd5

DISTANCE: 'Money_Request_Distance',

App/src/libs/Navigation/types.ts

Lines 245 to 248 in a2f5bd5

	[SCREENS.MONEY_REQUEST.DISTANCE]: {
	iouType: ValueOf<typeof CONST.IOU.TYPE>;
	reportID: string;
	};

2. For new component IOURequestStepDistance.

In here

App/src/ROUTES.ts

Lines 347 to 351 in a2f5bd5

	MONEY_REQUEST_STEP_DISTANCE: {
	route: 'create/:iouType/distance/:transactionID/:reportID',
	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`create/${iouType}/distance/${transactionID}/${reportID}`, backTo),
	},

We need to use the new :action param (instead of being hard-coded with "create") like we did here

App/src/ROUTES.ts

Lines 362 to 366 in a2f5bd5

	MONEY_REQUEST_STEP_SCAN: {
	route: ':action/:iouType/scan/:transactionID/:reportID',
	getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`${action}/${iouType}/scan/${transactionID}/${reportID}`, backTo),
	},

3. Copy changes since 27 Nov to new components based on list commit here: https://github.com/Expensify/App/commits/main/src/pages/iou/NewDistanceRequestPage.js

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f10eeacf3fc8d218

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[MahmudjonToraqulov]

I would love to take this!

[s-alves10]

I would love to take this!

[melvin-bot]

Upwork job price has been updated to $250

[cubuspl42]

I approve the proposal by @DylanDylann

• As this is not TypeScript migration, we should still do proposals as per the guidelines
• The proposals shows some research related to the refactoring

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[cristipaval]

Thanks @cubuspl42!

[cubuspl42]

Anyway, we indeed need to re-open this.

We're working on two of the regressions:

• Fix/38814: Distance - Unable to save second distance edit offline #38987
  • The ball is on my side, I'll try to wrap this up today
• Add backup transaction again #39144
  • @DylanDylann is working on this

[cristipaval]

I think it was automatically closed because it was linked in that PR

[DylanDylann]

@cristipaval Please also help to remove the hold label on the title. Thanks

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mallenexpensify]

@eVoloshchak reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks
@DylanDylann can you please post an update on where we're at and what @eVoloshchak needs to help with?

[DylanDylann]

@mallenexpensify Everything is done here, waiting for payment

[mallenexpensify]

Thanks @DylanDylann , removed Reviewing, added Awaiting Payment and updated the title to reflect payment date.

[mallenexpensify]

Contributor: @DylanDylann paid $250 via Upwork
Contributor+: @cubuspl42 paid $250 via Upwork

Doesn't look like this needs a regression test created, comment if anyone disagrees.