Remove old receipt selector

[tgolen]

Details

The old receipt selector is no longer in use since the flows have been refactored. This PR removes the old files and incorporates the current receipt selector in the pages still referencing the old one.

Fixed Issues

This is part of #29107

Tests

1. Create a manual money request (need to test this by requesting money from workspaces, existing users, and brand new users)
2. On the confirmation page, click the three dot menu and add a receipt
3. Verify it creates successfully
4. Create a scan money request
5. Verify it creates successfully
6. Create a manual money request without any receipt image
7. Click on the view for this request and click the image placeholder to add a receipt
8. Verify the receipt is properly added
9. Click on the receipt to go to the attachment view
10. Click on the three dot menu and select replace
11. Replace the receipt with another image and verify it is properly updated

• Verify that no errors appear in the JS console

Offline tests

Same as the above

QA Steps

Same as the above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Unable to test due to broken emulator

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@johnmlee101 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[johnmlee101]

Testing, but also cc @ntdiary if you want to do the checklist for this PR since I see you're assigned on the parent issue

[johnmlee101]

For step 10 I get this menu option

[tgolen]

@johnmlee101 what's the URL of that page (and also the URL right before you get that)? I'll test that flow out again on my end.

[johnmlee101]

The IOU page
https://dev.new.expensify.com:8082/r/3641021911374988

Opening the image
https://dev.new.expensify.com:8082/r/3641021911374988/attachment?source=https://www.expensify.com.dev/receipts/w_27ab9f28e2cc5041abf79d25a3c25aa6002e60e9.png

Clicking Replace Image
https://dev.new.expensify.com:8082/r/3641021911374988/edit/receipt

[ntdiary]

Testing, but also cc @ntdiary if you want to do the checklist for this PR since I see you're assigned on the parent issue

@johnmlee101, please feel free to take over it, I'm still busy with other issues. 😂

[situchan]

If this requires C+ review, I can do on behalf of @ntdiary 🙂

[tgolen]

@situchan, it sounds like it would be helpful for you to take over the review of this. Thank you!

[tgolen]

@johnmlee101 I was able to reproduce the bug you found. I'll have that fixed here in a few minutes I think

[tgolen]

All right, I found the bug and fixed it so the replace flow should work again. Updated!

[johnmlee101]

retesting that flow real quick!

[johnmlee101]

Nice, works 👍

[tgolen]

Wow, nice that those were caught. I am guessing they cropped up from some other PR that got merged... Fixed!

[tgolen]

quick! merge before something else conflicts!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.24-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[Gonals]

@tgolen, I think this may have caused this blocker (And likely this one, although I can't reproduce it). I'm investigating what's going on.

It is a pretty corner case flow, so I don't think we need to block deploy on it

[situchan]

@tgolen, I think this may have caused this blocker (And likely this one, although I can't reproduce it). I'm investigating what's going on

yes, they're same bug and main test flow in this PR and we demoted as happening on production (not reliably reproducible)
#32764 (comment)
#32764 (comment)

[Gonals]

@tgolen, I think this may have caused this blocker (And likely this one, although I can't reproduce it). I'm investigating what's going on

yes, they're same bug and main test flow in this PR and we demoted as happening on production (not reliably reproducible) #32764 (comment) #32764 (comment)

Oh, gotcha. I haven't been able to reproduce in prod, but it consistently happens in main/staging. Good to know it is not a blocker, tho

[joelbettner]

@tgolen I think the changes here might be related to #34295

[situchan]

@tgolen I think the changes here might be related to #34295

Hmm, I don't think so. I tested with receipt image and worked fine. This PR didn't touch such logic of pdf not working while image working. Jack requested QA team that pdf to reproduce but no answer yet.

sample:

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[DylanDylann]

BUG/REGRESSION

@tgolen In this PR, we use action param in IOURequestStepScan but in the creation flow the action param always be undefined. See below video

Screen.Recording.2024-01-29.at.22.53.51.mov

It was caused by we missed updating the route to use action param here

App/src/ROUTES.ts

Lines 396 to 400 in ef151c3

	MONEY_REQUEST_CREATE_TAB_SCAN: {
	route: 'create/:iouType/start/:transactionID/:reportID/scan',
	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string) => `create/${iouType}/start/${transactionID}/${reportID}/scan` as const,
	},

And we also need to update new route for IOURequestStartPage

cc @situchan