Fix/38814: Distance - Unable to save second distance edit offline #38987

DylanDylann · 2024-03-26T08:44:33Z

Details

This fixes a regression introduced in PR, which was a solution for #34610

Fixed Issues

$ #38814
PROPOSAL: NA

Tests

Go to workspace chat.
Create a distance request with three waypoints.
Go to request details page.
Go offline.
Click Distance.
Edit a waypoint
Repeat Step 5 and 6.
Verify that the user can save the second distance edit.

Offline tests

Same above

QA Steps

Same above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-29.at.18.41.10.mov

Android: mWeb Chrome

Screen.Recording.2024-03-29.at.15.06.14.mov

iOS: Native

Screen.Recording.2024-03-29.at.18.33.18.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.15.10.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-26.at.14.11.09.mov

MacOS: Desktop

Screen.Recording.2024-03-29.at.15.10.50.mov

melvin-bot · 2024-03-26T08:44:39Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-03-26T08:46:02Z

Small change

cubuspl42 · 2024-03-26T09:02:57Z

"Tests" block is outdated

DylanDylann · 2024-03-26T09:06:10Z

@cubuspl42 Updated

DylanDylann · 2024-03-27T07:41:11Z

@cubuspl42 Any update here

cubuspl42 · 2024-03-27T10:44:20Z

I'm testing right now.

cubuspl42 · 2024-03-27T11:13:30Z

Tested on this PR feature branch + main merged-in. This is on a fresh full Android build.

fix-unable-to-save-second-distance-edit-offline-android-compressed.mp4

The handles for dragging waypoints don't render, and there's a crash after attempting to drag them a few times.

While I don't think this is related, I believe that this is good enough reason to double-check this. You didn't include videos from other platforms than Web.

Please...

Mergemain
Test this on all platforms and provide screenshots/videos

cubuspl42 · 2024-03-27T11:30:16Z

Please fill the "Details" section, something like "This fixes a regression introduced in PR #{id}, which intended to fix issue #{issue-id}". This allows efficient navigation.

In general, never leave "Details" empty.

cubuspl42 · 2024-03-28T10:00:34Z

Can you reproduce the issue I mentioned? If so, did you find out if it's unrelated (i.e. occurring on main too)?

DylanDylann · 2024-03-29T08:13:26Z

@cubuspl42 I uploaded videos. On the Android and IOS native we have another bug: Can't drag waypoint. But I checked this bug and saw that it isn't related to this PR. We can create another issue to fix this

Screen.Recording.2024-03-29.at.15.08.32.mov

cubuspl42 · 2024-03-29T09:01:55Z

it isn't related to this PR

Neither this one, nor the original one, right?

We can create another issue to fix this

...unless there already is one. It would be good to know its ID, we might consider holding on it.

DylanDylann · 2024-03-29T09:18:43Z

@cubuspl42 We can report this bug on Slack channel. This fix is very simple and I think we don't need to hold this issue

DylanDylann · 2024-03-29T09:19:03Z

Neither this one, nor the #35302, right?

I am not sure

cubuspl42 · 2024-03-29T10:47:17Z

We can report this bug on Slack channel

Go for it :)

This fix is very simple and I think we don't need to hold this issue

You wrote "Blocked by another bug", classifying two platforms as untested 🙁 We should pick, we can't go with "not holding" and "blocked by another bug" at the same time

DylanDylann · 2024-03-29T11:34:14Z

@cubuspl42 I see another way to test this PR. I am updating videos for Android and IOS

Screen.Recording.2024-03-29.at.18.33.18.mov

DylanDylann · 2024-03-29T11:42:46Z

@cubuspl42 Updated videos

cubuspl42 · 2024-04-02T08:17:59Z

We have a ridiculous problem.

We need to change...

[...], which intended to fix https://github.com/Expensify/App/issues/34610

...to...

[...], which was a solution for https://github.com/Expensify/App/issues/34610

...or anything else that won't match this pattern.

DylanDylann · 2024-04-02T08:21:41Z

@cubuspl42 updated

cubuspl42 · 2024-04-02T08:23:44Z

It worked:

(there was a link here before)

DylanDylann · 2024-04-02T09:37:51Z

@cubuspl42 Is there any problem? It is small change, we should speed up it

cubuspl42 · 2024-04-02T10:35:23Z

No problem with this one. I spent some time on another issue in my queue.

cubuspl42 · 2024-04-02T10:37:57Z

I'm testing and recording videos; I'll approve it soon.

cubuspl42 · 2024-04-02T10:54:24Z

So, to double ensure...

Can you reproduce the crash Cannot assign to read-only property 'validated'?
- As I understand it, yes
Are you sure it wasn't, by any chance, introduced by the original PR (Fix/34610: Remove NewDistanceRequestPage and EditRequestDistancePage #35302)?
- As I understand it, no
Do you know the issue ID for this problem?
- As I understand it, no
Have you reported it to #expensify-bugs, like we discussed?
- As I understand it, no

I can't understand why you rush me so much, if we don't know exactly why the app is crashing under our feet during testing. I'm glad you found a workaround.

DylanDylann · 2024-04-02T13:15:34Z

@cubuspl42 That bug isn't causing this PR, this bug also happened on the main. It shouldn't be a blocker here. We can create a bug on Slack channel to fix it

cubuspl42 · 2024-04-02T13:51:51Z

I reported this on #expensify-bugs. I don't think there's much benefit of rushing with this PR, if the app just crashes on two crucial platforms in this flow. I'd assume that the other feature is a deploy blocker anyway.

cubuspl42 · 2024-04-03T10:36:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

fix-unable-to-save-second-distance-edit-offline-android-compressed.mp4

Android: mWeb Chrome

fix-unable-to-save-second-distance-edit-offline-android-web-compressed.mp4

iOS: Native

fix-unable-to-save-second-distance-edit-offline-ios-compressed.mp4

iOS: mWeb Safari

fix-unable-to-save-second-distance-edit-offline-ios-web-compressed.mp4

MacOS: Chrome / Safari

fix-unable-to-save-second-distance-edit-offline-web-converted.mp4

MacOS: Desktop

cubuspl42 · 2024-04-03T10:38:52Z

@srikarparsi

Originally, the testing steps involved re-ordering the waypoints. It triggered a crash, which is also observable on main.

We considered two options:

Holding on the discovered issue
Working it around / finding another way to test this PR

I suggested going with the first, but @DylanDylann strongly recommends the second option. I don't want to force my way, as I can see the benefits of both paths, so I approved. I'll leave the decision about the final approval to you.

srikarparsi · 2024-04-03T19:42:39Z

Hi, I am okay with merging because I think we can all agree that the root causes aren't related.

srikarparsi

lgtm

OSBotify · 2024-04-03T19:49:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T10:55:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update condition

7adfd18

DylanDylann requested a review from a team as a code owner March 26, 2024 08:44

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 26, 2024 08:44

DylanDylann mentioned this pull request Mar 26, 2024

[HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline #38814

Closed

6 tasks

cubuspl42 mentioned this pull request Mar 27, 2024

[Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610

Closed

DylanDylann added 2 commits March 28, 2024 15:14

merge main

23375f8

merge main

f8782d5

cubuspl42 approved these changes Apr 3, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi April 3, 2024 10:36

srikarparsi approved these changes Apr 3, 2024

View reviewed changes

srikarparsi merged commit 7080295 into Expensify:main Apr 3, 2024
20 checks passed

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/38814: Distance - Unable to save second distance edit offline #38987

Fix/38814: Distance - Unable to save second distance edit offline #38987

DylanDylann commented Mar 26, 2024 •

edited

Loading

melvin-bot bot commented Mar 26, 2024

DylanDylann commented Mar 26, 2024

cubuspl42 commented Mar 26, 2024

DylanDylann commented Mar 26, 2024

DylanDylann commented Mar 27, 2024

cubuspl42 commented Mar 27, 2024

cubuspl42 commented Mar 27, 2024

cubuspl42 commented Mar 27, 2024 •

edited

Loading

cubuspl42 commented Mar 28, 2024 •

edited

Loading

DylanDylann commented Mar 29, 2024

cubuspl42 commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

cubuspl42 commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

cubuspl42 commented Apr 2, 2024

DylanDylann commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024

DylanDylann commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024 •

edited

Loading

DylanDylann commented Apr 2, 2024 •

edited

Loading

cubuspl42 commented Apr 2, 2024

cubuspl42 commented Apr 3, 2024

cubuspl42 commented Apr 3, 2024

srikarparsi commented Apr 3, 2024

srikarparsi left a comment

OSBotify commented Apr 3, 2024

OSBotify commented Apr 8, 2024

Fix/38814: Distance - Unable to save second distance edit offline #38987

Fix/38814: Distance - Unable to save second distance edit offline #38987

Conversation

DylanDylann commented Mar 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 26, 2024

DylanDylann commented Mar 26, 2024

cubuspl42 commented Mar 26, 2024

DylanDylann commented Mar 26, 2024

DylanDylann commented Mar 27, 2024

cubuspl42 commented Mar 27, 2024

cubuspl42 commented Mar 27, 2024

cubuspl42 commented Mar 27, 2024 • edited Loading

cubuspl42 commented Mar 28, 2024 • edited Loading

DylanDylann commented Mar 29, 2024

cubuspl42 commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

cubuspl42 commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

DylanDylann commented Mar 29, 2024

cubuspl42 commented Apr 2, 2024

DylanDylann commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024

DylanDylann commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024

cubuspl42 commented Apr 2, 2024 • edited Loading

DylanDylann commented Apr 2, 2024 • edited Loading

cubuspl42 commented Apr 2, 2024

cubuspl42 commented Apr 3, 2024

Reviewer Checklist

Screenshots/Videos

cubuspl42 commented Apr 3, 2024

srikarparsi commented Apr 3, 2024

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 3, 2024

OSBotify commented Apr 8, 2024

DylanDylann commented Mar 26, 2024 •

edited

Loading

cubuspl42 commented Mar 27, 2024 •

edited

Loading

cubuspl42 commented Mar 28, 2024 •

edited

Loading

cubuspl42 commented Apr 2, 2024 •

edited

Loading

DylanDylann commented Apr 2, 2024 •

edited

Loading