-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New architecture] Upgrade react-native-camera-roll
#35986
Comments
This comment was marked as outdated.
This comment was marked as outdated.
New feat, not a bug. Recategorizing. |
@zanyrenney for context, this task was just forked off of the larger initiative to enable the new React Native Architecture in E/App so we can make a series of more bite-sized changes. SWM will handle this. |
Triggered auto assignment to @dylanexpensify ( |
Hey! I'm Bartosz from Software Mansion and I would like to work on this task. |
C+ review should be paid out at $250 instead of $500 for this issue |
Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@BartoszGrajdek the PR(s) for this were reverted, so we need to redo it. |
redoing here #37316 |
Not overdue! |
Hey @situchan @BartoszGrajdek what's the latest on this? Are we good to close this out? It looks like the PR redoing things was merged and deployed to production a while ago |
Sorry, it's different PR. I think we can close this |
Requesting payment on new dot for reviewing #36154 This can be closed. |
@roryabraham, can you please assign me here and confirm the payment for me? |
@roryabraham Can you confirm if we're good to pay out @thesahindia? |
yes, for sure we can complete payment for @thesahindia's review of #36154 then close this out |
since the request is going through NewDot, I'm going to close this GitHub issue |
$250 approved for @thesahindia based on this comment. |
We need to upgrade this library in order to use the new architecture in the App.
More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293338290529
The text was updated successfully, but these errors were encountered: