Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] Upgrade react-native-camera-roll #35986

Closed
j-piasecki opened this issue Feb 7, 2024 · 19 comments
Closed

[New architecture] Upgrade react-native-camera-roll #35986

j-piasecki opened this issue Feb 7, 2024 · 19 comments
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@j-piasecki
Copy link
Contributor

j-piasecki commented Feb 7, 2024

We need to upgrade this library in order to use the new architecture in the App.

More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293338290529

@j-piasecki j-piasecki added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 7, 2024

This comment was marked as outdated.

@roryabraham
Copy link
Contributor

New feat, not a bug. Recategorizing.

@roryabraham roryabraham assigned j-piasecki and unassigned zanyrenney Feb 7, 2024
@roryabraham roryabraham added NewFeature Something to build that is a new item. Weekly KSv2 and removed Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 7, 2024
@roryabraham
Copy link
Contributor

@zanyrenney for context, this task was just forked off of the larger initiative to enable the new React Native Architecture in E/App so we can make a series of more bite-sized changes. SWM will handle this.

Copy link

melvin-bot bot commented Feb 7, 2024

@BartoszGrajdek
Copy link
Contributor

Hey! I'm Bartosz from Software Mansion and I would like to work on this task.

@roryabraham
Copy link
Contributor

C+ review should be paid out at $250 instead of $500 for this issue

Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented Feb 22, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@roryabraham roryabraham removed the Reviewing Has a PR in review label Mar 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@roryabraham
Copy link
Contributor

@BartoszGrajdek the PR(s) for this were reverted, so we need to redo it.

@situchan
Copy link
Contributor

situchan commented Mar 1, 2024

@BartoszGrajdek the PR(s) for this were reverted, so we need to redo it.

redoing here #37316

@jasperhuangg
Copy link
Contributor

Not overdue!

@melvin-bot melvin-bot bot removed the Overdue label Mar 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@jasperhuangg
Copy link
Contributor

Hey @situchan @BartoszGrajdek what's the latest on this? Are we good to close this out? It looks like the PR redoing things was merged and deployed to production a while ago

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
@situchan
Copy link
Contributor

situchan commented Mar 19, 2024

Looks like @mollfpr's payment is pending if not paid elsewhere.
Payment summary: #35986 (comment)

Sorry, it's different PR. I think we can close this

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@thesahindia
Copy link
Member

thesahindia commented Apr 8, 2024

C+ review should be paid out at $250 instead of $500 for this issue

Requesting payment on new dot for reviewing #36154 This can be closed.

@thesahindia
Copy link
Member

@roryabraham, can you please assign me here and confirm the payment for me?

@jasperhuangg
Copy link
Contributor

@roryabraham Can you confirm if we're good to pay out @thesahindia?

@roryabraham
Copy link
Contributor

yes, for sure we can complete payment for @thesahindia's review of #36154 then close this out

@roryabraham
Copy link
Contributor

since the request is going through NewDot, I'm going to close this GitHub issue

@JmillsExpensify
Copy link

$250 approved for @thesahindia based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

9 participants