Workspace - Description field missing in WS profile settings in which user has joined

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+1117ck@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #36426

Action Performed:

Precondition : Open workspace in which user joined (but not have the role - Admin)

1. Open workspace page
2. Click on profile option
3. Observe description field missing

Expected Result:

Description field (read only) should be displayed in WS profile settings in which user has joined

Actual Result:

Description field missing in WS profile settings in which user has joined

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385714_1708434668165.Recording__72.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@bz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Description field missing in WS profile settings in which user has joined

What is the root cause of that problem?

We do not show description if the workspace settings is read-only

App/src/pages/workspace/WorkspaceProfilePage.js

Line 139 in 575cb5b

{(!_.isEmpty(policy.description) || !readOnly) && (

What changes do you think we should make in order to solve the problem?

Remove the !readOnly condition.

It won't have any effect on the editing ability of non authorized workspace employees as we have set editing to true only if the user is admin:

App/src/pages/workspace/WorkspaceProfilePage.js

Lines 144 to 145 in 575cb5b

	shouldShowRightIcon={!readOnly}
	disabled={readOnly}

What alternative solutions did you explore? (Optional)

N/A

[eucool]

@lanitochka17 , i guess you have mentioned the wrong person, @johncschuster is assigned to this issue :)

[johncschuster]

I'm not sure this is a bug. I'm asking in #product to see what the expected behavior of the Description field is when a non-admin views the profile page of a WS.

[johncschuster]

We had a chat about this in #product and agree this is expected behavior.

Basically, when a non-admin views the Workspace profile page and the description for the workspace is blank, we will how show the description field to the non-admin at all.

Closing!

[eucool]

can’t we put a condition over here to only display the description if it’s not empty?

…

On Fri, Feb 23, 2024 at 4:01 AM John Schuster ***@***.***> wrote: We had a chat about this in #product and agree this is expected behavior. Basically, when a non-admin views the Workspace profile page and the description for the workspace is blank, we will how show the description field to the non-admin at all. Closing! — Reply to this email directly, view it on GitHub <#36913 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BFJXGI573C35NZVA55JWUQTYU7BM3AVCNFSM6AAAAABDRMX4LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGQZTMMRRGQ> . You are receiving this because you commented.Message ID: ***@***.***>