General implementation profile page #36426

narefyev91 · 2024-02-13T17:10:32Z

Details

Implement General implementation of Profile page, Description page from the Simplified Collect: Profile, Members, Categories design doc

Images for references: (Share button will be introduced in other GH issue)

Fixed Issues

$ #35719
PROPOSAL: #35719

Tests

Open workspace as Admin:

Open workspace page
Verify that new design for profile page is applied
Verify that description field is visible and editable
Click on description
Verify that description screen is opened
Add some description -> Save
Verify that description screen is closed, and added description is visible in profile page
Click on description again
Add more than 500 characters
Verify that error message is shown

Open workspace in which user joined (but not have the role - Admin):

Open workspace page
Verify that new design for profile page is applied
Verify that all fields are readonly

Verify that no errors appear in the JS console

Offline tests

Open workspace as Admin:

Open workspace page
Verify that new design for profile page is applied
Verify that description field is visible and editable
Click on description
Verify that description screen is opened
Add some description -> Save
Verify that description screen is closed, and added description is visible in profile page
Click on description again
Add more than 500 characters
Verify that error message is shown

Open workspace in which user joined (but not have the role - Admin):

Open workspace page
Verify that new design for profile page is applied
Verify that all fields are readonly

QA Steps

Open workspace as Admin:

Open workspace page
Verify that new design for profile page is applied
Verify that description field is visible and editable
Click on description
Verify that description screen is opened
Add some description -> Save
Verify that description screen is closed, and added description is visible in profile page
Click on description again
Add more than 500 characters
Verify that error message is shown

Open workspace in which user joined (but not have the role - Admin):

Open workspace page
Verify that new design for profile page is applied
Verify that all fields are readonly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

# Conflicts: # src/components/Icon/Illustrations.ts # src/libs/API/parameters/index.ts # src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts # src/libs/Navigation/types.ts # src/pages/workspace/WorkspacePageWithSections.tsx # src/types/onyx/Form.ts

# Conflicts: # src/ONYXKEYS.ts # src/pages/workspace/WorkspaceProfilePage.js # src/types/onyx/Form.ts # src/types/onyx/index.ts

# Conflicts: # src/ROUTES.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx # src/libs/actions/Policy.ts # src/pages/workspace/WorkspaceProfilePage.js # src/types/form/index.ts

# Conflicts: # src/libs/API/parameters/index.ts

melvin-bot · 2024-02-15T10:52:28Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2024-02-15T12:23:53Z

@allroundexperts is around to review this now so we can keep moving!

allroundexperts · 2024-02-15T12:44:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-15.at.6.09.20.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-15.at.6.07.42.PM.mov

iOS: Native

Screen.Recording.2024-02-15.at.6.01.10.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-15.at.5.59.28.PM.mov

MacOS: Chrome / Safari

screen-recording-2024-02-15-at-55403-pm_Om8AxOeh.mp4

MacOS: Desktop

Screen.Recording.2024-02-15.at.5.57.08.PM.mov

allroundexperts · 2024-02-15T12:55:20Z

BUG
The tooltip shows up at incorrect place

allroundexperts · 2024-02-15T13:02:55Z

BUG
Menu item overlapping with the illustration

Screen.Recording.2024-02-15.at.6.01.56.PM.mov

allroundexperts · 2024-02-15T13:06:50Z

BUG
Getting a warning when the profile page opens

allroundexperts · 2024-02-15T13:11:21Z

Android and iOS show the name of workspace in different font types / sizes. Is this intentional?

narefyev91 · 2024-02-15T14:09:37Z

@allroundexperts appreciated for review! Fixed all items you mentioned above
One more thing regarding tooltip - it was already there (in staging) - no changes coming from this PR :-)

allroundexperts · 2024-02-15T14:17:04Z

@narefyev91 Was this fixed as well?

narefyev91 · 2024-02-15T14:21:33Z

@narefyev91 Was this fixed as well?

Yup!

Screen.Recording.2024-02-15.at.16.20.34.mov

allroundexperts · 2024-02-15T14:24:24Z

I was talking about the following overlap. Are you sure that the menu item sticking with the illustration is by design?

narefyev91 · 2024-02-15T14:32:35Z

I was talking about the following overlap. Are you sure that the menu item sticking with the illustration is by design?

ohh yup! gotcha! agree that we need to add space - added!

allroundexperts

Looking good!

luacmartins

LGTM. Thanks for working on this!

OSBotify · 2024-02-15T16:24:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

trjExpensify · 2024-02-15T17:25:44Z

Wahooo -- one down!

OSBotify · 2024-02-19T23:48:28Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:54:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mkhutornyi · 2024-03-14T12:58:00Z

src/pages/workspace/WorkspaceProfilePage.js

-                                imageStyles={[styles.avatarXLarge, styles.alignSelfCenter]}
-                                source={policy.avatar ? policy.avatar : ReportUtils.getDefaultWorkspaceAvatar(policyName)}
-                                fallbackIcon={Expensicons.FallbackWorkspaceAvatar}
+                <ScrollView>


@narefyev91 can you confirm nested ScrollView here is intentional?
I think it's redundant as shouldUseScrollView prop was already passed to WorkspacePageWithSections.
We wanna remove this in #38248 but just to double confirm to avoid regression.

Hey - it was added to scroll profile page on small devices. But if after removing nested ScrollView - it will work - fully fine with that. Thanks!

narefyev91 added 13 commits February 13, 2024 18:55

General implementation profile page

2b9a9b0

fix after merge

fd255ac

lint fix

0d21830

Merge branch 'main' into general-implementation-profile-page

251a77e

# Conflicts: # src/ONYXKEYS.ts # src/pages/workspace/WorkspaceProfilePage.js # src/types/onyx/Form.ts # src/types/onyx/index.ts

Updates after merge conflicts

810764b

Add max limit validation

aba4a32

clean up after running on native platforms

4cbfc47

Merge branch 'main' into general-implementation-profile-page

0a099f1

# Conflicts: # src/ROUTES.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx # src/libs/actions/Policy.ts # src/pages/workspace/WorkspaceProfilePage.js # src/types/form/index.ts

resolve conflicts

1b94301

Merge branch 'main' into general-implementation-profile-page

ab88466

# Conflicts: # src/libs/API/parameters/index.ts

ts fix

ae1a3db

polish

ed1b511

narefyev91 marked this pull request as ready for review February 15, 2024 10:52

narefyev91 requested a review from a team as a code owner February 15, 2024 10:52

melvin-bot bot requested review from alitoshmatov and removed request for a team February 15, 2024 10:52

trjExpensify requested review from allroundexperts and removed request for alitoshmatov February 15, 2024 12:23

Polish after review

72d1367

Add space

6dc7357

allroundexperts approved these changes Feb 15, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins February 15, 2024 14:40

luacmartins approved these changes Feb 15, 2024

View reviewed changes

luacmartins merged commit d20ada6 into Expensify:main Feb 15, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

situchan mentioned this pull request Feb 20, 2024

[$500] WS avatar does not have any indent from the bottom edge of the header #36835

Closed

6 tasks

lanitochka17 mentioned this pull request Feb 20, 2024

Workspace - Description field missing in WS profile settings in which user has joined #36913

Closed

6 tasks

ra-md mentioned this pull request Feb 21, 2024

[Payment due][$500] Clicking on workspace description does nothing #36991

Closed

6 tasks

mkhutornyi reviewed Mar 14, 2024

View reviewed changes

mkhutornyi mentioned this pull request Mar 14, 2024

fixes-37403 Workflows-If the first 2 options are enabled,cannot scroll to see the 3th option #38248

Merged

50 tasks

getusha mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-03] [$250] Workspace - Workspace name is truncated inconsistently in mWeb and android #41327

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General implementation profile page #36426

General implementation profile page #36426

narefyev91 commented Feb 13, 2024 •

edited

Loading

melvin-bot bot commented Feb 15, 2024

trjExpensify commented Feb 15, 2024

allroundexperts commented Feb 15, 2024 •

edited

Loading

allroundexperts commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

narefyev91 commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

narefyev91 commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

narefyev91 commented Feb 15, 2024

allroundexperts left a comment

luacmartins left a comment

OSBotify commented Feb 15, 2024

trjExpensify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

mkhutornyi Mar 14, 2024

narefyev91 Mar 14, 2024

General implementation profile page #36426

General implementation profile page #36426

Conversation

narefyev91 commented Feb 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 15, 2024

trjExpensify commented Feb 15, 2024

allroundexperts commented Feb 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

narefyev91 commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

narefyev91 commented Feb 15, 2024

allroundexperts commented Feb 15, 2024

narefyev91 commented Feb 15, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 15, 2024

trjExpensify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

mkhutornyi Mar 14, 2024

Choose a reason for hiding this comment

narefyev91 Mar 14, 2024

Choose a reason for hiding this comment

narefyev91 commented Feb 13, 2024 •

edited

Loading

allroundexperts commented Feb 15, 2024 •

edited

Loading