[HOLD for payment 2024-04-25] [POLISH][Members] Address issues with members profile

[luacmartins]

Coming from this PR, we have a few small issues to fix.

1. Navigate to global profile if not an admin of paid policy. We shouldn't just early return here, instead let's navigate the admin of a free policy to the global profile, like we do above.

2. Can't see owner's profile. We should probably just navigate to the global profile here.

Screen.Recording.2024-03-07.at.2.55.37.PM.mov

3. Info icon has active green color by default. We need to fix this.

4. Members - Back button on Members opens Members page after returning from member profile #37941
5. [$500] Workspace - Member role is not highlighted for newly-invited member #37940 - Backend PR here

cc @burczu

Issue Owner

Current Issue Owner: @Santhosh-Sellavel

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[burczu]

@kadiealexander @luacmartins Please assign this issue to me - I'll take care of it as na author of the original issue. Thank you.

[burczu]

@luacmartins

Regarding this:

1. Navigate to global profile if not an admin of paid policy. We shouldn't just early return here, instead let's navigate the admin of a free policy to the global profile, like we do above.

As I see, you've already fixed it, is that correct?

Regarding this:

2. Can't see owner's profile. We should probably just navigate to the global profile here.

This is intended and I'm addressing it here: #35716 - for owners we will show the Members Details page (if another admin selects it) but with the button that will allow to change the ownership. That's the reason I've left it untouched for now.

[burczu]

3. Info icon has active green color by default. We need to fix this.
   Screenshot 2024-03-07 at 2 56 15 PM

@shawnborton Could you please confirm this is a bug and we need to change the color of the Icon here? I recall we had similar situation with Bulk Actions - icons were grey on the design and green in the existing component...

[burczu]

I've just created draft PR.

[shawnborton]

Info icon has active green color by default. We need to fix this.

If we change this, we should globally change all of our option rows. It is something we've talked about given that now the rows in places like Settings don't use green icons anymore. So yeah, definitely open to this but only if we do it as a global change across all option rows/menu rows. Thoughts @Expensify/design ?

[burczu]

Info icon has active green color by default. We need to fix this.

If we change this, we should globally change all of our option rows. It is something we've talked about given that now the rows in places like Settings don't use green icons anymore. So yeah, definitely open to this but only if we do it as a global change across all option rows/menu rows. Thoughts @Expensify/design ?

Hmmm, so this sounds like a separate issue? @luacmartins

[dannymcclain]

I'm down for the change, but can totally see why we might want to make it a separate issue. Good with either approach.

[luacmartins]

Oh so the green icon is intentional? I thought it was a bug since we apply that style on hover to icons elsewhere, e.g. workspace settings page in the LHN

[shawnborton]

It's intentional, yup. But we should update it to match the the rows in the Settings page, and then make sure we update the hover styles as well.

[luacmartins]

@burczu we also have this issue - #37940

[burczu]

@burczu we also have this issue - #37940

@luacmartins This is caused by the backend issue we've already discussed on Slack.

[luacmartins]

PR to fix #37940 is here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #37927 bugfix: member details issues #37961

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @Santhosh-Sellavel requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @burczu is from an agency-contributor and not due payment
• Reviewer: @Santhosh-Sellavel owed $250 via NewDot

BugZero Checklist (@kadiealexander)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[kadiealexander]

@Santhosh-Sellavel please complete the checklist!

[melvin-bot]

@burczu, @luacmartins, @kadiealexander, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@burczu, @luacmartins, @kadiealexander, @Santhosh-Sellavel Still overdue 6 days?! Let's take care of this!

[luacmartins]

This was part of a new feature, so I don't think the checklist applies here. Are we good to close this issue?

[kadiealexander]

Oh, the bug label was applied. Closing, please apply for payment via newdot.

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$250 approved for @Santhosh-Sellavel