#35715 workspace member details page #37715

burczu · 2024-03-05T08:27:44Z

Details

In this PR we implement the member details page where the user can remove the member from workspace, change it role in the workspace and open its user profile. The PR does not cover changing the ownership of the workspace which will be handled in a separate PR.

Design reference used in this PR:

Fixed Issues

$ #35715
PROPOSAL: https://docs.google.com/document/d/1gk3xqOs7epMbUrSSiX8K7YcqfPLVgqEos0sf-D-GMDA/edit?pli=1#heading=h.qjcht79r25s1

Tests

Log in to the App
Open any workspace
Open members page
Click on the member
Verify the Member Details RHN opens
Try to remove member from the workspace
Try to change its role in the workspace

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-06.at.12.08.53.mov

Android: mWeb Chrome

Screen.Recording.2024-03-06.at.12.01.19.mov

iOS: Native

Screen.Recording.2024-03-06.at.11.58.13.mov

iOS: mWeb Safari

Screen.Recording.2024-03-06.at.11.59.34.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-06.at.11.48.21.mov

MacOS: Desktop

Screen.Recording.2024-03-06.at.11.50.25.mov

burczu · 2024-03-06T10:32:29Z

@luacmartins @Expensify/design One question on the design below:

In the the header we have "Alberto Cela" which, I assume, is displayName from personalDetails object (as we do on Profile page), but what is this "Cathy's Croissants"? From where can I take it?

melvin-bot · 2024-03-06T11:10:43Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2024-03-06T11:26:25Z

luacmartins Expensify/design One question on the design below:

In the the header we have "Alberto Cela" which, I assume, is displayName from personalDetails object (as we do on Profile page), but what is this "Cathy's Croissants"? From where can I take it?

@burczu It should be the workspace name.

burczu · 2024-03-06T11:27:58Z

@burczu It should be the workspace name.

@abdulrahuman5196 Ahhh... makes sense ;) I'll address this then.

burczu · 2024-03-06T11:31:40Z

@burczu It should be the workspace name.

@abdulrahuman5196 Ahhh... makes sense ;) I'll address this then.

@abdulrahuman5196 done

abdulrahuman5196

@burczu Could you kindly check on the above?

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

src/pages/workspace/members/WorkspaceMemberDetailsRoleSelectionPage.tsx

abdulrahuman5196 · 2024-03-06T12:00:41Z

src/pages/workspace/members/WorkspaceMemberDetailsRoleSelectionPage.tsx

+                        sections={[{data: items, indexOffset: 0}]}
+                        ListItem={RadioListItem}
+                        onSelectRow={changeRole}
+                        initiallyFocusedOptionKey={items.find((item) => item.isSelected)?.keyForList}


I don't see the tick mark for the very first time i open a member with the new changes

Screen.Recording.2024-03-06.at.5.26.50.PM.mov

is this a member that was invited right before? there is known issue that we need to address regarding this... the same problem is with bulk actions and "Make admin" option for freshly invited members (before refreshing the page) - I think there was some bug for it

this is related comment: #37748 (comment) - we agreed to fix this while working on inviting new members here: #37199 (comment)

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

src/libs/Navigation/types.ts

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

luacmartins · 2024-03-06T15:47:00Z

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

+
+    return (
+        <ScreenWrapper testID={WorkspaceMemberDetailsPage.displayName}>
+            <FullPageNotFoundView>


I think we need to block these views if the user is not an admin. We can reuse AdminPolicyAccessOrNotFoundWrapper and PaidPolicyAccessOrNotFoundWrapper

Added, but are you sure this feature should be available only for Paid Workspaces? I must have missed this requirement...
Should I also disable showing RHN when pressing on the member item if its non Paid Workspace?

@luacmartins ok, I think disabling RHN for non Paid Workspace is most reasonable - I've made this change, so now:

for Paid Workspaces, when user presses the checkbox, the item is selected and when user presses the whole item it shows the Member Details modal

for Non Paid Workspaces, pressing the whole item, as well as pressing the checkbox just selects the item

Please see the recording:

Screen.Recording.2024-03-07.at.14.30.22.mov

What do you think?

for Non Paid Workspaces, pressing the whole item, as well as pressing the checkbox just selects the item

Personally I don't like that there would be variability in pressing the whole item triggering the select action or not. I think we should limit selecting a row to just engaging with the checkbox, no matter what the case is. Curious if @Expensify/design agrees here.

So basically, let's not try to get tricky with using the whole row as a trigger action for the select box. Just make it so that you can only ever use the select box to select a row. For non-paid workspaces, just make the rest of the row non-tappable.

@shawnborton makes sense to me - I'll change it

Totally agree @shawnborton.

src/pages/workspace/members/WorkspaceMemberDetailsRoleSelectionPage.tsx

burczu · 2024-03-07T08:29:06Z

Refreshing after going to profile screen causes the back to fail. We need to add backTo route I think.

@burczu

Untitled.mov

@abdulrahuman5196 Good catch - thanks. Fixed.

abdulrahuman5196 · 2024-03-07T13:22:02Z

Thank you. Will check again in 30 mins.

abdulrahuman5196 · 2024-03-07T15:25:57Z

@burczu For workspaces where I haven't visited. It shows skeleton view and doesn't load data.

Screen.Recording.2024-03-07.at.8.54.11.PM.mov

luacmartins · 2024-03-07T18:17:33Z

@abdulrahuman5196 I think that might need a backend issue to create a new API command we can call to load member data. I'll work on one. Leet's not block this PR on that though

abdulrahuman5196 · 2024-03-07T19:25:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-08.at.12.47.34.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-03-08.at.12.35.05.AM.mp4

iOS: Native

Screen.Recording.2024-03-08.at.12.29.39.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-03-08.at.12.28.00.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-03-08.at.12.19.16.AM.mp4

MacOS: Desktop

Screen.Recording.2024-03-08.at.12.24.49.AM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @luacmartins

🎀 👀 🎀
C+ Reviewed

luacmartins

I've also spotted the issues below, but we can address them in a follow up:

Can't see owner's profile. We should probably just navigate to the global profile here.
https://github.com/Expensify/App/assets/22219519/00dcfb85-dbb2-45f7-b8b9-6fc21f5c2a55
Info icon has active green color by default. We need to fix this.

luacmartins · 2024-03-07T19:51:45Z

src/pages/workspace/WorkspaceMembersPage.tsx

+            }
+
+            if (!PolicyUtils.isPaidGroupPolicy(policy)) {
+                return;


I think we just wanna navigate to the regular profile here too

I won't block on this, but we should follow up with a fix.

luacmartins · 2024-03-07T20:02:00Z

Created issue here for the follow up - #37927

OSBotify · 2024-03-07T20:03:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-08T00:03:56Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-12T18:38:36Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alitoshmatov · 2024-06-02T19:28:01Z

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

+    const openRoleSelectionModal = useCallback(() => {
+        Navigation.navigate(ROUTES.WORKSPACE_MEMBER_ROLE_SELECTION.getRoute(route.params.policyID, accountID, Navigation.getActiveRoute()));
+    }, [accountID, route.params.policyID]);
+


We are not checking if user is workspace member or not, ref: #41492

basic member details page added

35f5618

burczu force-pushed the feature/35715-workspace-member-details-page branch from 9a95303 to 35f5618 Compare March 5, 2024 11:37

burczu added 7 commits March 5, 2024 13:19

passing personal details, policy members and routes to details page

be52759

passing backTo parameter to the details route

69ee8a1

showing member details page title from its personal details

210d294

showing avatar added

8e0f762

lint and prettier fixes

6dc39ce

remove from workspace button added

9409582

removing member implementation added

ec5458b

luacmartins self-requested a review March 5, 2024 13:52

burczu added 7 commits March 6, 2024 08:56

Merge branch 'main' into feature/35715-workspace-member-details-page

d50d4a4

after main merge fix

d916cae

role and profile buttons added

8000440

lint and prettier fixes

e29e0b2

role selection modal added

b37abfe

role selection list added

f583fd4

changing role on the role selection modal added

f24deca

burczu marked this pull request as ready for review March 6, 2024 11:10

burczu requested a review from a team as a code owner March 6, 2024 11:10

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 6, 2024 11:10

policy name added as subtitle of the member detail page

27f7917

abdulrahuman5196 suggested changes Mar 6, 2024

View reviewed changes

burczu added 2 commits March 6, 2024 13:23

transform scale helper introduced

7a91ec8

unnecessary padding removed

6775986

luacmartins requested changes Mar 6, 2024

View reviewed changes

burczu added 2 commits March 7, 2024 09:07

Merge branch 'main' into feature/35715-workspace-member-details-page

a85b5e7

backTo functionality fixed

dc7320e

burczu added 4 commits March 7, 2024 09:34

navigation type issue fixed

86bf243

state name adjusted

33509bb

event handler name adjusted

1159171

admin and paid policy access constraints added

f2b95c7

burczu added 4 commits March 7, 2024 14:24

Merge branch 'main' into feature/35715-workspace-member-details-page

f78a65e

disabled showing RHN for non paid workspaces

dcd13bb

selecting user on item press removed

0140c46

lint/prettier

18d88ef

abdulrahuman5196 approved these changes Mar 7, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 7, 2024 19:30

luacmartins approved these changes Mar 7, 2024

View reviewed changes

luacmartins merged commit 44267d3 into Expensify:main Mar 7, 2024
17 of 18 checks passed

luacmartins mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-04-25] [POLISH][Members] Address issues with members profile #37927

Closed

github-actions bot mentioned this pull request Mar 7, 2024

Deploy Checklist: New Expensify 2024-03-07 #37938

Closed

43 tasks

ahmedGaber93 mentioned this pull request Mar 8, 2024

[HOLD for payment 2024-03-19] [HOLD for payment 2024-03-18] By clicking on highlighted WS user, the checkbox is not selected or opening the details of the member #37942

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 11, 2024

[HOLD for payment 2024-03-18] [$500] [Simplified Collect][Members] WorkspaceMemberDetailsPage: full page implementation (without the Change owner feature) #35715

Closed

alitoshmatov reviewed Jun 2, 2024

View reviewed changes

alitoshmatov mentioned this pull request Jun 2, 2024

[HOLD for payment 2024-06-03] [$250] Workspace - Admin can access member details side bar after member leaves workspace #40416

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#35715 workspace member details page #37715

#35715 workspace member details page #37715

burczu commented Mar 5, 2024 •

edited

Loading

burczu commented Mar 6, 2024

melvin-bot bot commented Mar 6, 2024

abdulrahuman5196 commented Mar 6, 2024 •

edited

Loading

burczu commented Mar 6, 2024

burczu commented Mar 6, 2024

abdulrahuman5196 left a comment

abdulrahuman5196 Mar 6, 2024

burczu Mar 6, 2024 •

edited

Loading

burczu Mar 6, 2024 •

edited

Loading

abdulrahuman5196 Mar 6, 2024

luacmartins Mar 6, 2024

burczu Mar 7, 2024 •

edited

Loading

burczu Mar 7, 2024 •

edited

Loading

shawnborton Mar 7, 2024

burczu Mar 7, 2024

burczu Mar 7, 2024

dannymcclain Mar 7, 2024

burczu commented Mar 7, 2024

abdulrahuman5196 commented Mar 7, 2024

abdulrahuman5196 commented Mar 7, 2024

luacmartins commented Mar 7, 2024

abdulrahuman5196 commented Mar 7, 2024 •

edited

Loading

abdulrahuman5196 left a comment

luacmartins left a comment

luacmartins Mar 7, 2024

luacmartins Mar 7, 2024

luacmartins commented Mar 7, 2024

OSBotify commented Mar 7, 2024

OSBotify commented Mar 8, 2024

OSBotify commented Mar 12, 2024

alitoshmatov Jun 2, 2024

#35715 workspace member details page #37715

#35715 workspace member details page #37715

Conversation

burczu commented Mar 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

burczu commented Mar 6, 2024

melvin-bot bot commented Mar 6, 2024

abdulrahuman5196 commented Mar 6, 2024 • edited Loading

burczu commented Mar 6, 2024

burczu commented Mar 6, 2024

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burczu Mar 6, 2024 • edited Loading

Choose a reason for hiding this comment

burczu Mar 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burczu Mar 7, 2024 • edited Loading

Choose a reason for hiding this comment

burczu Mar 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burczu commented Mar 7, 2024

abdulrahuman5196 commented Mar 7, 2024

abdulrahuman5196 commented Mar 7, 2024

luacmartins commented Mar 7, 2024

abdulrahuman5196 commented Mar 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luacmartins commented Mar 7, 2024

OSBotify commented Mar 7, 2024

OSBotify commented Mar 8, 2024

OSBotify commented Mar 12, 2024

Choose a reason for hiding this comment

burczu commented Mar 5, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 6, 2024 •

edited

Loading

burczu Mar 6, 2024 •

edited

Loading

burczu Mar 6, 2024 •

edited

Loading

burczu Mar 7, 2024 •

edited

Loading

burczu Mar 7, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 7, 2024 •

edited

Loading