Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpDot] Update font size for summary #38986

Closed
rushatgabhane opened this issue Mar 26, 2024 · 11 comments
Closed

[HelpDot] Update font size for summary #38986

rushatgabhane opened this issue Mar 26, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@rushatgabhane
Copy link
Member

Coming from #38107 (comment)

We should use normal font size for summary text in helpdot.

@rushatgabhane rushatgabhane added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 26, 2024
Copy link

melvin-bot bot commented Mar 26, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@rushatgabhane
Copy link
Member Author

@MitchExpensify please assign this issue to me

@rushatgabhane rushatgabhane changed the title [HelpDot] [HelpDot] Update font size for summary Mar 26, 2024
@ghost
Copy link

ghost commented Mar 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

[HelpDot] Update font size for summary

What is the root cause of that problem?

Over here we are font size as larger :

App/docs/_sass/_main.scss

Lines 132 to 137 in d8361ee

h1,
summary {
font-family: "ExpensifyNewKansas", "Helvetica Neue", "Helvetica", Arial, sans-serif;
font-weight: 500;
font-size: larger;
}

What changes do you think we should make in order to solve the problem?

We can create a seperate style for summary with normal font :

summary {
    font-family: "ExpensifyNewKansas", "Helvetica Neue", "Helvetica", Arial, sans-serif;
    font-weight: 500;
    font-size: normal;
}

What alternative solutions did you explore? (Optional)

N/A

@ghost
Copy link

ghost commented Mar 26, 2024

Updated Proposal

@rushatgabhane
Copy link
Member Author

FYI, no proposals needed here. Part of helpdot project

@ghost
Copy link

ghost commented Mar 26, 2024

okay my bad, should I remove it? @rushatgabhane

@MitchExpensify
Copy link
Contributor

@MitchExpensify please assign this issue to me

Done!

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@MitchExpensify
Copy link
Contributor

What are next steps here @rushatgabhane ?

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@rushatgabhane
Copy link
Member Author

rushatgabhane commented Apr 1, 2024

I think we should do nothing. summary is only used for the heading FAQ.

It should match the font size of h1 so we should do nothing. cc: @shawnborton let me know if you disagree

Screenshot 2024-04-02 at 02 30 50

@shawnborton
Copy link
Contributor

Yeah, basically I am thinking that we just want to control our font sizes a bit and not introduce things like larger or percentage-based sizes anywhere. So as long as this looks exactly like an h1/h2/h3 or whatever it is supposed to be, that works for me.

@rushatgabhane
Copy link
Member Author

okay, thanks! it does look exactly like h1.
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants