-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HelpDot] Add light mode #38107
[HelpDot] Add light mode #38107
Conversation
@Pujan92 could you please approve to assign internal. Thanks 🙇 |
@shawnborton I've attached screenshot for light and dark mode. Please let me know if it looks good 🙇 |
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="Layer_1" x="0" y="0" version="1.1" viewBox="0 0 189 30" style="enable-background:new 0 0 189 30" xml:space="preserve"><style type="text/css">.st0{fill:#002e22}@media(prefers-color-scheme: dark){.st0{fill:#fffaf0}}.st1{fill:#03d47c}</style><g><g><path d="M0,23.1h13.9V19H5.1v-3.8h7.1V11H5.1V7.4h8.8V3.3H0V23.1z" class="st0"/><path d="M31.1,7.7H25l-2,3.7l-2.1-3.7h-6.3l5.1,7.5l-5.5,8h6.1l2.4-4.1l2.4,4.1h6.3l-5.5-8L31.1,7.7z" class="st0"/><path d="M40.8,7.3L40.8,7.3c-1.7,0-3.2,0.7-4.2,2V7.7h-4.7v22h5v-7.7c0.9,0.9,2.3,1.5,3.9,1.5c4.1,0,6.9-3.1,6.9-8.1 C47.7,10.5,45,7.3,40.8,7.3L40.8,7.3z M39.7,19.4c-1.9,0-3-1.5-3-4s1.1-4,3-4c1.9,0,3,1.4,3,4S41.5,19.4,39.7,19.4z" class="st0"/><path d="M56.4,19.6c-1.5,0-2.7-0.9-3-3.1h10.6v-0.7c0-4.8-2.7-8.5-7.9-8.5c-3.7,0-7.9,2-7.9,8.1 c0,4.9,3.2,8.1,8.1,8.1c2.9,0,6.6-1.1,7.7-5.6h-5.1C58.9,18.7,58.2,19.6,56.4,19.6L56.4,19.6z M56.2,11c1.4,0,2.4,0.8,2.6,2.6 h-5.2C54,11.6,55,11,56.2,11L56.2,11z" class="st0"/><path d="M73.9,7.3c-1.7,0-3.2,0.8-4.2,2.2V7.7h-4.7v15.4h5v-8.6c0-2.1,1.1-3,2.4-3c1.5,0,2.3,0.6,2.3,3v8.6h5v-9 C79.7,9.2,77.7,7.3,73.9,7.3L73.9,7.3z" class="st0"/><path d="M97.9,0.7c-1.5,0-2.6,1.1-2.6,2.6c0,1.4,1.1,2.6,2.6,2.6c1.5,0,2.6-1.2,2.6-2.6C100.5,1.8,99.5,0.7,97.9,0.7z" class="st0"/><path d="M100.4,7.7h-5v15.4h5V7.7z" class="st0"/><path d="M88.9,13.5l-1.2-0.3c-1.3-0.3-1.8-0.9-1.8-1.4c0-0.8,0.7-1.4,1.9-1.4c1.5,0,2.2,0.5,2.2,1.9h4.3 c-0.1-3.2-2-5.1-6.8-5.1c-4.1,0-6.6,1.5-6.6,5c0,2.7,1.8,3.9,6,4.9l1.2,0.3c1.3,0.3,1.8,0.9,1.8,1.5c0,0.8-0.8,1.2-2.1,1.2 c-1.7,0-2.5-0.6-2.7-2h-4.9c0.3,3.7,2.9,5.6,7.4,5.6c4.5,0,7.2-1.7,7.2-5.1C94.9,15.7,93.1,14.4,88.9,13.5L88.9,13.5z" class="st0"/><path d="M119.9,7.7L119.9,7.7l-2.8,9.4l-2.7-9.4h-6.5V7.2c0-1.3,0.9-2.5,2.4-2.5h0.7V0.6h-1c-4.3,0.1-7.1,3.1-7.1,6.9 v0.2h-1.9v4.5h1.9v10.8h5V12.3h2.8l3.7,10.4l-0.6,1.6c-0.5,1.2-1,1.5-2,1.5c-0.5,0-1.1,0-1.8-0.2l-0.3,4.1 c0.7,0.2,1.7,0.3,2.9,0.3c3,0,4.5-1.3,6-5.2L125,7.7L119.9,7.7L119.9,7.7z" class="st0"/></g><g><path d="M144.5,23.1c2.7,0,4.3-0.3,4.3-1.1c0-0.7-0.7-0.9-2.1-0.9c-0.4-0.1-0.5-1.5-0.5-3.2V6.9 c0-1.7,0.1-3.1,0.5-3.2c1.5-0.1,2.1-0.3,2.1-0.9c0-0.9-1.6-1.2-4.3-1.2c-2.8,0-4.4,0.3-4.4,1.2c0,0.6,0.7,0.8,2.1,0.9 c0.4,0.1,0.5,1.6,0.5,3.2v3.9c-0.1,0.3-0.3,0.4-1.1,0.4h-8.5c-0.8,0-1-0.1-1.1-0.4V6.9c0-1.7,0.1-3.1,0.5-3.2 c1.5-0.1,2.1-0.3,2.1-0.9c0-0.9-1.6-1.2-4.4-1.2c-2.7,0-4.3,0.3-4.3,1.2c0,0.6,0.7,0.8,2.1,0.9c0.4,0.1,0.4,1.6,0.4,3.2v10.9 c0,1.7-0.1,3.1-0.4,3.2c-1.5,0.1-2.1,0.3-2.1,0.9c0,0.8,1.6,1.1,4.3,1.1c2.8,0,4.4-0.3,4.4-1.1c0-0.7-0.7-0.9-2.1-0.9 c-0.4-0.1-0.5-1.5-0.5-3.2v-4.3c0.1-0.3,0.3-0.4,1.1-0.4h8.5c0.8,0,0.9,0.1,1.1,0.4v4.2c0,1.7-0.1,3.1-0.5,3.2 c-1.5,0.1-2.1,0.3-2.1,0.9C140.1,22.8,141.7,23.1,144.5,23.1z" class="st1"/><path d="M156.3,23.4c2.7,0,4.6-1.2,5.7-2.5c0.7-0.7,1-1.5,1-2c0-0.5-0.2-0.8-0.6-0.8c-0.3,0-0.5,0.2-0.8,0.5 c-0.9,0.9-2.2,1.9-4.3,1.9c-3,0-4.8-2.1-5-5.3h8.8c1.2,0,1.8-0.9,1.8-2.2c0-2.6-2.3-5.2-6.1-5.2c-4.1,0-7.5,3.3-7.5,8.1 C149.3,20.3,152.1,23.4,156.3,23.4z M152.4,13.6c0.4-2.6,2-4.2,4.3-4.2c2.1,0,3.4,1.4,3.4,3c0,0.8-0.5,1.2-1.5,1.2L152.4,13.6z" class="st1"/><path d="M167.6,23.1c2.3,0,3.7-0.3,3.7-1.1c0-0.6-0.6-0.7-1.7-0.8c-0.3-0.1-0.4-1.2-0.4-3.1V7.5 c0-2.1,0.1-3.8,0.1-4.8c0-1.1-0.2-1.6-1-1.6c-0.8,0-3,0.5-4.1,1c-0.4,0.2-0.6,0.4-0.6,0.8c0,0.4,0.4,0.7,2,0.8 c0.4,0.2,0.4,1.9,0.4,3.3V18c0,2.1,0,3-0.4,3.1c-1.1,0.1-1.7,0.2-1.7,0.8C163.9,22.8,165.2,23.1,167.6,23.1z" class="st1"/><path d="M175.7,28.6c2.9,0,4.4-0.2,4.4-1.1c0-0.6-0.6-0.7-2.3-0.9c-0.4-0.2-0.5-1.2-0.5-3.1v-1.9c1,1,2.6,1.7,4.6,1.7 c4.2,0,7.1-3.4,7.1-8.1c0-4.6-2.6-7.5-6.1-7.5c-2.5,0-4.7,1.5-5.6,3.6c0-0.8,0-1.4,0-1.8c0-1.1-0.2-1.6-1-1.6c-0.8,0-3,0.5-4,1 c-0.4,0.2-0.6,0.5-0.6,0.8c0,0.4,0.4,0.7,1.9,0.8c0.4,0.2,0.4,2,0.4,3.2v9.7c0,2.1-0.1,3-0.4,3.1c-1.2,0.1-1.8,0.3-1.8,0.9 C171.9,28.3,173.3,28.6,175.7,28.6z M177.3,16.2c0-4.4,2.2-6.2,4.3-6.2c2.3,0,4,2.2,4,5.9c0,3.6-1.6,5.8-4.2,5.8 C179.1,21.7,177.3,20.2,177.3,16.2z" class="st1"/></g></g></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a media query inside svg.
<style type="text/css">
.st0{
fill:#002e22
}
@media(prefers-color-scheme: dark){
.st0{
fill:#fffaf0
}
}
.st1{
fill:#03d47c
}
</style>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice. Didn't know you can do that!
Can we change the fill color for the wordmark in dark mode to be E7ECE9
please? Thanks!
Ok. Approved directly without review based on above comment. |
summary { | ||
font-family: "ExpensifyNewKansas", "Helvetica Neue", "Helvetica", Arial, sans-serif; | ||
font-family: 'ExpensifyNewKansas', 'Helvetica Neue', 'Helvetica', Arial, sans-serif; | ||
font-weight: 500; | ||
font-size: larger; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that we aren't using a normal font size here. I know this isn't part of your PR but maybe we can follow up with some adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure, created an issue - #38986
Is there a way to make a test build for easier testing? And how are you making the logo change across light and dark modes? |
@shawnborton i added a media query inside the svg to change logo colors. See - #38107 (comment) |
@shawnborton i deployed my branch here - https://light-mode--fastidious-unicorn-246321.netlify.app/ You can use it to preview the website. |
Looks great to me! |
@tylerkaraszewski all yours! we're good to merge |
@tylerkaraszewski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
expected. the helpdot workflow doesn't work on forks |
Details
Fixed Issues
$ #37911
PROPOSAL: N.A.
Tests
cd docs && npm run createDocsRoutes && bundle exec jekyll serve --livereload --safe
Dark mode
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Light mode
### HomeFooter
Search
Search result
Hubs
Sections
Article
Platform selector
Links
Dark mode