-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-03] [$500] [Workflows] Workspace - "Hmm it's not here" error appears briefly when enabling workflows #39443
Comments
Triggered auto assignment to @puneetlath ( |
@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue."Hmm it's not here" error appears briefly when enabling workflows What is the root cause of that problem?The main problem with issue is that when we create a new workspace we are waiting for a response from the server But after enabling PolicyWorkflows we will navigate to the PolicyWorkflows screen and make request to get current state of policy which is still disabled As result we will have here is list of event
What changes do you think we should make in order to solve the problem?To fix this issue we can update our App/src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx Lines 35 to 48 in 514bc3b
Here we add useState and useEffect. And only when What alternative solutions did you explore? (Optional)As alternative we can show isLoading while we are waiting answer from server In case of offline mode we will not use pendingFields
|
Job added to Upwork: https://www.upwork.com/jobs/~01f589bc2448420016 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 ( |
Hey! How can I re-enable workflow once I enabled it? Screen.Recording.2024-04-04.at.10.05.49.mov |
Do you mean to open more features ? |
Oh god 🤦 , silly me. Thank you. |
I'm not able to reproduce on latest main, can you still reproduce? @ZhenjaHorbach Screen.Recording.2024-04-04.at.14.37.18.mov |
This bug is reproduced immediately after creating a workspace |
Like this right? Screen.Recording.2024-04-04.at.14.46.26.mov |
Almost ) Screen.Recording.2024-04-04.at.09.49.56.mov |
I believe I could reproduce this issue without creating a new workspace while reviewing your proposal, however I can't reproduce it now. Can you give it a try and let me know? Thank you 😄 |
I understood what you were talking about) |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
and this: App/src/libs/actions/Policy.ts Line 4096 in f150229
to:
and this: App/src/libs/actions/Policy.ts Line 4116 in f150229
to:
What alternative solutions did you explore? (Optional)
|
@ZhenjaHorbach's alternative solution looks good to me. 🎀👀🎀 C+ reviewed |
This comment was marked as duplicate.
This comment was marked as duplicate.
Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
@hungvu193 In the |
Can you reproduce it? I tested it with all the features today and I can't seem to reproduce with pendingFields solution. |
|
Again I can reproduce the issue while I was reviewing 2 proposals, however I can't reproduce now 😂 , so It will take more times to review this alternative proposal One note for @ZhenjaHorbach, your solution worked but it will always show loading indicator even when we enabled the feature in offline mode. |
Updated proposition ) |
@ZhenjaHorbach Yeah. Please cover this case in your PR. Anyway, your proposal looks good |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-03. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@hungvu193 friendly reminder on the checklist so that we can pay in a couple days. |
This is new feature and we're still developing it so I don't think we need regression test for this one. |
All paid. Thanks y'all! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468674&group_by=cases:section_id&group_order=asc&group_id=283225
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
I shouldn't be getting any errors
Actual Result:
"Hmm it's not here" error appears briefly when enabling workflows for the first time
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6435811_1712077387579.bandicam_2024-04-02_18-58-32-923.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: