Not here error appears briefly when enabling features #40650

ZhenjaHorbach · 2024-04-20T23:10:17Z

Details

Fixed Issues

$ #39443
PROPOSAL: #39443 (comment)

Tests

Log in with a new expensify account
Create a workspace
Navigate to Workspace settings - More features
Enable workflows
Verify that "Hmm it is not here" is not showing

Verify that no errors appear in the JS console

Offline tests

Log in with a new expensify account
Create a workspace
Navigate to Workspace settings - More features
Enable workflows
Verify that "Hmm it is not here" is not showing

QA Steps

Log in with a new expensify account
Create a workspace
Navigate to Workspace settings - More features
Enable workflows
Verify that "Hmm it is not here" is not showing

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-14.at.23.35.34.mov

Android: mWeb Chrome

Screen.Recording.2024-04-14.at.23.35.34.mov

iOS: Native

Screen.Recording.2024-04-14.at.23.39.27.mov

iOS: mWeb Safari

Screen.Recording.2024-04-14.at.23.39.27.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-14.at.23.33.41.mov

MacOS: Desktop

Screen.Recording.2024-04-14.at.23.37.30.mov

melvin-bot · 2024-04-20T23:10:22Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-04-21T22:08:22Z

@hungvu193
Hello )
PR is ready )

hungvu193 · 2024-04-22T07:20:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mAndroid.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

chrome.mov

MacOS: Desktop

desk.mov

hungvu193 · 2024-04-22T07:26:47Z

For more context, the conversation from old PR is here:
#40219
@ZhenjaHorbach had some issues with signing commit so he created this PR.

hungvu193 · 2024-04-22T07:35:42Z

src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx

+        if (!isFocused) {
+            return;


@ZhenjaHorbach Can you elaborate about this one?
This one will cause regression, because in some feature screens, we still have the modal screen, ie: CategoryDetail.
So if we opened CategoryDetail screen and disabled the category feature, we will only see the NotFoundScreen after we dismiss the modal.

Evidence:

Screen.Recording.2024-04-22.at.14.36.09.mov

Hm
Good catch
Actually I think we can remove this condition
Because it was one of the options to get rid of setTimeout from my previous implementation

But now I tested without this condition
And it seems to work well

Still didn't work, please make sure you test it carefully.

Screen.Recording.2024-04-22.at.16.14.35.mov

I mentioned few test cases already, please make sure it will test all these cases.
#39443 (comment)

I made the video for all cases

zapis-ekrana-2024-04-22-v-114038_PvYQVrKb.mp4

Looks good!

hungvu193

LGTM!

src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx

src/pages/workspace/WorkspaceInitialPage.tsx

src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx

OSBotify · 2024-04-24T16:03:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-25T14:08:23Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T14:26:02Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-26T22:57:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify

Please avoid casts (as), it should be a last resource in exceptional cases, we have typescript because we want type safety and this breaks it.

aldo-expensify · 2024-08-07T19:54:29Z

src/pages/workspace/WorkspaceInitialPage.tsx

+    const policyFeatureStates = useMemo(
+        () => ({
+            [CONST.POLICY.MORE_FEATURES.ARE_DISTANCE_RATES_ENABLED]: policy?.areDistanceRatesEnabled,
+            [CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED]: policy?.areWorkflowsEnabled,
+            [CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED]: policy?.areCategoriesEnabled,
+            [CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED]: policy?.areTagsEnabled,
+            [CONST.POLICY.MORE_FEATURES.ARE_TAXES_ENABLED]: policy?.tax?.trackingEnabled,
+            [CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED]: policy?.areConnectionsEnabled,
+        }),
+        [policy],
+    ) as PolicyFeatureStates;


This cast as PolicyFeatureStates is wrong, we shouldn't cast except for very very very exceptional cases. If you remove the cast, we can clearly see that the type here is wrong:

You are saving possibly undefined values into a type that is supposed to have boolean (not boolean | undefined)

Oh, sorry, my fault
I agree that this is a mistake

aldo-expensify · 2024-08-07T19:54:39Z

src/pages/workspace/WorkspaceInitialPage.tsx

+            const newFeatureStates = {} as PolicyFeatureStates;
+            (Object.keys(policy?.pendingFields ?? {}) as PolicyFeatureName[]).forEach((key) => {


I think we should always avoid casting (as) since it breaks type safety. Was it really necessary?

I think in this case it make sense
Because Object.keys always returns string[]
Which in this case breaks the typing inside the callback

Fix bug with Not here error appears briefly when enabling features

0da9f7f

ZhenjaHorbach requested a review from a team as a code owner April 20, 2024 23:10

melvin-bot bot requested review from hungvu193 and removed request for a team April 20, 2024 23:10

ZhenjaHorbach added 4 commits April 21, 2024 01:15

Refactor switch

3f893fd

Refactor changes in FeatureEnabledAccessOrNotFoundComponent

0744c28

Refactor changes in FeatureEnabledAccessOrNotFoundComponent x2

224c9ea

Add clearPendingFieldsForMoreFeatures and refactor WorkspaceInitialPage

b72180c

ZhenjaHorbach mentioned this pull request Apr 21, 2024

Hmm it is not here error appears briefly when enabling workflows #40219

Closed

50 tasks

ZhenjaHorbach added 2 commits April 21, 2024 15:36

Update condition for clearPendingFieldsForMoreFeatures

578b27e

Remove clearPendingFieldsForMoreFeatures

cf28c35

hungvu193 suggested changes Apr 22, 2024

View reviewed changes

ZhenjaHorbach added 2 commits April 22, 2024 10:15

Remove isFocuesd from FeatureEnabledAccessOrNotFoundComponent

6a16d6d

Update condition for FeatureEnabledAccessOrNotFoundComponent

bd426b3

hungvu193 approved these changes Apr 22, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath April 22, 2024 10:45

puneetlath requested changes Apr 22, 2024

View reviewed changes

src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx Show resolved Hide resolved

src/pages/workspace/WorkspaceInitialPage.tsx Show resolved Hide resolved

Add comments for useEffects

dd18fab

puneetlath requested changes Apr 23, 2024

View reviewed changes

src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx Show resolved Hide resolved

Update comments

29269b7

puneetlath requested changes Apr 23, 2024

View reviewed changes

src/pages/workspace/FeatureEnabledAccessOrNotFoundWrapper.tsx Outdated Show resolved Hide resolved

Update comments x3

7752289

puneetlath approved these changes Apr 24, 2024

View reviewed changes

puneetlath merged commit 7ddb044 into Expensify:main Apr 24, 2024
17 checks passed

github-actions bot mentioned this pull request Apr 25, 2024

Deploy Checklist: New Expensify 2024-04-25 #40981

Closed

53 tasks

melvin-bot bot mentioned this pull request Apr 26, 2024

[HOLD for payment 2024-05-03] [$500] [Workflows] Workspace - "Hmm it's not here" error appears briefly when enabling workflows #39443

Closed

6 tasks

wildan-m mentioned this pull request Jul 2, 2024

[HOLD for payment 2024-07-24] [$250] mWeb-In new WS, for distance rate selecting a category & opening it directs to hmm not here #44206

Closed

6 tasks

wildan-m mentioned this pull request Jul 11, 2024

Fix not found page briefly appear on new workspace #45239

Merged

50 tasks

situchan mentioned this pull request Jul 29, 2024

[Simplified Collect][CLEAN UP][LOW] Standardize on Workspace wrapper #40598

Merged

50 tasks

aldo-expensify reviewed Aug 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Not here error appears briefly when enabling features #40650

Not here error appears briefly when enabling features #40650

ZhenjaHorbach commented Apr 20, 2024

melvin-bot bot commented Apr 20, 2024

ZhenjaHorbach commented Apr 21, 2024

hungvu193 commented Apr 22, 2024 •

edited

Loading

hungvu193 commented Apr 22, 2024 •

edited

Loading

hungvu193 Apr 22, 2024

hungvu193 Apr 22, 2024

ZhenjaHorbach Apr 22, 2024

hungvu193 Apr 22, 2024

hungvu193 Apr 22, 2024

ZhenjaHorbach Apr 22, 2024

hungvu193 Apr 22, 2024

hungvu193 left a comment

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

aldo-expensify left a comment

aldo-expensify Aug 7, 2024

ZhenjaHorbach Aug 7, 2024

aldo-expensify Aug 7, 2024

ZhenjaHorbach Aug 7, 2024

		const newFeatureStates = {} as PolicyFeatureStates;
		(Object.keys(policy?.pendingFields ?? {}) as PolicyFeatureName[]).forEach((key) => {

Not here error appears briefly when enabling features #40650

Not here error appears briefly when enabling features #40650

Conversation

ZhenjaHorbach commented Apr 20, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 20, 2024

ZhenjaHorbach commented Apr 21, 2024

hungvu193 commented Apr 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 25, 2024

OSBotify commented Apr 26, 2024

aldo-expensify left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Apr 22, 2024 •

edited

Loading

hungvu193 commented Apr 22, 2024 •

edited

Loading