[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOU-After deleting request, hold request system message displayed distorted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch app
2. Tap start chat
3. Select user with no prior conversation
4. Tap plus icon and request money without receipt
5. Again request money with receipt(use camera and upload an image for receipt)
6. Open 2nd IOU details page
7. Tap on top 3 dots and select hold request
8. Enter reason and save it
9. Tap got it.
10. Tap 3 dots and select unhold
11. Again tap 3 dots and delete request

Expected Result:

As in production, user must be navigated to previous IOU details page after deleting 2nd IOU.

Actual Result:

After deleting request, hold request system message displayed section looks distorted. User is in same delete request page in staging with distorted system message section but user navigated to previous IOU details page in production after deleting request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6445266_1712795995827.zx.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ea5b468859985ff
• Upwork Job ID: 1778348288449794048
• Last Price Increase: 2024-05-20
• Automatic offers:
• dukenv0307 | Reviewer | 102448064
• ahmedGaber93 | Contributor | 102448065

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

Screen_Recording_20240411_111029_New.Expensify.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ea5b468859985ff

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[Julesssss]

@Gonals this seems like enough of an edgecase to not block the deploy, do you agree?

[Gonals]

@Gonals this seems like enough of an edgecase to not block the deploy, do you agree?

Yeah, I'd say so

[melvin-bot]

@anmurali, @Gonals, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jjcoffee]

Waiting on proposals, have bumped on Slack!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix first action item background overlap on the next item #42629

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93 / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93 / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93 / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93 / @dukenv0307] Determine if we should create a regression test for this bug.
• [@ahmedGaber93 / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test

• Submit expense steps:

1. Open any chat
2. Tap plus icon > Submit expense then Submit expense without receipt
3. Open the created IOU details page and send two message
4. Tap 3 dots icon and delete the request
5. Verify that the background image not destroyed any of the two message you send it in step 3

• Assign task steps:

Open any chat

1. Tap plus icon > Assign task and create a task.
2. Open the created task details page and send two message
3. Tap 3 dots icon and delete the task
4. Verify that the background image not destroyed any of the two message you send it in step 3

• Thread steps:

1. Open any chat
2. Send message.
3. Right click on the message and click Reply in thread and send two replies
4. Right click on the thread message and delete comment
5. Verify that the background image not destroyed any of the two replies you send it in step 3\

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix first action item background overlap on the next item #42629

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93 / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93 / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93 / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93 / @dukenv0307] Determine if we should create a regression test for this bug.
• [@ahmedGaber93 / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[anmurali]

@ahmedGaber93 can you pls complete the BZ checklist. All offers are paid out.

[ahmedGaber93]

@anmurali BZ checklist is completed by C+ @dukenv0307 here #40078 (comment), I don't know why we have two BZ checklist!

[ahmedGaber93]

@anmurali I think we missed splitting contributor bounty between me and @VincentCorleone based on this #42629 (comment)

[melvin-bot]

@anmurali, @Gonals, @ahmedGaber93, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[anmurali]

@VincentCorleone - can you pls link me your Upwork profile? I will get you paid out and then close this issue. Sorry, I missed that comment up top.

[VincentCorleone]

@anmurali My Upwork profile link is: https://www.upwork.com/freelancers/~01ed57881916ec1303

[melvin-bot]

@anmurali, @Gonals, @ahmedGaber93, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali, @Gonals, @ahmedGaber93, @dukenv0307 Still overdue 6 days?! Let's take care of this!

[Gonals]

@anmurali, how's payment going?

[melvin-bot]

@anmurali, @Gonals, @ahmedGaber93, @dukenv0307 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[anmurali]

Ah, I paid @VincentCorleone a week ago. Forgot to close the issue.