fix first action item background overlap on the next item #42629

ahmedGaber93 · 2024-05-27T08:05:02Z

Details

Fixed Issues

$ #40078
$ #42629
PROPOSAL: #40078 (comment)

Tests

Submit expense steps:

Open any chat
Tap plus icon > Submit expense then Submit expense without receipt
Open the created IOU details page and send two message
Tap 3 dots icon and delete the request
Verify that the background image not destroyed any of the two message you send it in step 3

Assign task steps:

Open any chat
Tap plus icon > Assign task and create a task.
Open the created task details page and send two message
Tap 3 dots icon and delete the task
Verify that the background image not destroyed any of the two message you send it in step 3

Thread steps:

Open any chat
Send message.
Right click on the message and click Reply in thread and send two replies
Right click on the thread message and delete comment
Verify that the background image not destroyed any of the two replies you send it in step 3

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests step

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-27T08:05:06Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-05-28T02:56:08Z

@ahmedGaber93 Can you explain why you need to add overflow: hidden in 3 places while your proposal just mentions 1 place?

ahmedGaber93 · 2024-05-28T07:02:17Z

@dukenv0307 we have a similar issue here #41825 and another case in thread with replies. All need to fix.

dukenv0307 · 2024-05-29T07:09:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dukenv0307 · 2024-05-29T07:28:44Z

Thanks @ahmedGaber93. Code looks good and tests well

ahmedGaber93 · 2024-05-29T08:56:03Z

@dukenv0307 unfortunately this PR #38449 was deployed 11 hours ago changed the view structure, and that's make the current fix hide the image completely. I am working on it now.

pecanoro · 2024-05-29T21:07:18Z

I think this PR will also fix this issue, right? #42760

dukenv0307 · 2024-05-30T02:55:19Z

@ahmedGaber93 Nice catch. Can you estimate when you get finished? Thanks

ahmedGaber93 · 2024-05-30T04:23:26Z

I will post updates within 24 hours.

ahmedGaber93 · 2024-05-31T08:45:57Z

@dukenv0307 we can't use overflow: 'hidden' now after #38449 changes, I think the other proposal #40078 (comment) is the available solution now. This solution will not hide the bottom overflow, but it will make it under the next item on the list, I tested it and the UI seem good.
We can move forward with it and split the bounty. what do you think?

dukenv0307 · 2024-05-31T10:59:46Z

@ahmedGaber93 Thanks, can you share the screenshot for that?

We can move forward with it and split the bounty. what do you think?

sounds good to me.

ahmedGaber93 · 2024-05-31T11:35:27Z

Before	After

ahmedGaber93 · 2024-05-31T11:42:03Z

@dukenv0307 screenshots ☝️

dukenv0307 · 2024-06-03T05:26:06Z

LGTM. Wdyt ^ @Gonals?

Gonals · 2024-06-03T14:25:41Z

Looks good, but we have some conflicts!

dukenv0307 · 2024-06-04T03:11:33Z

@ahmedGaber93 Pls resolve the conflicts. Thanks

ahmedGaber93 · 2024-06-04T03:35:07Z

Sorry for the delay, I will update in few next hours.

# Conflicts: # src/pages/home/report/ReportActionItem.tsx # src/pages/home/report/ReportActionItemParentAction.tsx

Gonals · 2024-06-04T09:55:09Z

@ahmedGaber93 bump!

ahmedGaber93 · 2024-06-04T10:20:06Z

@Gonals @pecanoro Based on this #38449 (comment) and comments below it, we can't use overflow: 'hidden' now after #38449 changes.

So I pushed a new solution that not hide the bottom overflow, but it will make it under the next item on the list see result here #42629 (comment)

ahmedGaber93 · 2024-06-04T10:24:53Z

@dukenv0307 Please retest the new solution when you have at time.

dukenv0307 · 2024-06-05T02:59:03Z

@ahmedGaber93 Will review in a hour

dukenv0307 · 2024-06-05T03:32:04Z

LGTM

dukenv0307 · 2024-06-05T03:35:11Z

It would be fair to split bounty with @VincentCorleone. cc @ahmedGaber93 @Gonals

ahmedGaber93 · 2024-06-05T04:23:59Z

@dukenv0307 Yes, split is fair here. Thanks!

pecanoro · 2024-06-05T19:20:49Z

@Gonals All yours

OSBotify · 2024-06-06T08:54:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:32:34Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VincentCorleone · 2024-06-14T05:30:47Z

It would be fair to split bounty with @VincentCorleone. cc @ahmedGaber93 @Gonals

Thanks. I think so too. Would it be conducted? Who is authorized to conduct it?

fix first action item background overlap on the next item

b107d34

ahmedGaber93 requested a review from a team as a code owner May 27, 2024 08:05

melvin-bot bot removed the request for review from a team May 27, 2024 08:05

melvin-bot bot requested a review from dukenv0307 May 27, 2024 08:05

ahmedGaber93 mentioned this pull request May 27, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOU-After deleting request, hold request system message displayed distorted #40078

Closed

6 tasks

dukenv0307 approved these changes May 29, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals May 29, 2024 07:28

pecanoro mentioned this pull request May 29, 2024

Fix: There's a lot of extra space above the report actions #38449

Merged

50 tasks

pecanoro self-requested a review May 29, 2024 21:07

Gonals previously approved these changes Jun 3, 2024

View reviewed changes

pecanoro previously approved these changes Jun 3, 2024

View reviewed changes

Merge branch 'main' into issue-40078

887bf64

# Conflicts: # src/pages/home/report/ReportActionItem.tsx # src/pages/home/report/ReportActionItemParentAction.tsx

android fix BaseInvertedFlatList zIndex

f07731b

ahmedGaber93 dismissed stale reviews from pecanoro and Gonals via f07731b June 4, 2024 10:19

ahmedGaber93 requested review from Gonals, pecanoro and dukenv0307 June 4, 2024 10:20

dukenv0307 approved these changes Jun 5, 2024

View reviewed changes

pecanoro approved these changes Jun 5, 2024

View reviewed changes

Gonals approved these changes Jun 6, 2024

View reviewed changes

Gonals merged commit 056069e into Expensify:main Jun 6, 2024
19 checks passed

github-actions bot mentioned this pull request Jun 6, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

ahmedGaber93 mentioned this pull request Jun 7, 2024

[HOLD on 40768] [$250] Task - Background overlaps task details after deleting task #41825

Closed

6 tasks

rayane-djouah mentioned this pull request Jun 17, 2024

[HOLD for payment 2024-06-06] [$500] Empty state image has too much overlap with message in attachment thread #36166

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix first action item background overlap on the next item #42629

fix first action item background overlap on the next item #42629

ahmedGaber93 commented May 27, 2024 •

edited by pecanoro

Loading

melvin-bot bot commented May 27, 2024

dukenv0307 commented May 28, 2024

ahmedGaber93 commented May 28, 2024

dukenv0307 commented May 29, 2024 •

edited

Loading

dukenv0307 commented May 29, 2024

ahmedGaber93 commented May 29, 2024

pecanoro commented May 29, 2024

dukenv0307 commented May 30, 2024

ahmedGaber93 commented May 30, 2024

ahmedGaber93 commented May 31, 2024

dukenv0307 commented May 31, 2024

ahmedGaber93 commented May 31, 2024

ahmedGaber93 commented May 31, 2024

dukenv0307 commented Jun 3, 2024

Gonals commented Jun 3, 2024

dukenv0307 commented Jun 4, 2024

ahmedGaber93 commented Jun 4, 2024

Gonals commented Jun 4, 2024

ahmedGaber93 commented Jun 4, 2024 •

edited

Loading

ahmedGaber93 commented Jun 4, 2024

dukenv0307 commented Jun 5, 2024

dukenv0307 commented Jun 5, 2024

dukenv0307 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

pecanoro commented Jun 5, 2024

OSBotify commented Jun 6, 2024

OSBotify commented Jun 11, 2024

VincentCorleone commented Jun 14, 2024

fix first action item background overlap on the next item #42629

fix first action item background overlap on the next item #42629

Conversation

ahmedGaber93 commented May 27, 2024 • edited by pecanoro Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 27, 2024

dukenv0307 commented May 28, 2024

ahmedGaber93 commented May 28, 2024

dukenv0307 commented May 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented May 29, 2024

ahmedGaber93 commented May 29, 2024

pecanoro commented May 29, 2024

dukenv0307 commented May 30, 2024

ahmedGaber93 commented May 30, 2024

ahmedGaber93 commented May 31, 2024

dukenv0307 commented May 31, 2024

ahmedGaber93 commented May 31, 2024

ahmedGaber93 commented May 31, 2024

dukenv0307 commented Jun 3, 2024

Gonals commented Jun 3, 2024

dukenv0307 commented Jun 4, 2024

ahmedGaber93 commented Jun 4, 2024

Gonals commented Jun 4, 2024

ahmedGaber93 commented Jun 4, 2024 • edited Loading

ahmedGaber93 commented Jun 4, 2024

dukenv0307 commented Jun 5, 2024

dukenv0307 commented Jun 5, 2024

dukenv0307 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

pecanoro commented Jun 5, 2024

OSBotify commented Jun 6, 2024

OSBotify commented Jun 11, 2024

VincentCorleone commented Jun 14, 2024

ahmedGaber93 commented May 27, 2024 •

edited by pecanoro

Loading

dukenv0307 commented May 29, 2024 •

edited

Loading

ahmedGaber93 commented Jun 4, 2024 •

edited

Loading