[HOLD for payment 2021-12-06] The Android hardware back button does not minimise the app when pressed on the LHN/home screen

[kp17211]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on an a chat from the LHN
2. Once you're in the chat, press the back button to navigate back to the LHN/home screen
3. From the LHN/home screen, press the back button again

Expected Result:

• When pressing the back button on the LHN/home screen, the app should be minimised (exited).

Actual Result:

• When pressing the back button on the LHN/home screen, we navigate back to the previous chat that users was in.

Workaround:

• None

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork URL: https://www.upwork.com/jobs/~017e60e720f6f9aca8

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mallenexpensify]

I don't have Android, trying to find someone on the CM team to triage

[mallenexpensify]

Assigning to @laurenreidexpensify for review since she has Android and I don't.

[parasharrajat]

To me this is reproducible.

[laurenreidexpensify]

@kp17211 @parasharrajat I'm trying to reproduce this and a bit confused.

• Am on my Chats page
• tap into a chat
• within chat, tap top left hand < icon
• taken back to chat page
• swipe left as the generic Android "back" action
• am taken to the chat I was just in

Am I missing something? Isn't this the expected behaviour?

[parasharrajat]

am taken to the chat I was just in

This is an issue.

the flow should be

1. You click on any chat from LHN.
2. It takes you to the chat.
3. You click back button on android phone.
4. It takes you back to chat list / LHN.
5. You press the hardward back button again.
6. App should minimize.
7. But it will take you back to the recent open chat.

[laurenreidexpensify]

Ah got it - okay yes I can confirm this is the behaviour then. Will send this to our engineering team for next review.

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

I could've sworn this was a feature and not a bug (granted, that I found strange as well). What's the behavior on iOS?

[Beamanator]

What's the behavior on iOS?

I don't believe iOS has a "back" hardware button (at least most of their devices don't) so I think this only applies in Android.

I agree this should be fixed eventually, it's how most (if not all) Android apps work, so I'll take this over and making it External

Looks like these resources could be helpful:

• https://reactnative.dev/docs/backhandler
• https://reactnavigation.org/docs/custom-android-back-button-handling/
• Conversation in #expensify-open-source about using hooks here

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.12-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: back handler for Drawer #5745

If no regressions arise, payment will be issued on 2021-11-09. 🎊

[Beamanator]

Hmm looks like this PR got reverted here: #6161 - @parasharrajat is looking into how to fix the issues that came from this PR

[Beamanator]

not overdue, @parasharrajat is actively working on a fix in ^ PR

[Beamanator]

Not overdue - fix is in staging, waiting to get to production

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix back handler for Android #6295

If no regressions arise, payment will be issued on 2021-12-06. 🎊

[parasharrajat]

Ping for

@trjExpensify

Information for your reference.

#5745 (comment) has the breakdown for payment. Please skip the milestone for 5027.

Apart from it, there were two PR created for this issue. the first one #5745 went through N6-Hold and the second #6295 through Company Offsite Hold.

[trjExpensify]

Woof, this was a long one ey! So I presume from @mallenexpensify comment, this is the correct Upwork job, right? https://www.upwork.com/jobs/~017e60e720f6f9aca8

It's closed though and I couldn't see your proposal nor being hired Rajat, so we'll need to sort that out once confirmed this didn't move elsewhere. Then maybe @Beamanator can help confirm the total payable for this job at this point, skipping #5027. Am I reading it correctly that it should be $1,500?

[parasharrajat]

@Beamanator Could you please help us out here?

[Beamanator]

I just looked through and I also believe payment should be $1,500. Breakdown:

• $1000 for fixing this issue (this price was set here)
• $250 for Allow disabling BackHandler subscription in DrawerView  react-navigation/react-navigation#9936 (We agreed here) that this is a separate job
• $250 because this PR was submitted before the n6-hold ended so should get the $250 bonus

@parasharrajat you thought your PR would also fix #5971, but we ended up closing it b/c it couldn't be reproduced, so no reward there.

[parasharrajat]

there were two PR created for this issue. the first one #5745 went through N6-Hold and the second #6295 through Company Offsite Hold.

@Beamanator I am not sure about this but do you think the two bonuses apply here n6-hold and company offsite hold? Could you please confirm that as well? Thanks.

[Beamanator]

Hmm here's my thinking:

• Fix back handler for Android #6295 was officially "ready for review" on November 17 (see this comment)
• We ended the Company Offsite Hold on the 16th (see this slack message)

So I don't think that PR is eligible for the Company Offsite Hold bonus, let me know if you disagree though (also @trjExpensify)

[parasharrajat]

Correct. I overlooked it. Thanks.

[Beamanator]

No prob at all

[trjExpensify]

Awesome. Offer sent 👍

[trjExpensify]

All sorted, closing.