Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - LHN is not displayed when reopening app from dock #5971

Closed
isagoico opened this issue Oct 21, 2021 · 23 comments
Closed

Desktop - LHN is not displayed when reopening app from dock #5971

isagoico opened this issue Oct 21, 2021 · 23 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

There's currently no solid reproduction steps:

  1. Leave the desktop app minimized for a little while
  2. Open the app.

Expected Result:

LHN and UI is displayed without visual issues.

Actual Result:

LHN is missing from the sidebar

Workaround:

Unknown.

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Unknown

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Note: @parasharrajat was also able to reproduce this one.

Expensify/Expensify Issue URL:

Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634705195483300

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@deetergp
Copy link
Contributor

Don't think this will touch the back end at all so it should be fine for an external contractor to work on.

@deetergp deetergp added the External Added to denote the issue can be worked on by a contributor label Oct 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @marklouisdeshaun (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@deetergp deetergp added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Oct 21, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@deetergp
Copy link
Contributor

I re-applied the External label since I read earlier in the day that @marklouisdeshaun was leaving the CM team.

@parasharrajat
Copy link
Member

We don't need to export this yet. There are no reliable steps. This was a one-time thing for me and I am making a major change to the drawer #5745 and thus I am sure this issue will become invalid.

@deetergp deetergp removed the External Added to denote the issue can be worked on by a contributor label Oct 21, 2021
@deetergp
Copy link
Contributor

Thanks for the update @parasharrajat! I've removed the label (again) for the time being. If you feel that your fix has resolved this issue feel free to close this one.

@parasharrajat
Copy link
Member

Great. I will tag that in the PR.

@deetergp
Copy link
Contributor

Thanks, Rajat!

@roryabraham
Copy link
Contributor

@isagoico Can you confirm this issue will be tested as part of the weekly KI retests?

@roryabraham roryabraham added Weekly KSv2 Improvement Item broken or needs improvement. Needs Reproduction Reproducible steps needed and removed Daily KSv2 labels Oct 22, 2021
@isagoico
Copy link
Author

@roryabraham We currently don't test issues raised in the #expensify-open-source so this was not going to be included in the list, but we can definitely add this one (or others) to the KI Retests. CC @mvtglobally

@roryabraham
Copy link
Contributor

Hmmm I thought that E/App issues went through weekly KI retests along with E/E issues

@isagoico
Copy link
Author

All E/App issues (raised by Applause testers) are going through weekly KI. What I meant before is that issues raised on the #expensify-open-source don't go through the KI Retests at the moment and we could add them to the KI retests round if requested on the issue (similar like what you did here

@roryabraham
Copy link
Contributor

Okay, well for now let's just add this one to KI retests if possible! Thanks!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First Week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second Week)

@stephanieelliott
Copy link
Contributor

Holding while we wait on reproduction

@MelvinBot MelvinBot removed the Overdue label Nov 3, 2021
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third Week)
@roryabraham Let us know if we should close it or keep checking

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fourth Week)

@stephanieelliott
Copy link
Contributor

Still waiting on reproduction. IMO I think we can stop testing this since it's unreproducible 4w in a row. Will wait for @roryabraham to weigh in to make the final call though!

@MelvinBot MelvinBot removed the Overdue label Nov 17, 2021
@roryabraham
Copy link
Contributor

I think the standard time to close KI's is 6 weeks, right @mvtglobally?

@isagoico
Copy link
Author

Nope, the standard is 3 weeks of no reproduction and then close.

@roryabraham
Copy link
Contributor

Oh, then ya let's close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants