Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-14] [$250] Customers and Projects have option as Sage Intacct Employee Default #45823

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 20, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721402815163979

Action Performed:

Pre-testing requirement: Make sure that your test account is on the intacctOnNewExpensify beta

  1. Open any workspace settings
  2. Enable accounting
  3. Connect to Intacct
  4. Click on Import

Expected Result:

Customers and Projects dimensions should have Tag and Report field options only; Employee Default should not be an option

Actual Result:

Sage Intacct Employee Default shows as an option for Customers and Projects dimensions

NOTE: For me it projects is showing as Tags

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image (6)
Snip - (3) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fea203f70b955c11
  • Upwork Job ID: 1815806282266209115
  • Last Price Increase: 2024-07-23
Issue OwnerCurrent Issue Owner: @stephanieelliott
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 20, 2024
Copy link

melvin-bot bot commented Jul 20, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@stephanieelliott
Copy link
Contributor

Updated the issue body to be a bit more clear -- the Customer and Project dimensions should show the Report Field and Tag options ONLY; Employee Default should not show as an option for these dimensions and needs to be removed.

@melvin-bot melvin-bot bot removed the Overdue label Jul 23, 2024
@stephanieelliott stephanieelliott added the External Added to denote the issue can be worked on by a contributor label Jul 23, 2024
@melvin-bot melvin-bot bot changed the title Customers and Projects have option as Sage Intacct Employee Default [$250] Customers and Projects have option as Sage Intacct Employee Default Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fea203f70b955c11

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

@dominictb
Copy link
Contributor

dominictb commented Jul 24, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sage Intacct Employee Default shows as an option for Customers and Projects dimensions

What is the root cause of that problem?

After connecting to Sage intacct, BE returns Employee Default for Customer and Project

What changes do you think we should make in order to solve the problem?

  1. We should fix BE to return Tags by default
  2. In

updateSageIntacctMappingValue(policyID, mappingName, CONST.SAGE_INTACCT_MAPPING_VALUE.DEFAULT);

We should change to CONST.SAGE_INTACCT_MAPPING_VALUE.TAG

Then remove employeeDefault in

{
value: CONST.SAGE_INTACCT_MAPPING_VALUE.DEFAULT,
text: translate('workspace.intacct.employeeDefault'),
alternateText: translate('workspace.common.appliedOnExport'),
keyForList: CONST.SAGE_INTACCT_MAPPING_VALUE.DEFAULT,
isSelected: mappings?.[mappingName] === CONST.SAGE_INTACCT_MAPPING_VALUE.DEFAULT,
},

We also can remove default mapping options in getDisplayTypeTranslationKey and getDisplayTypeTranslationKeys

What alternative solutions did you explore? (Optional)

NA

@jayeshmangwani
Copy link
Contributor

Hey @dominictb 👋 , I have a hard time reaching this page.

Just a question: how can we reach this page and reproduce the issue?

@stephanieelliott
Copy link
Contributor

@jayeshmangwani how far are you able to get on the repro steps -- are you able to reach Connect to Intacct? If not, you likely need to complete the pre-requisite steps described in #45938 (comment), more specifically we need to add you to the intacctOnNewExpensify beta. If you can share the email address for the test account you're using, I can add you to that beta.

@jayeshmangwani
Copy link
Contributor

more specifically we need to add you to the intacctOnNewExpensify beta. If you can share the email address for the test account you're using, I can add you to that beta.

Please add jm98289517+46@gmail.com , I will try to connect with this user

@SzymczakJ
Copy link
Contributor

I was implementing this and Sage Intacct design doc didn't state anything like this, do we have a main source of truth?

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@jayeshmangwani
Copy link
Contributor

@SzymczakJ Currently, I don't have access to the Design doc. However, according to @sakluger's Issue Description:

According to the design doc and based on the OldDot config settings, Customer and Project dimensions do not support employee default, so those two dimensions should only have tag and report field options.

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
@SzymczakJ
Copy link
Contributor

Sorry for the confusion, I should have read the whole thread before writing comments 😅. Can this issue be assigned as I already have context and I am author of this implementation?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 30, 2024
@JmillsExpensify
Copy link

Assigned @SzymczakJ since he implemented this feature.

@hungvu193
Copy link
Contributor

I'll review PR today 😄

@jayeshmangwani
Copy link
Contributor

@stephanieelliott Please assign this issue to @hungvu193 as they reviewed the original PR that worked on this feature and have more context. I am unassigning myself.

Copy link

melvin-bot bot commented Aug 2, 2024

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hungvu193
Copy link
Contributor

@Gonals #46505 will be ready for your final review

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 7, 2024
@melvin-bot melvin-bot bot changed the title [$250] Customers and Projects have option as Sage Intacct Employee Default [HOLD for payment 2024-08-14] [$250] Customers and Projects have option as Sage Intacct Employee Default Aug 7, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Aug 7, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
  • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@hungvu193] Determine if we should create a regression test for this bug.
  • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 14, 2024
Copy link

melvin-bot bot commented Aug 14, 2024

Payment Summary

Upwork Job

  • Reviewer: @hungvu193 owed $250 via NewDot
  • Contributor: @SzymczakJ is from an agency-contributor and not due payment

BugZero Checklist (@stephanieelliott)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1815806282266209115/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@hungvu193
Copy link
Contributor

@stephanieelliott No payment is needed for me. Feel free to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Archived in project
Development

No branches or pull requests

8 participants