-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-14] [$250] Customers and Projects have option as Sage Intacct Employee Default
#45823
Comments
Triggered auto assignment to @stephanieelliott ( |
Updated the issue body to be a bit more clear -- the Customer and Project dimensions should show the |
Sage Intacct Employee Default
Sage Intacct Employee Default
Job added to Upwork: https://www.upwork.com/jobs/~01fea203f70b955c11 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Sage Intacct Employee Default shows as an option for Customers and Projects dimensions What is the root cause of that problem?After connecting to Sage intacct, BE returns What changes do you think we should make in order to solve the problem?
App/src/pages/workspace/accounting/intacct/import/SageIntacctToggleMappingsPage.tsx Line 95 in 2bb1d00
We should change to Then remove App/src/pages/workspace/accounting/intacct/import/SageIntacctMappingsTypePage.tsx Lines 29 to 35 in 2bb1d00
We also can remove default mapping options in What alternative solutions did you explore? (Optional)NA |
Hey @dominictb 👋 , I have a hard time reaching this page. Just a question: how can we reach this page and reproduce the issue? |
@jayeshmangwani how far are you able to get on the repro steps -- are you able to reach |
Please add jm98289517+46@gmail.com , I will try to connect with this user |
I was implementing this and Sage Intacct design doc didn't state anything like this, do we have a main source of truth? |
@SzymczakJ Currently, I don't have access to the Design doc. However, according to @sakluger's Issue Description: According to the design doc and based on the OldDot config settings, Customer and Project dimensions do not support employee default, so those two dimensions should only have |
Sorry for the confusion, I should have read the whole thread before writing comments 😅. Can this issue be assigned as I already have context and I am author of this implementation? |
Assigned @SzymczakJ since he implemented this feature. |
I'll review PR today 😄 |
@stephanieelliott Please assign this issue to @hungvu193 as they reviewed the original PR that worked on this feature and have more context. I am unassigning myself. |
Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Sage Intacct Employee Default
Sage Intacct Employee Default
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@stephanieelliott)
|
@stephanieelliott No payment is needed for me. Feel free to close |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721402815163979
Action Performed:
Pre-testing requirement: Make sure that your test account is on the intacctOnNewExpensify beta
Expected Result:
Customers and Projects dimensions should have
Tag
andReport field
options only;Employee Default
should not be an optionActual Result:
Sage Intacct Employee Default
shows as an option for Customers and Projects dimensionsNOTE: For me it projects is showing as
Tags
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @stephanieelliottThe text was updated successfully, but these errors were encountered: