Fix Customers and Projects to not have option as Sage Intacct Employee Default #46505

SzymczakJ · 2024-07-30T14:49:17Z

Details

This PR blocks Customer and Projects mapping from having Sage Intacct Employee Default. I've also found one thing in the docs, that wasn't implemented(quote from design doc):

Mapping to Sage Intacct employee default is only available if you choose to export as an Expense Report which uses the employee record in Sage Intacct. If they choose to export as a Vendor Bill, you will not be able to see the Sage Intacct employee default selection for any tags.

so this PR also fixes this issue, by not allowing to choose Sage Intacct Employee Default, when Export is set to Vendor BIll and also switching every mapping from Sage Intacct Employee Default to Tag when we switch to Vendor Bill.

Fixed Issues

$ #45823
PROPOSAL: N/A

Tests

Head to Workspace settings
Head to Accounting
Connect to Sage Intacct
Make sure that Customers and Locations mapping cannot be set to employee default option
Set Export out-of-pocket expenses as Vendor bills

Make sure that every mapping cannot be set to employee default option
Switch back out-of-pocket expenses to Expense reports and make sure that you can set Locations, Departments and Classes to employee default option.

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

androidweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

… locations mappings

…DOR_BILL

war-in

LGTM 🚀

war-in · 2024-07-31T08:28:52Z

src/pages/workspace/accounting/intacct/import/SageIntacctMappingsTypePage.tsx

+            mappingName !== CONST.SAGE_INTACCT_CONFIG.MAPPINGS.CUSTOMERS &&
+            mappingName !== CONST.SAGE_INTACCT_CONFIG.MAPPINGS.PROJECTS &&


Nit: maybe we could build an array with those consts and check if it includes mapping 🤔
But there are only two of them so it's up to you :)

Suggested change

mappingName !== CONST.SAGE_INTACCT_CONFIG.MAPPINGS.CUSTOMERS &&

mappingName !== CONST.SAGE_INTACCT_CONFIG.MAPPINGS.PROJECTS &&

![CONST.SAGE_INTACCT_CONFIG.MAPPINGS.CUSTOMERS,

CONST.SAGE_INTACCT_CONFIG.MAPPINGS.PROJECTS

].includes(mappingName) &&

melvin-bot · 2024-07-31T17:33:58Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

SzymczakJ · 2024-07-31T17:36:56Z

@hungvu193 since you have context, can you take a look? 🙏

hungvu193 · 2024-08-01T01:56:35Z

Sure thing. I'll review today 😄

hungvu193 · 2024-08-01T03:42:10Z

@SzymczakJ One question, Should we delete the value of Customer's Displayed as value if it was already SageIntacct Employee Default?

Screen.Recording.2024-08-01.at.10.39.18.mov

Similar other fields

Screen.Recording.2024-08-01.at.10.41.51.mov

SzymczakJ · 2024-08-01T08:34:43Z

That's a hard one for me.
When user will have a new account and new integration, then everything will be fine, because we won't give him the option to switch to Employee default when he shouldn't do it. The problem is with old accounts because some of them switched to Sage Intacct Employee default when we gave them that chance by mistake.
Adding migrateOnyx script is one of the options, but isn't that an overkill, since this feature came out of BETA like two days ago. Maybe we could ignore that few old workspaces that have wrong config and just tell everybody to create new ones for testing purposes. WDYT @hungvu193 @war-in

war-in · 2024-08-01T09:51:11Z

@SzymczakJ @hungvu193 I think we should ignore this because Sage Intacct is still in beta on production (it's not possible to access it on prod).

and just tell everybody to create new ones for testing purposes

They don't even have to create a new workspace. They just need to change the selection in settings

hungvu193 · 2024-08-01T09:52:25Z

@SzymczakJ Can you please resolve conflicts in the meantime?

hungvu193 · 2024-08-02T07:47:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-02.at.15.04.44.mov

Android: mWeb Chrome

Screen.Recording.2024-08-02.at.14.51.09.mov

iOS: Native

Screen.Recording.2024-08-02.at.15.00.59.mov

iOS: mWeb Safari

Screen.Recording.2024-08-02.at.14.50.05.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-02.at.14.34.30.mov

MacOS: Desktop

Screen.Recording.2024-08-02.at.14.36.51.mov

hungvu193

LGTM

melvin-bot · 2024-08-02T08:09:37Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #45823 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2024-08-02T12:53:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-06T04:28:29Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-07T22:04:19Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T04:53:56Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T20:05:20Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

SzymczakJ added 2 commits July 30, 2024 15:24

make employee default option only viable for departments, classes and…

5913244

… locations mappings

change mapping value to tag when setting reimbrusaible reports to VEN…

8d197bf

…DOR_BILL

war-in approved these changes Jul 31, 2024

View reviewed changes

SzymczakJ added 2 commits July 31, 2024 10:52

fix PR comments

5ce5a41

Merge branch 'main' into @szymczak/sage-intacct-employee-default-bug

f04eb76

SzymczakJ marked this pull request as ready for review July 31, 2024 17:33

SzymczakJ requested a review from a team as a code owner July 31, 2024 17:33

melvin-bot bot removed the request for review from a team July 31, 2024 17:33

melvin-bot bot requested a review from jayeshmangwani July 31, 2024 17:33

Merge branch 'main' into @szymczak/sage-intacct-employee-default-bug

b267d1c

hungvu193 approved these changes Aug 2, 2024

View reviewed changes

hungvu193 mentioned this pull request Aug 2, 2024

[HOLD for payment 2024-08-14] [$250] Customers and Projects have option as Sage Intacct Employee Default #45823

Closed

6 tasks

Gonals self-requested a review August 2, 2024 12:38

Gonals approved these changes Aug 2, 2024

View reviewed changes

Gonals merged commit c6e8f50 into Expensify:main Aug 2, 2024
15 checks passed

github-actions bot mentioned this pull request Aug 6, 2024

Deploy Checklist: New Expensify 2024-08-06 #46849

Closed

83 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Customers and Projects to not have option as Sage Intacct Employee Default #46505

Fix Customers and Projects to not have option as Sage Intacct Employee Default #46505

SzymczakJ commented Jul 30, 2024 •

edited

Loading

war-in left a comment

war-in Jul 31, 2024

melvin-bot bot commented Jul 31, 2024

SzymczakJ commented Jul 31, 2024

hungvu193 commented Aug 1, 2024

hungvu193 commented Aug 1, 2024 •

edited

Loading

SzymczakJ commented Aug 1, 2024

war-in commented Aug 1, 2024

hungvu193 commented Aug 1, 2024

hungvu193 commented Aug 2, 2024 •

edited

Loading

hungvu193 left a comment

melvin-bot bot commented Aug 2, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

		mappingName !== CONST.SAGE_INTACCT_CONFIG.MAPPINGS.CUSTOMERS &&
		mappingName !== CONST.SAGE_INTACCT_CONFIG.MAPPINGS.PROJECTS &&

Fix Customers and Projects to not have option as Sage Intacct Employee Default #46505

Fix Customers and Projects to not have option as Sage Intacct Employee Default #46505

Conversation

SzymczakJ commented Jul 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

war-in left a comment

Choose a reason for hiding this comment

war-in Jul 31, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Jul 31, 2024

SzymczakJ commented Jul 31, 2024

hungvu193 commented Aug 1, 2024

hungvu193 commented Aug 1, 2024 • edited Loading

SzymczakJ commented Aug 1, 2024

war-in commented Aug 1, 2024

hungvu193 commented Aug 1, 2024

hungvu193 commented Aug 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 2, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

SzymczakJ commented Jul 30, 2024 •

edited

Loading

hungvu193 commented Aug 1, 2024 •

edited

Loading

hungvu193 commented Aug 2, 2024 •

edited

Loading