-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] BUG: No RBR occurs when invalid credentials used to connect to Sage Intacct #45938
Comments
Triggered auto assignment to @stephanieelliott ( |
Job added to Upwork: https://www.upwork.com/jobs/~01f23c70a65cf3f85e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When invalid credentials are used to connect to Sage Intacct, no Retry, Backup, and Retry (RBR) mechanism is triggered, resulting in an "invalid credentials" or "authentication failure" error. What is the root cause of that problem?The root cause of this problem is likely due to an incorrect implementation of the Sage Intacct API or a misconfiguration of the connection settings, which prevents the RBR mechanism from kicking in when invalid credentials are used. What changes do you think we should make in order to solve the problem?To solve this problem, we need to review and adjust the Sage Intacct API implementation to ensure that it correctly handles invalid credentials and triggers the RBR mechanism. Specifically, we should: Verify Sage Intacct credentials and connection settings.
|
@kabeer95 Can you please familiarize yourself with our codebase and some old proposals on closed issues to understand what is expected in a proposal? |
@dylanexpensify @stephanieelliott Script link is of internal SO and is not accessible to everyone. Is there any way to add(or access script) the for adding/testing the test Sage Intacct? |
I was implementing this so you can assign me. |
@stephanieelliott please assign @SzymczakJ from SWM |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
This one's a backend bug so i'll try and patch it when I've got some spare cycles - adjusting the labels accordingly |
@NikkiWines @stephanieelliott @SzymczakJ @situchan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Sorry guys, been swamped with competing priorities these last few weeks, will try to prioritize this as soon as i have time |
🤔 Seems to be a RBR for me when I enter invalid creds locally, but I do see the Screen.Recording.2024-08-23.at.16.36.36.mov |
Not overdue |
Seems like both linked PRs are on prod now -- @NikkiWines are we ok to close this, or is there more to do? |
Thanks for the bump @stephanieelliott - I just re-tested the flow and I see a RBR and I don't see the double notification, so this one should be all good. |
Testing doc: here (request, will share)
Pre-testing steps
Daily
or “slower”Pre-testing steps
Steps:
Connect
Expected result: A RBR is shown on Accounting in LHN and on the Connections card in Accounting.
Actual result: No RBR is present, and the #admins page shows that the connection occurred
Screenshot LHN:
![Screenshot 2024-07-22 at 8 31 20 PM](https://private-user-images.githubusercontent.com/60117248/351090135-43c3ffef-3741-4b5a-8943-9e6366fd035f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQzOTgxMDQsIm5iZiI6MTczNDM5NzgwNCwicGF0aCI6Ii82MDExNzI0OC8zNTEwOTAxMzUtNDNjM2ZmZWYtMzc0MS00YjVhLTg5NDMtOWU2MzY2ZmQwMzVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE3VDAxMTAwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk2YTdlZTJlM2EzNTA0YTUzNDY3MWE0NmZhMTIwNjI0YTg1NmExNjg2ODNkNTQ2NDc1OThiNWVkZTEyZTMzY2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xiuPpNBcTGL-81YPmH_ph54ZphPcgN5qUiP6rm-EXvY)
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @NikkiWinesThe text was updated successfully, but these errors were encountered: