[$250] IOU - Distance tab flickering to manual & back to distance every time when add destination

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a753@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login with gmail account
2. Go to FAB> Submit Expense> Distance
3. Add a start destination> Your location
4. Check tabs (manual, scan, distance) behavior
5. Add stop destination
6. Check tabs (manual, scan, distance) behavior

Expected Result:

Distance tab should remain since we work on that tab

Actual Result:

Distance tab switch to manual and back to distance every time when add destination

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554014_1722020868045.Recording__3602.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7f69f2e00762143
• Upwork Job ID: 1817973479806682768
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @cdOut

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vip

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Christinadobrzyn]

I can reproduce this - only seems to be affecting Android web app. I think this can be external. I think this might be part of Collect since it's a distance expense.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7f69f2e00762143

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[Christinadobrzyn]

waiting on proposals

[Christinadobrzyn]

I'll see if someone at SWM would want this. https://expensify.slack.com/archives/C04878MDF34/p1722447232998509

[cdOut]

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’m going to be working on this task.

[Christinadobrzyn]

Awesome! Thank you @cdOut! I've assigned you to the GH.

[VincentCorleone]

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’m going to be working on this task.

@cdOut So can external contributors submit a proposal and get paid from upwork?

[cdOut]

@VincentCorleone I'm taking over this issue so no, there is no need for proposals.

[cdOut]

It's not raised yet, I'll let you know when I create it.

[cdOut]

Hi, quick update - I've picked back the issue and I'm searching for a solution that won't affect the side swiping on tabs, should raise a PR for it in the coming days.

[cdOut]

Short update, this is a pretty convoluted issue as fixing the flicker and allowing for the swipe causes another animation in tabs to break so I'm still researching a fix that won't disturb any other parts of the flow.

[Christinadobrzyn]

Just a heads up that I'm going to be ooo until 9/30. I'm not going to assign another BZ teammate since we're working on the fix side of this. If you need anyone please reach out in Slack for a volunteer.

[Christinadobrzyn]

payment summary here - #46346 (comment)

[mananjadhav]

@Christinadobrzyn this was reverted and the follow up PR is still pending. No payment yet on this one.

[cdOut]

I'm going to be raising a follow-up PR with another fix later today.

[mananjadhav]

Thanks for the update @cdOut

[cdOut]

I've found some discrepancies with animations while testing on native devices, will work on correcting it throughout today.

[Christinadobrzyn]

Hi @cdOut do you have an update? Thanks!

[mananjadhav]

@cdOut Quick bump on this one.

[cdOut]

Yes, sorry for not updating this thread. I got dragged back into debugging last issues with a more critical Guided Setup task, then I kept working on a possible update to the library both on their repo and on ours, an implementation with a fix that doesn't touch the animations when dragging will be up and out of draft in a PR in the coming days.

[Christinadobrzyn]

Hi @cdOut sorry to bother you but just checking on the PR - let us know if we can help with anything!

[cdOut]

Hi, I should have the draft up for review by the EOW.

[cdOut]

I've re-checked it during looking for a fix on the latest main branch, and it looks like there were changes made in the library / our codebase which fixed the issue. The recording below is from the latest main on android mWeb, looks like the issue has been resolved.

@mananjadhav If you could also re-test it on your end just to make sure the issue has been fixed. I've checked it both for android native and mWeb, the flicker doesn't appear anymore when opening the tab / navigating back to it from a subsection.

Screen.Recording.2024-10-28.at.09.04.40.mov

[blazejkustra]

@cdOut Can you link a PR in the upstream repo that fixed this issue? (or version of the library which fixed it)

[cdOut]

I've sifted through the recent PRs and it looks like there was a similar problem reported discussing the Submit expense tab which also fixed along this issue as well. The PR for it is here. Looks like Kuba decided to refactor the animations for the tab selector from the ground up.

[mananjadhav]

I can't reproduce it either. @Christinadobrzyn Does this need any further action?

If not, I would request you to consider partial payout for the work here. I reviewed a PR that ended up being reverted. Hence, requesting small partial payout.

[Christinadobrzyn]

I think we can close this if we can't reproduce it but @thienlnam, can you double-check that we can close this? I'm not sure if it should have QA test again?

[thienlnam]

I'll drop it in the QA room to have them re-test so we can confirm

EDIT: Post here

[kavimuru]

Issue not reproducible anymore

Recording.4473.mp4

[mananjadhav]

@Christinadobrzyn should we close it then? and also my request here ?

[Christinadobrzyn]

Yes, let's close. Since a PR was reviewed but also reverted, we can make a partial payment of 50%.

Payouts due:

• Reviewer: $125 @mananjadhav

Are you paid through NewDot?

[mananjadhav]

Yes paid via NewDot.

[Christinadobrzyn]

Sounds good! Thanks for all the work @cdOut and @mananjadhav!

Feel free to request the ND payment @mananjadhav - we'll close this.

[garrettmknight]

$125 approved for @mananjadhav