Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop #51020

kubabutkiewicz · 2024-10-17T14:01:26Z

Details

Removed interpolation from web platform because we already have disabled animations for those screens and the issue here was with position variable which was changing a lot during rendering of those components since its calculated based on screen width.

Fixed Issues

$ #50265
PROPOSAL:

Tests

Click on FAB and select submit expense
Click on distance and select either start or stop
Click back and observe the highlight jumps to manual and then to distance like a glitch

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on FAB and select submit expense
Click on distance and select either start or stop
Click back and observe the highlight jumps to manual and then to distance like a glitch

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

msafari.mp4

MacOS: Chrome / Safari

chrome.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-10-17T14:01:32Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/TabSelector/getOpacity/types.ts

src/components/TabSelector/getBackground/types.ts

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-18.at.14.00.44.mov

Android: mWeb Chrome

VID_20241018141529.mp4

iOS: Native

Screen.Recording.2024-10-18.at.13.55.46.mov

iOS: mWeb Safari

Screen.Recording.2024-10-18.at.13.53.35.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-18.at.13.50.12.mov

MacOS: Desktop

Screen.Recording.2024-10-18.at.13.58.33.mov

sobitneupane · 2024-10-18T08:43:27Z

@kubabutkiewicz I noticed a screen blink during the transition in mWeb. Initially, the Distance page is visible, then it briefly switches to a blank page before the Distance page reappears.

Untitled.mp4

Untitled.mov

kubabutkiewicz · 2024-10-18T12:07:25Z

True, but this is something which is also happening on main and I think it should be handled on seperate issue, wdyt @sobitneupane ?

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2024-10-18T15:27:07Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #50265 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

sobitneupane · 2024-10-18T15:28:57Z

Sure @kubabutkiewicz, if it's out of scope, we can handle it in a separate issue. @grgia , what do you think?

grgia · 2024-10-21T07:55:58Z

If it's happening on main as well that makes sense to me- have we already logged this issue @sobitneupane ?

sobitneupane · 2024-10-21T08:04:31Z

@grgia Nope. I don't think we have logged it yet.

grgia

@kubabutkiewicz could you please update the PR title to be more descriptive

kubabutkiewicz · 2024-10-21T08:34:57Z

Done @grgia

grgia

LGTM

melvin-bot · 2024-10-21T08:42:30Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

grgia · 2024-10-21T08:42:59Z

^ was a bit trigger happy and didn't wait for the reviewer checklist to pass

OSBotify · 2024-10-21T08:52:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:49:00Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T16:26:27Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-djouah · 2024-11-15T23:09:55Z

src/components/TabSelector/getOpacity/index.native.ts

+
+        return position?.interpolate({
+            inputRange,
+            outputRange: inputRange.map((i) => (affectedTabs.includes(tabIndex) && i === tabIndex && isActive ? activeValue : inactiveValue)),


FYI, this caused the following issue: #51297
In this PR, we appropriately modified the getBackgroundColor logic to differentiate between web and native platforms, using interpolation based on position variable for native and using isActive variable check for web. However, for getOpacity, we mistakenly combined both approaches (interpolation based on position variable and isActive variable check), which led to inconsistencies.
We need to remove isActive variable check from here.
More details can be found in this proposal: #51297 (comment)

ntdiary · 2024-11-19T07:54:33Z

src/components/TabSelector/TabSelector.tsx

@@ -98,10 +69,10 @@ function TabSelector({state, navigation, onTabPress = () => {}, position, onFocu
        <FocusTrapContainerElement onContainerElementChanged={onFocusTrapContainerElementChanged}>
            <View style={styles.tabSelector}>
                {state.routes.map((route, index) => {
-                    const activeOpacity = getOpacity(position, state.routes.length, index, true, affectedAnimatedTabs);
-                    const inactiveOpacity = getOpacity(position, state.routes.length, index, false, affectedAnimatedTabs);
-                    const backgroundColor = getBackgroundColor(state.routes.length, index, affectedAnimatedTabs);


Coming from #51821.
For the mWeb platform, removing these interpolations also stops the listener in useTabNavigatorFocus from being triggered. As a result, isTabActive doesn't update as expected, causing infinite loading in the scan option page.

fix: remove interpolation from web platoform as animations are disabled

fba2945

kubabutkiewicz requested a review from a team as a code owner October 17, 2024 14:01

melvin-bot bot requested review from sobitneupane and removed request for a team October 17, 2024 14:01

rezkiy37 suggested changes Oct 17, 2024

View reviewed changes

src/components/TabSelector/getOpacity/types.ts Outdated Show resolved Hide resolved

src/components/TabSelector/getOpacity/types.ts Outdated Show resolved Hide resolved

src/components/TabSelector/getBackground/types.ts Outdated Show resolved Hide resolved

sobitneupane reviewed Oct 18, 2024

View reviewed changes

fix comments

53b76c9

sobitneupane approved these changes Oct 18, 2024

View reviewed changes

melvin-bot bot requested a review from grgia October 18, 2024 15:27

grgia reviewed Oct 21, 2024

View reviewed changes

kubabutkiewicz changed the title ~~Fix/50265~~ Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop Oct 21, 2024

grgia approved these changes Oct 21, 2024

View reviewed changes

grgia merged commit 44f5c5c into Expensify:main Oct 21, 2024
20 checks passed

melvin-bot bot added the Emergency label Oct 21, 2024

grgia removed the Emergency label Oct 21, 2024

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

Krishna2323 mentioned this pull request Oct 22, 2024

[HOLD for payment 2024-11-14] [$250] Android -Distance - Distance tab is gray and not highlighted in green when swiping to Distance #51297

Closed

8 tasks

melvin-bot bot mentioned this pull request Oct 23, 2024

[HOLD for payment 2024-10-30] [$250] Mweb/Chrome Android - Submit expense - Highlight jumps to manual when clicking back from start/stop #50265

Closed

6 tasks

cdOut mentioned this pull request Oct 31, 2024

[$250] IOU - Distance tab flickering to manual & back to distance every time when add destination #46346

Closed

6 tasks

QichenZhu mentioned this pull request Nov 1, 2024

[HOLD for payment 2024-11-20] [$250] Scan - Infinite loading for scan option if it is selected after manual. #51821

Closed

8 tasks

rayane-djouah reviewed Nov 15, 2024

View reviewed changes

ntdiary reviewed Nov 19, 2024

View reviewed changes

QichenZhu mentioned this pull request Nov 21, 2024

iOS - Distance - Scan tab shows black background after swiping left to go to Distance #52831

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop #51020

Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop #51020

kubabutkiewicz commented Oct 17, 2024 •

edited

Loading

melvin-bot bot commented Oct 17, 2024

sobitneupane left a comment •

edited

Loading

sobitneupane commented Oct 18, 2024

kubabutkiewicz commented Oct 18, 2024

sobitneupane left a comment

melvin-bot bot commented Oct 18, 2024

sobitneupane commented Oct 18, 2024

grgia commented Oct 21, 2024

sobitneupane commented Oct 21, 2024

grgia left a comment

kubabutkiewicz commented Oct 21, 2024

grgia left a comment

melvin-bot bot commented Oct 21, 2024

grgia commented Oct 21, 2024

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

rayane-djouah Nov 15, 2024

ntdiary Nov 19, 2024

Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop #51020

Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop #51020

Conversation

kubabutkiewicz commented Oct 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 17, 2024

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Oct 18, 2024

kubabutkiewicz commented Oct 18, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

melvin-bot bot commented Oct 18, 2024

sobitneupane commented Oct 18, 2024

grgia commented Oct 21, 2024

sobitneupane commented Oct 21, 2024

grgia left a comment

Choose a reason for hiding this comment

kubabutkiewicz commented Oct 21, 2024

grgia left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 21, 2024

grgia commented Oct 21, 2024

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

rayane-djouah Nov 15, 2024

Choose a reason for hiding this comment

ntdiary Nov 19, 2024

Choose a reason for hiding this comment

kubabutkiewicz commented Oct 17, 2024 •

edited

Loading

sobitneupane left a comment •

edited

Loading