[HOLD for payment 2024-11-18] [$250] New users seeing Expensify (notifications@expensify.com) in Contacts

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727214973622039

Action Performed:

1. Sign up for a new account
2. Selected Manage my team as intention
3. Go through onboarding
4. Select Start chat

Expected Result:

Expensify DM not displayed in contacts as it is deprecated

Actual Result:

Expensify (notifications@expensify.com)is displayed in my contacts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.574.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839750030898104642
• Upwork Job ID: 1839750030898104642
• Last Price Increase: 2024-10-04
• Automatic offers:
• ahmedGaber93 | Reviewer | 104411774
• Nodebrute | Contributor | 104411779

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-30 21:09:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

New users seeing Expensify (notifications@expensify.com) in Contacts

What is the root cause of that problem?

In here we are not excluding the CONST.EMAIL.NOTIFICATIONS

What changes do you think we should make in order to solve the problem?

We should add CONST.EMAIL.NOTIFICATIONS in excluded emails here We can do something like the pseudo code

   const excludedEmails = isGroupChat 
    ? excludedGroupEmails
    : [CONST.EMAIL.NOTIFICATIONS];

and then we can pass excludedEmails here

A more clean way to do this will be by passing CONST.EMAIL.NOTIFICATIONS here

 isGroupChat ? excludedGroupEmails : [CONST.EMAIL.NOTIFICATIONS]

What alternative solutions did you explore? (Optional)

We can add here CONST.EMAIL.NOTIFICATIONS

App/src/libs/OptionsListUtils.ts

Line 1910 in dc74ee3

const optionsToExclude: Option[] = [];

   const optionsToExclude: Option[] = [{login: CONST.EMAIL.NOTIFICATIONS}];

[mkzie2]

Edited by proposal-police: This proposal was edited at 2023-10-03T22:41:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify notifications@expensify.com is displayed in my contacts.

What is the root cause of that problem?

• The notifications@expensify.com account sends automated messages when SmartScan fails. We've already prevented users from chatting with this account and hidden it from search and the LHN in this PR. However, since it's been a while and we've refactored our search logic, we're now missing a few cases where the notifications@expensify.com email also needs to be filtered out.

• All our report and contact data across the search pages come from the OptionsListContextProvider. Within this provider, we use createOptionList to generate the options, but it does not filter out contacts where its login is notifications@expensify.com.

What changes do you think we should make in order to solve the problem?

We should add:

?.filter((o) => o.login !== CONST.EMAIL.NOTIFICATIONS)

to this data:

App/src/libs/OptionsListUtils.ts

Line 1553 in dc74ee3

}));

• This will ensure that all notification emails are filtered out across the search pages and improve the app's performance, as we're using OptionsListContextProvider, which only updates its data when the personalDetailList changes.

[mkzie2]

Proposal updated

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839750030898104642

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-09-30 21:45:00 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

New users seeing Expensify (notifications@expensify.com) in Contacts

What is the root cause of that problem?

• We have a list of excludedGroupEmails which includes all the Expensify emails including notifications@expensify.com except concierge@expensify.com, because use can chat with concierge.
  

  App/src/pages/NewChatPage.tsx

  Line 60 in 3047c1b

  isGroupChat ? excludedGroupEmails : [],

  
  

  App/src/pages/NewChatPage.tsx

  Line 82 in 3047c1b

  excludeLogins: isGroupChat ? excludedGroupEmails : [],

  
  

  App/src/CONST.ts

  Lines 2718 to 2737 in 3047c1b

  	get EXPENSIFY_EMAILS() {
  	return [
  	this.EMAIL.ACCOUNTING,
  	this.EMAIL.ADMIN,
  	this.EMAIL.BILLS,
  	this.EMAIL.CHRONOS,
  	this.EMAIL.CONCIERGE,
  	this.EMAIL.CONTRIBUTORS,
  	this.EMAIL.FIRST_RESPONDER,
  	this.EMAIL.HELP,
  	this.EMAIL.INTEGRATION_TESTING_CREDS,
  	this.EMAIL.NOTIFICATIONS,
  	this.EMAIL.PAYROLL,
  	this.EMAIL.QA,
  	this.EMAIL.QA_TRAVIS,
  	this.EMAIL.RECEIPTS,
  	this.EMAIL.STUDENT_AMBASSADOR,
  	this.EMAIL.SVFG,
  	];
  	},

• The excludedGroupEmails list is only passed as excludeLogins if isGroupChat is true, but currently, we are not using the isGroupChat check anywhere. isGroupChat is a prop, but it isn't passed when using NewChatPage. It seems redundant, and we might have missed removing it when the component was refactored.

App/src/pages/NewChatSelectorPage.tsx

Lines 57 to 63 in 3047c1b

	<TopTab.Screen name={CONST.TAB.NEW_CHAT}>
	{() => (
	<TabScreenWithFocusTrapWrapper>
	<NewChatPage />
	</TabScreenWithFocusTrapWrapper>
	)}
	</TopTab.Screen>

What changes do you think we should make in order to solve the problem?


• We should remove the isGroupChat check and always pass excludedGroupEmails.
• When passing excludedGroupEmails, we can check if we need to include any other id like we do for concierge.
  

  App/src/pages/NewChatPage.tsx

  Line 40 in 3047c1b

  const excludedGroupEmails = CONST.EXPENSIFY_EMAILS.filter((value) => value !== CONST.EMAIL.CONCIERGE);

• We should also remove the prop and prop definition as it isn't used anywhere.

What alternative solutions did you explore? (Optional)

• We can remove isGroupChat check and always pass CONST.EMAIL.NOTIFICATIONS as excludedLogins.
• We should also remove the Add to group buttons for Expensify emails except concierge's email. To do this we can add || excludedGroupEmails.includes(item.login) to the condition below.
  

  App/src/pages/NewChatPage.tsx

  Lines 231 to 233 in 96d8973

  	if (!!item.isSelfDM || (item.accountID && CONST.NON_ADDABLE_ACCOUNT_IDS.includes(item.accountID))) {
  	return null;
  	}

• We can add {login: CONST.EMAIL.NOTIFICATIONS} in the array below.
  https://github.com/Krishna2323/App/blob/b1720c7a420a5f5e5482f40b8a6a31459c909d18/src/libs/OptionsListUtils.ts#L1910

Result

[joekaufmanexpensify]

pending review of proposals by @ahmedGaber93

[ahmedGaber93]

Reviewing today

[ahmedGaber93]

@Nodebrute thanks for the proposal.

const excludedEmails = isGroupChat
? [CONST.EMAIL.NOTIFICATIONS, ...excludedGroupEmails]
: [CONST.EMAIL.NOTIFICATIONS];

excludedGroupEmails already have CONST.EMAIL.NOTIFICATIONS, no need to add it again in isGroupChat case

[ahmedGaber93]

@mkzie2 thanks for the proposal.

We've already prevented users from chatting with this account and hidden it from search and the LHN in #32340.

Yeah, but we allowed it again here

[Nodebrute]

@ahmedGaber93 Sorry, it's just pseudocode. The main solution was to add [CONST.EMAIL.NOTIFICATIONS] in excludedEmails. I have updated the code

[Nodebrute]

Proposal Updated
Added a more clean way to do it. The logic is same as my main solution. I have just added a clean way of doing it.

[ahmedGaber93]

@Krishna2323 thanks for the proposal.
I don't think we need to prevent the user from starting chat with all excludedGroupEmails, I think we need only CONST.EMAIL.NOTIFICATIONS

[joekaufmanexpensify]

Hm, I just updated it? That is wrong.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• hide expensify from new chat page #50937

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment (Needs manual offer from BZ)
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

@ahmedGaber93 @joekaufmanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[joekaufmanexpensify]

@ahmedGaber93 could you please do the checklist so we can prep for payment?

[ahmedGaber93]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/41290/files#r1847982516

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Case 1

1. Login with new account
2. Go to FAB -> Start chat
3. Verify you don't seen Expensify(notifications@expensify.com) in contacts by default or by search

Case 2

1. Go To FAB -> Start chat
2. Enter one of system emails except concierge@expensify.com in the search field
3. Verify there is no "add to group" button next to those emails

Do we agree 👍 or 👎

[ahmedGaber93]

@joekaufmanexpensify Sorry for the delay, checklist is completed

[joekaufmanexpensify]

TY! regression test issue is here: https://github.com/Expensify/Expensify/issues/446304

[joekaufmanexpensify]

All set to issue payment. We need to pay:

• @Nodebrute - $125 for PR (half because we decided to split payment between two contributors here) via upwork.
• @Krishna2323 - $125 for PR (half because we decided to split payment between two contributors here) via upwork.
• @ahmedGaber93 - $250 for C+ via Upwork.

[joekaufmanexpensify]

@ahmedGaber93 $250 sent and contract ended!

[joekaufmanexpensify]

OG upwork job closed, so need to open a new one to pay @Nodebrute and @Krishna2323

[joekaufmanexpensify]

@Krishna2323 offer sent for $125!

[joekaufmanexpensify]

@Nodebrute offer sent for $125

[Krishna2323]

offer accepted :)

[joekaufmanexpensify]

@Krishna2323 $125 sent and contract ended!

[joekaufmanexpensify]

@Nodebrute $125 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!