hide expensify from new chat page #50937

Nodebrute · 2024-10-16T18:52:33Z

Details

Fixed Issues

$ #49673
PROPOSAL: #49673 (comment)

Tests

Test 1

Go to FAB -> Start chat
verify there is no Expensify displayed in contacts

Test 2

Go To FAB -> Start chat
Enter "accounting@expensify.com" in the field
Verify there is no add to group button next to "accounting@expensify.com"
Repeat the above steps (1-3) for other system emails (except "concierge@expensify.com")

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Test 1

Go to FAB -> Start chat
verify there is no Expensify displayed in contacts

Test 2

Go To FAB -> Start chat
Enter "accounting@expensify.com" in the field
Verify there is no add to group button next to "accounting@expensify.com"
Repeat the above steps (1-3) for other system emails (except "concierge@expensify.com")

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-17T19:00:54Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2024-10-21T15:32:02Z

@Krishna2323 bump for first review.

ahmedGaber93 · 2024-10-22T15:43:27Z

@Krishna2323 What is your estimation here? Are you available to finish it today?

Krishna2323 · 2024-10-22T15:48:55Z

@ahmedGaber93, I'm waiting for @Nodebrute's response on this:

ahmedGaber93 · 2024-10-22T15:58:06Z

@Krishna2323 your review still pending and not submitted, you should submit it, follow here step 10 to submit it. Another helpful video.

Krishna2323

@Nodebrute, some minor changes needed.

Krishna2323 · 2024-10-18T18:22:21Z

src/pages/NewChatPage.tsx

@@ -38,7 +38,7 @@ type NewChatPageProps = {
    isGroupChat?: boolean;


@Nodebrute, please remove isGroupChat prop as its been not used anywhere in the component.

@Nodebrute bump

@Krishna2323 I’ve removed all instances where the isGroupChat prop was used.

Thanks, looks good to me 🙌🏻. @ahmedGaber93 we can move forward here.

Krishna2323 · 2024-10-22T16:17:05Z

@ahmedGaber93, really sorry for that, I haven't reviewed a PR before this.

ahmedGaber93 · 2024-10-23T15:36:56Z

@Nodebrute could you please update "Tests" with all test cases?

ahmedGaber93 · 2024-10-23T15:43:25Z

src/pages/NewChatPage.tsx

@@ -229,7 +229,7 @@ function NewChatPage({isGroupChat}: NewChatPageProps) {

    const itemRightSideComponent = useCallback(
        (item: ListItem & OptionsListUtils.Option, isFocused?: boolean) => {
-            if (!!item.isSelfDM || (item.accountID && CONST.NON_ADDABLE_ACCOUNT_IDS.includes(item.accountID))) {
+            if (!!item.isSelfDM || (item.login && excludedGroupEmails.includes(item.login))) {


Can you add more context about using login instead of accountID? Is there any comparison between them?

Yes, the excludedGroupEmails contains the logins of all Expensify accounts. That's why I'm using login here. Previously, we were using NON_ADDABLE_ACCOUNT_IDS, which had the account IDs for CHRONOS and NOTIFICATIONS. However, excludedGroupEmails also includes the logins for these two accounts.

More context about using login instead of accountID is accountID can be optimisticAccountID in userToInvite util API respond with the full user data

App/src/libs/OptionsListUtils.ts

Lines 1661 to 1664 in 652d2ff

[optimisticAccountID]: {

accountID: optimisticAccountID,

login: searchValue,

},

And this can cause this issue

Login with new account (to confirm there is no local data)

Click fab > start chat

Search for chronos@expensify.com for the first time

You will see add to group is displayed temporary, and you can add it to group util API respond with the full user data.

issue.mp4

I think we need to remove NON_ADDABLE_ACCOUNT_IDS because it is not used in anywhere now

ahmedGaber93 · 2024-10-27T07:36:03Z

@Nodebrute could you please update "Tests" with all test cases? We need to confirm user is not able to add system emails to groups.

ahmedGaber93 · 2024-10-27T08:10:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

d.mp4

Nodebrute · 2024-10-29T02:40:34Z

I will update this in few hours

Nodebrute · 2024-10-29T14:40:13Z

@Nodebrute could you please update "Tests" with all test cases? We need to confirm user is not able to add system emails to groups.

Could you help me with the tests? I’m unsure where to add these tests.

ahmedGaber93 · 2024-10-29T15:30:37Z

@Nodebrute Sorry, I mean QA Steps not tests in the code.

Nodebrute · 2024-10-29T15:39:52Z

Apologies for the mix-up. I’ve updated the tests now.

ahmedGaber93

LGTM!

joekaufmanexpensify · 2024-11-04T16:03:31Z

@lakchote are we good to merge this?

Nodebrute · 2024-11-05T18:30:21Z

Hey @lakchote, just a friendly reminder to merge this when you have a moment. Thanks!

lakchote · 2024-11-06T08:10:07Z

Sorry @joekaufmanexpensify @Nodebrute I thought I had merged this. It's done now.

OSBotify · 2024-11-06T08:20:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

joekaufmanexpensify · 2024-11-06T13:03:23Z

All good. TY!

github-actions · 2024-11-07T13:08:29Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-11T18:14:04Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Nodebrute added 3 commits October 16, 2024 23:49

hide expensify from new chat page

5866325

fix type error

039f0d6

fix lint error

0fd9a41

Nodebrute marked this pull request as ready for review October 17, 2024 19:00

Nodebrute requested a review from a team as a code owner October 17, 2024 19:00

melvin-bot bot requested review from ahmedGaber93 and removed request for a team October 17, 2024 19:00

Nodebrute mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-11-18] [$250] New users seeing Expensify (notifications@expensify.com) in Contacts #49673

Closed

6 tasks

Krishna2323 suggested changes Oct 22, 2024

View reviewed changes

ahmedGaber93 reviewed Oct 23, 2024

View reviewed changes

Nodebrute and others added 2 commits October 24, 2024 04:00

Merge branch 'Expensify:main' into hideexpensify

0c50840

remove is group chat

1a6950b

Nodebrute and others added 2 commits October 29, 2024 17:54

Merge branch 'Expensify:main' into hideexpensify

694ecd7

remove unused var

6916c06

ahmedGaber93 approved these changes Oct 29, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote October 29, 2024 16:04

lakchote approved these changes Oct 29, 2024

View reviewed changes

lakchote merged commit 2699cbe into Expensify:main Nov 6, 2024
18 checks passed

github-actions bot mentioned this pull request Nov 7, 2024

Deploy Checklist: New Expensify 2024-11-07 #52178

Closed

60 tasks

ahmedGaber93 mentioned this pull request Nov 19, 2024

Allow system account chat to be listed in LHN, fix chat icons #41290

Merged

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hide expensify from new chat page #50937

hide expensify from new chat page #50937

Nodebrute commented Oct 16, 2024 •

edited

Loading

melvin-bot bot commented Oct 17, 2024

ahmedGaber93 commented Oct 21, 2024

ahmedGaber93 commented Oct 22, 2024

Krishna2323 commented Oct 22, 2024

ahmedGaber93 commented Oct 22, 2024 •

edited

Loading

Krishna2323 left a comment

Krishna2323 Oct 18, 2024

Krishna2323 Oct 21, 2024

Nodebrute Oct 23, 2024

Krishna2323 Oct 27, 2024

Krishna2323 commented Oct 22, 2024

ahmedGaber93 commented Oct 23, 2024

ahmedGaber93 Oct 23, 2024

Nodebrute Oct 23, 2024

ahmedGaber93 Oct 27, 2024

ahmedGaber93 Oct 27, 2024

ahmedGaber93 commented Oct 27, 2024

ahmedGaber93 commented Oct 27, 2024 •

edited

Loading

Nodebrute commented Oct 29, 2024

Nodebrute commented Oct 29, 2024

ahmedGaber93 commented Oct 29, 2024

Nodebrute commented Oct 29, 2024

ahmedGaber93 left a comment

joekaufmanexpensify commented Nov 4, 2024

Nodebrute commented Nov 5, 2024

lakchote commented Nov 6, 2024

OSBotify commented Nov 6, 2024

joekaufmanexpensify commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 11, 2024

		@@ -38,7 +38,7 @@ type NewChatPageProps = {
		isGroupChat?: boolean;

	[optimisticAccountID]: {
	accountID: optimisticAccountID,
	login: searchValue,
	},

hide expensify from new chat page #50937

hide expensify from new chat page #50937

Conversation

Nodebrute commented Oct 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 17, 2024

ahmedGaber93 commented Oct 21, 2024

ahmedGaber93 commented Oct 22, 2024

Krishna2323 commented Oct 22, 2024

ahmedGaber93 commented Oct 22, 2024 • edited Loading

Krishna2323 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krishna2323 commented Oct 22, 2024

ahmedGaber93 commented Oct 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahmedGaber93 commented Oct 27, 2024

ahmedGaber93 commented Oct 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Nodebrute commented Oct 29, 2024

Nodebrute commented Oct 29, 2024

ahmedGaber93 commented Oct 29, 2024

Nodebrute commented Oct 29, 2024

ahmedGaber93 left a comment

Choose a reason for hiding this comment

joekaufmanexpensify commented Nov 4, 2024

Nodebrute commented Nov 5, 2024

lakchote commented Nov 6, 2024

OSBotify commented Nov 6, 2024

joekaufmanexpensify commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 11, 2024

Nodebrute commented Oct 16, 2024 •

edited

Loading

ahmedGaber93 commented Oct 22, 2024 •

edited

Loading

ahmedGaber93 commented Oct 27, 2024 •

edited

Loading