[HOLD for payment 2024-10-22] [$50] Payment - "Payment Complete" is not in Spanish.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login in any account
2. Change The language preference to Spanish
3. Go to workspace chat
4. Submit an expense
5. Click Pay elsewhere button in the expense preview on the main chat

Expected Result:

"Payment completed" should be in Spanish

Actual Result:

It shows "Payment completed" animation. "Payment completed" is not changed to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6616952_1727412640910.Screen_Recording_2024-09-26_at_3.27.15_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839725639165419380
• Upwork Job ID: 1839725639165419380
• Last Price Increase: 2024-09-30
• Automatic offers:
• Nodebrute | Contributor | 104193255

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Payment Complete" is not in Spanish.

What is the root cause of that problem?

We are not using a en.ts/es.ts variable here

App/src/components/SettlementButton/AnimatedSettlementButton.tsx

Line 80 in 05ca35c

<Text style={[styles.buttonMediumText]}>Payment complete</Text>

What changes do you think we should make in order to solve the problem?

We should create a variable in both en.ts/es.ts files and use it here instead of payment complete

App/src/components/SettlementButton/AnimatedSettlementButton.tsx

Line 80 in 05ca35c

<Text style={[styles.buttonMediumText]}>Payment complete</Text>

In es.ts file we'll use Spanish translation of payment complete

Optional: we can use payment completed instead of payment complete

What alternative solutions did you explore? (Optional)

Wr can check in both en.ts/es.ts files if we already have a variable for this then we can use it here

App/src/components/SettlementButton/AnimatedSettlementButton.tsx

Line 80 in 05ca35c

<Text style={[styles.buttonMediumText]}>Payment complete</Text>

[Bakhtiar85]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The current issue is that the "Payment complete" text displayed after completing a payment in the workspace chat is not translated to Spanish, despite the user's language preference being set to Spanish.

What is the root cause of that problem?

The root cause of the issue is that the text "Payment complete" is hardcoded in the component AnimatedSettlementButton.tsx at line 80. Instead of using translation keys from en.ts and es.ts files, it directly displays the English text.

What changes do you think we should make in order to solve the problem?

We should refactor the code to replace the hardcoded "Payment complete" text with a variable that pulls the translation from the language files (en.ts for English and es.ts for Spanish).

Steps:

1. Add a translation key for "Payment complete" in both en.ts and es.ts.

   • In en.ts, we will add something like: paymentComplete: 'Payment complete'.
   • In es.ts, we will add: paymentComplete: 'Pago completado' (which means "Payment completed" in Spanish).

2. Modify the code in AnimatedSettlementButton.tsx to use the variable instead of the hardcoded text:

   <Text style={[styles.buttonMediumText]}>{translate('paymentComplete')}</Text>

[melvin-bot]

📣 @Bakhtiar85! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Bakhtiar85]

Contributor details
Your Expensify account email: makhdoomabubakar85@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017304c8ed7eb17c49

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839725639165419380

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[alexpensify]

@getusha when you get a chance, can you please review if one of these proposals will fix this issue? Thanks!

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Payment - "Payment Complete" is not in Spanish

What is the root cause of that problem?

• "Payment Complete" is hard coded here, instead of using translate function
  

  App/src/components/SettlementButton/AnimatedSettlementButton.tsx

  Line 80 in 461d574

  <Text style={[styles.buttonMediumText]}>Payment complete</Text>

What changes do you think we should make in order to solve the problem?

• add paymentComplete: 'Payment comptete' , here
  

  App/src/languages/en.ts

  Line 826 in 461d574

  submitExpense: 'Submit expense',

• And add Spanish translation paymentComplete: 'pago completo' , here
  

  App/src/languages/es.ts

  Line 878 in 461d574

  settledElsewhere: 'Pagado de otra forma',

• And use translate(paymentComplete) here

                    <Text style={[styles.buttonMediumText]}>${translate('iou.paymentComplete')}</Text>

App/src/components/SettlementButton/AnimatedSettlementButton.tsx

Line 80 in 3047c1b

<Text style={[styles.buttonMediumText]}>Payment complete</Text>

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[getusha]

@Nodebrute's proposal looks good to me.
🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[getusha]

@flodnv we can adjust the price, as this is a relatively minor and straightforward change.

[melvin-bot]

Upwork job price has been updated to $50

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

PR will be ready in few hours

[alexpensify]

Update: PR needs a review by @getusha

[alexpensify]

Update: The PR is moving along through the review process

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add spanish translation #49921

If no regressions arise, payment will be issued on 2024-10-22. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment through NewDot Manual Requests
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

Payouts due: 2024-10-22

• Contributor: $50 @Nodebrute - paid via Upwork
• Reviewer: $50 @getusha - please submit a request in Chat, thanks!

Upwork job is here.

[getusha]

@alexpensify the issue is priced $50

[getusha]

[@getusha] The PR that introduced the bug has been identified. Link to the PR:
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48615/files#r1818509777
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug. No, it's a minor issue
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a

[alexpensify]

Thanks, @getusha, for the bump. I've updated the payment summary - #49840 (comment).

[garrettmknight]

$50 approved for @getusha