add spanish translation #49921

Nodebrute · 2024-09-30T12:22:30Z

Details

Fixed Issues

$ #49840
PROPOSAL: #49840 (comment)

Tests

Change The language preference to Spanish
Go to workspace chat
Submit an expense
Click Pay elsewhere button in the expense preview on the main chat
Verify you can see Pago Completo

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Change The language preference to Spanish
Go to workspace chat
Submit an expense
Click Pay elsewhere button in the expense preview on the main chat
Verify you can see Pago Completo

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-01.at.8.18.16.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-01.at.8.23.30.PM.mov

iOS: Native

Screen.Recording.2024-09-30.at.4.36.22.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-30.at.4.31.13.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-30.at.4.11.36.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-02.at.5.21.10.PM.mov

melvin-bot · 2024-10-02T12:23:32Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nodebrute · 2024-10-04T18:12:55Z

@getusha friendly bump for review.

getusha · 2024-10-08T12:56:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-08.at.5.11.06.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-10-08.at.4.24.31.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-10-09.at.5.39.52.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-10-08.at.4.31.22.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-08.at.4.13.47.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-10-08.at.4.31.22.in.the.afternoon.mov

getusha · 2024-10-08T12:58:14Z

src/languages/en.ts

@@ -1021,6 +1021,7 @@ const translations = {
        bookingPendingDescription: "This booking is pending because it hasn't been paid yet.",
        bookingArchived: 'This booking is archived',
        bookingArchivedDescription: 'This booking is archived because the trip date has passed. Add an expense for the final amount if needed.',
+        paymentComplete: 'Payment Complete',


Suggested change

paymentComplete: 'Payment Complete',

paymentComplete: 'Payment complete',

i think it should be like this

@flodnv wdyt?

I agree, like everything else around it. Same in Spanish.

@flodnv You can review the changes.

Co-authored-by: Getabalew <75031127+getusha@users.noreply.github.com>

Nodebrute · 2024-10-08T16:53:42Z

Thanks, @getusha! I've fixed it. Previously, it was written as Payment complete, so I used the same. Should we confirm this with someone?

flodnv · 2024-10-09T15:08:49Z

src/languages/en.ts

@@ -1021,6 +1021,7 @@ const translations = {
        bookingPendingDescription: "This booking is pending because it hasn't been paid yet.",
        bookingArchived: 'This booking is archived',
        bookingArchivedDescription: 'This booking is archived because the trip date has passed. Add an expense for the final amount if needed.',
+        paymentComplete: 'Payment Complete',


I agree, like everything else around it. Same in Spanish.

flodnv · 2024-10-10T14:15:33Z

src/languages/es.ts

@@ -1021,6 +1021,7 @@ const translations = {
        bookingPendingDescription: 'Esta reserva está pendiente porque aún no se ha pagado.',
        bookingArchived: 'Esta reserva está archivada',
        bookingArchivedDescription: 'Esta reserva está archivada porque la fecha del viaje ha pasado. Agregue un gasto por el monto final si es necesario.',
+        paymentComplete: 'Pago completo',


Did a Spanish speaker double check this translation?

Maybe there's something better?

Yes, https://expensify.slack.com/archives/C01GTK53T8Q/p1727693880110539

used this
and it gives me a different response

Pago completado.

Chatgpt's response "Pago completo" in English means "Payment complete".

I trust native Spanish speakers more than ChatGPT and Google Translate 🙃

So I'm happy that Alberto approved it (he is Spanish)

OSBotify · 2024-10-10T14:39:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-10T23:11:02Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-15T03:16:44Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.48-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Nodebrute and others added 2 commits September 30, 2024 16:13

add spanish translation

fdd6880

Merge branch 'main' into spanish

a815bb3

Nodebrute marked this pull request as ready for review October 2, 2024 12:23

Nodebrute requested a review from a team as a code owner October 2, 2024 12:23

melvin-bot bot requested review from getusha and removed request for a team October 2, 2024 12:23

getusha reviewed Oct 8, 2024

View reviewed changes

Nodebrute and others added 3 commits October 8, 2024 21:49

Update src/languages/en.ts

12d696f

Co-authored-by: Getabalew <75031127+getusha@users.noreply.github.com>

Merge branch 'Expensify:main' into spanish

25b8297

fix C

566c38f

getusha approved these changes Oct 9, 2024

View reviewed changes

melvin-bot bot requested a review from flodnv October 9, 2024 14:42

flodnv requested changes Oct 9, 2024

View reviewed changes

fix capital c

469c2e1

Nodebrute requested a review from flodnv October 10, 2024 14:13

flodnv reviewed Oct 10, 2024

View reviewed changes

flodnv approved these changes Oct 10, 2024

View reviewed changes

flodnv merged commit fed5508 into Expensify:main Oct 10, 2024
24 checks passed

github-actions bot mentioned this pull request Oct 10, 2024

Deploy Checklist: New Expensify 2024-10-10 #50603

Closed

38 tasks

melvin-bot bot mentioned this pull request Oct 15, 2024

[HOLD for payment 2024-10-22] [$50] Payment - "Payment Complete" is not in Spanish. #49840

Closed

6 tasks

Nodebrute deleted the spanish branch October 29, 2024 19:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add spanish translation #49921

add spanish translation #49921

Nodebrute commented Sep 30, 2024 •

edited

Loading

melvin-bot bot commented Oct 2, 2024

Nodebrute commented Oct 4, 2024

getusha commented Oct 8, 2024 •

edited

Loading

getusha Oct 8, 2024

getusha Oct 9, 2024

flodnv Oct 9, 2024

Nodebrute Oct 9, 2024

Nodebrute commented Oct 8, 2024

flodnv Oct 9, 2024

flodnv Oct 10, 2024

Nodebrute Oct 10, 2024

getusha Oct 10, 2024

Nodebrute Oct 10, 2024

getusha Oct 10, 2024

flodnv Oct 10, 2024

flodnv Oct 10, 2024

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 15, 2024

	paymentComplete: 'Payment Complete',
	paymentComplete: 'Payment complete',

add spanish translation #49921

add spanish translation #49921

Conversation

Nodebrute commented Sep 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 2, 2024

Nodebrute commented Oct 4, 2024

getusha commented Oct 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nodebrute commented Oct 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 15, 2024

Nodebrute commented Sep 30, 2024 •

edited

Loading

getusha commented Oct 8, 2024 •

edited

Loading